Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034646Openbravo ERPY. DBSourceManagerpublic2016-11-28 12:122016-12-16 18:39
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034646: Comments should be queried from user tables
DescriptionComments used to keep db consistency in Oracle are currently being stored in the following tables: ALL_TAB_COMMENTS[1] and ALL_COL_COMMENTS [2]. Therefore, users within the same DB can see the comments stored in those tables event if they are not the owners of the comment.

This can cause errors when using the comments to update/export the database as comments from other users could be retrieved instead of the expected ones.


[1] https://docs.oracle.com/cd/B19306_01/server.102/b14237/statviews_2094.htm [^]
[2] https://docs.oracle.com/cd/B28359_01/server.111/b28320/statviews_1036.htm#REFRN20040 [^]
Steps To ReproduceIn description
Proposed SolutionUse USER_TAB_COMMENTS and USER_COL_COMENTS tables.
Additional Information
TagsNo tags attached.
Relationships
duplicate of feature request 00346503.0PR17Q2 closed caristu Ability to generate indexes to speed up searching using 'contains' operators 
related to feature request 0030525 closed AugustoMauch Provide support in DBSourceManager to define an operator class in index columns 
related to feature request 0032211 closed caristu support for partial indexes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-28 12:12caristuNew Issue
2016-11-28 12:12caristuAssigned To => platform
2016-11-28 12:12caristuOBNetwork customer => No
2016-11-28 12:12caristuModules => Core
2016-11-28 12:12caristuTriggers an Emergency Pack => No
2016-11-28 12:12caristuRelationship addedrelated to 0030525
2016-11-28 12:13caristuRelationship addedrelated to 0032211
2016-11-28 12:13caristuAssigned Toplatform => caristu
2016-11-28 12:16caristuDescription Updatedbug_revision_view_page.php?rev_id=13905#r13905
2016-11-28 12:18caristuDescription Updatedbug_revision_view_page.php?rev_id=13906#r13906
2016-11-28 12:23caristuSummaryComments should be stored in user => Comments should be stored in user tables
2016-11-28 12:23caristuDescription Updatedbug_revision_view_page.php?rev_id=13907#r13907
2016-11-28 12:23caristuDescription Updatedbug_revision_view_page.php?rev_id=13908#r13908
2016-11-28 12:47hgbotCheckin
2016-11-28 12:47hgbotNote Added: 0091889
2016-11-28 12:53hgbotCheckin
2016-11-28 12:53hgbotNote Added: 0091890
2016-11-28 12:53hgbotStatusnew => resolved
2016-11-28 12:53hgbotResolutionopen => fixed
2016-11-28 12:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1197b964844552d650534948effb1515747f3f91 [^]
2016-11-28 12:53caristuReview Assigned To => alostale
2016-11-28 14:09alostaleSummaryComments should be stored in user tables => Comments should be queried from user tables
2016-11-28 14:09alostaleStatusresolved => closed
2016-11-28 14:09alostaleFixed in Version => 3.0PR17Q1
2016-11-28 17:31caristuRelationship addedduplicate of 0034650
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092667

Notes
(0091889)
hgbot   
2016-11-28 12:47   
Repository: erp/devel/dbsm-main
Changeset: 2c245cca180a01e69a21cfcb3e893c00516bc8af
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 28 12:46:07 2016 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/2c245cca180a01e69a21cfcb3e893c00516bc8af [^]

related to issue 34646: Oracle comments should be stored in user tables

---
M src-test/src/org/openbravo/dbsm/test/model/IndexBaseTest.java
M src-test/src/org/openbravo/dbsm/test/model/OperatorClassIndexes.java
M src/org/apache/ddlutils/platform/oracle/Oracle8Builder.java
M src/org/apache/ddlutils/platform/oracle/OracleModelLoader.java
---
(0091890)
hgbot   
2016-11-28 12:53   
Repository: erp/devel/pi
Changeset: 1197b964844552d650534948effb1515747f3f91
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 28 12:50:17 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1197b964844552d650534948effb1515747f3f91 [^]

fixes issue 34646: Oracle comments should be stored in user tables

---
M src-db/database/lib/dbsourcemanager.jar
---
(0092667)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test