0034642: performance problem with "create register book" process

Openbravo Issue Tracking System - Localization Pack: Spain

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034642

Localization Pack: Spain

AEAT 340

public

2016-11-28 09:32

2016-12-01 09:49

Reporter

malsasua

Assigned To

Sanjota

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Community Appliance

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

aferraz

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0034642: performance problem with "create register book" process

Description

in one environment with close to 3000 invoices, the "create register book" process is very slow (more than 40 minutes)

Steps To Reproduce

in environment with more than 3000 invoices, run "create register book" process

the process is slow because it is computing the next line of process:
https://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/file/c4f1320e3bb9/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java#l108 [^]

Proposed Solution

Replace the constructor on the ./org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/bean/PaymentInfoFor340.java

with

  public PaymentInfoFor340(final String year, final String invoiceId, final BigDecimal paidAmt) {
    try {
      OBContext.setAdminMode(true);
      Invoice inv = OBDal.getInstance().get(Invoice.class, invoiceId);
      setInvoice(inv);
      setYear(year);
    OBCriteria<ReversedInvoice> obCriteria = OBDal.getInstance().createCriteria(ReversedInvoice.class);
    obCriteria.add(Restrictions.eq(ReversedInvoice.PROPERTY_INVOICE, inv));
    obCriteria.setMaxResults(1);
    List<ReversedInvoice> rInvoice = obCriteria.list();
      for (final ReversedInvoice reversedInvoice : rInvoice) {
        final Date creditMemoDate = reversedInvoice.getReversedInvoice().getInvoiceDate();
        final Calendar cal = Calendar.getInstance();
        cal.setTime(creditMemoDate);
        setYear((new Integer(cal.get(Calendar.YEAR)).toString()));
        break;
      }
    } finally {
      OBContext.restorePreviousMode();
    }
    setPaidAmt(paidAmt);
  }

Additional Information