Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034608Retail ModulesWeb POSpublic2016-11-23 18:492018-07-24 17:41
Reportereduardo_Argal 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034608: Error after removing ticket (Save removed ticket preference)
DescriptionAn error is thrown after deleting a ticket. It seems system is tryng to book a deleted lined twice. problem in json (orderloader) as it sends wrong lines
Steps To ReproduceEnable Save Removed Ticket preference
1) create a ticket
2) Add a product and a related service
3) select both lines and delete
4) delete the ticket

The error is thrown (visible when synchronized preference is Y, if not error will be in queue)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0038387 closed Retail The error "[OB.Dal.save] Wrong model, it has no id" is printed in chrome console. 
Attached Files? issue34608.commit (786) 2016-11-28 18:57
https://issues.openbravo.com/file_download.php?file_id=10131&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-23 18:49eduardo_ArgalNew Issue
2016-11-23 18:49eduardo_ArgalAssigned To => marvintm
2016-11-25 10:43marvintmProjectJava Client POS => Retail Modules
2016-11-25 10:43marvintmTriggers an Emergency Pack => No
2016-11-25 10:43marvintmCategory01 - General => Web POS
2016-11-25 10:43marvintmAssigned Tomarvintm => Retail
2016-11-25 12:17marvintmAssigned ToRetail => migueldejuana
2016-11-28 12:59maiteResolution time => 1480374000
2016-11-28 18:22migueldejuanaFile Added: issue34608.commit
2016-11-28 18:57marvintmFile Deleted: issue34608.commit
2016-11-28 18:57marvintmFile Added: issue34608.commit
2016-11-29 09:06hgbotCheckin
2016-11-29 09:06hgbotNote Added: 0091906
2016-11-29 09:07hgbotStatusnew => resolved
2016-11-29 09:07hgbotResolutionopen => fixed
2016-11-29 09:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/638d908766299fb3eea6e175706ee04de9defd21 [^]
2016-11-29 09:07migueldejuanaSummaryError after removing ticket => Error after removing ticket (Save removed ticket preference)
2016-11-29 09:07migueldejuanaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13914#r13914
2016-11-30 08:47hgbotCheckin
2016-11-30 08:47hgbotNote Added: 0091912
2016-11-30 08:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/638d908766299fb3eea6e175706ee04de9defd21 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5f8aa6a836fa1f50857156094ca6d726ab160573 [^]
2016-12-05 09:23marvintmReview Assigned To => marvintm
2016-12-05 09:23marvintmStatusresolved => closed
2016-12-05 09:23marvintmFixed in Version => RR17Q1
2018-04-17 12:07samuel_nicuesaRelationship addedhas duplicate 0038387
2018-07-24 17:41hgbotCheckin
2018-07-24 17:41hgbotNote Added: 0105933

Notes
(0091906)
hgbot   
2016-11-29 09:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 638d908766299fb3eea6e175706ee04de9defd21
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Nov 28 16:43:34 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/638d908766299fb3eea6e175706ee04de9defd21 [^]

Fixed issue 0034608: Error after removing ticket

- When Save Removed Ticket preference is enabled we are introducing asynchrony in removing lines process. Due to de asynchrony, we try to remove the same service line, 2 times
- Add some general code in order to avoid executing deleteLine code 2 times for the same line

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091912)
hgbot   
2016-11-30 08:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5f8aa6a836fa1f50857156094ca6d726ab160573
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 29 09:09:53 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5f8aa6a836fa1f50857156094ca6d726ab160573 [^]

Fixed issue 0034608: Error after removing ticket

- Executer callback if needed

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105933)
hgbot   
2018-07-24 17:41   
Repository: tools/automation/pi-mobile
Changeset: 23c398cdd5d4574a4c7596795c2e88c85344db75
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Jul 20 15:48:58 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/23c398cdd5d4574a4c7596795c2e88c85344db75 [^]

Related to issue 34608: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34608_VerifyNoErrorAfterTicketDelete.java
---