Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034590ModulesWarehouse Pickingpublic2016-11-21 13:472017-01-05 09:49
Reporternataliag 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0034590: Cloned sales order cannot generate a picking list.
DescriptionIf a sales order is created from scratch (not cloned) and Generate picking list is clicked, picking list is created successfully. But, if the same sales order is cloned and booked and Generate picking list is clicked on the cloned sales order, an error is shown and the picking list is not generated.
Steps To Reproduce1- Login in backend and as system administrator go to “Module Managment” to add “Warehouse Picking List” module.
2- The module provides a dataset with basic document types that can be applied. Go to enterprise module management and apply the 'Warehouse Picking List' dataset.
3- Create a new sales order, book it and then click on “Generate picking List” button. The Picking list is created correctly.
4- Now clone the sales order created in step 3, booked it and generate the picking list. An error saying that the order is already in a picking list in draft status appear and the picking list is not created.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-21 13:47nataliagNew Issue
2016-11-21 13:47nataliagAssigned To => Triage Finance
2016-11-21 13:47nataliagModules => Core
2016-11-21 13:47nataliagResolution time => 1481497200
2016-11-21 13:47nataliagTriggers an Emergency Pack => No
2016-11-21 17:26aferrazAssigned ToTriage Finance => collazoandy4
2016-11-22 16:26collazoandy4Statusnew => scheduled
2016-11-22 17:39collazoandy4Note Added: 0091752
2016-12-12 12:55hgbotCheckin
2016-12-12 12:55hgbotNote Added: 0092282
2016-12-12 12:55hgbotStatusscheduled => resolved
2016-12-12 12:55hgbotResolutionopen => fixed
2016-12-12 12:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c0af68f8bb4a4ad4b703911cd6148085fff07927 [^]
2016-12-12 13:14hgbotCheckin
2016-12-12 13:14hgbotNote Added: 0092283
2016-12-12 13:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c0af68f8bb4a4ad4b703911cd6148085fff07927 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/40c5ef8a8bfe47545bf9ec1d93ad075a906ed83b [^]
2016-12-12 13:14hgbotCheckin
2016-12-12 13:14hgbotNote Added: 0092284
2016-12-12 13:16aferrazProjectOpenbravo ERP => Modules
2016-12-12 13:17aferrazCategory07. Sales management => Warehouse Picking
2016-12-12 13:17aferrazReview Assigned To => aferraz
2016-12-12 13:17aferrazNote Added: 0092285
2016-12-12 13:17aferrazStatusresolved => closed
2016-12-13 11:20hgbotCheckin
2016-12-13 11:20hgbotNote Added: 0092307
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092698
2017-01-05 09:49hgbotCheckin
2017-01-05 09:49hgbotNote Added: 0093212

Notes
(0091752)
collazoandy4   
2016-11-22 17:39   
Test Plan
 Go to Enterprise Module Management window
 Select (*) Organization
 In Reference data select Warehouse Picking List and clic on the OK button to set the dataset
 In Preference screen create a new record (if not exist) for the property Enable Stock Reservation with value Y and Visible at User Openbravo
 Log out and Log in
 Go to Sales Order window
 Create a new record
 Fill out all the required fields
 In Lines tab create a new record with a stocked product and a Ordered Quantity
 Clic on the Book button and OK button from the popup
 Clic on Generate Picking List button and OK button from the popup
 Clic on Copy record from the top toolbar and Yes button from the dialog
 Clic on the Book button and OK button from the popup
 Clic on Generate Picking List button and OK button from the popup
(0092282)
hgbot   
2016-12-12 12:55   
Repository: erp/devel/pi
Changeset: c0af68f8bb4a4ad4b703911cd6148085fff07927
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Dec 02 15:26:51 2016 -0800
URL: http://code.openbravo.com/erp/devel/pi/rev/c0af68f8bb4a4ad4b703911cd6148085fff07927 [^]

Fixes issue 34590: Generate Picking List from cloned Sales Order

Generating a Picking List to a cloned Sales Order was failing because the order Picking List state is not reset. A new hook for the Clone Order process was created to reset the Picking List State

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
A src/org/openbravo/erpCommon/businessUtility/CloneOrderHook.java
A src/org/openbravo/erpCommon/businessUtility/CloneOrderHookCaller.java
---
(0092283)
hgbot   
2016-12-12 13:14   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 40c5ef8a8bfe47545bf9ec1d93ad075a906ed83b
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Dec 02 15:29:28 2016 -0800
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/40c5ef8a8bfe47545bf9ec1d93ad075a906ed83b [^]

Fixes issue 34590: Generate Picking List from cloned Sales Order

Generating a Picking List to a cloned Sales Order was failing because the order Picking List state is not reset. Creating an implementation for the Clone Order Hook to reset the Picking List State

---
A src/org/openbravo/warehouse/pickinglist/hooks/ClonePLOrderHook.java
---
(0092284)
hgbot   
2016-12-12 13:14   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: c52d5ced721b1add5bc58489907b6725ae449023
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Dec 12 13:10:27 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/c52d5ced721b1add5bc58489907b6725ae449023 [^]

Related to issue 34590: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/warehouse/pickinglist/hooks/ClonePLOrderHook.java
---
(0092285)
aferraz   
2016-12-12 13:17   
Code review + Testing OK
(0092307)
hgbot   
2016-12-13 11:20   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 3f8def1dd53f3b11d7b8fce63a9f8799ea1fa93c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Dec 13 11:18:48 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/3f8def1dd53f3b11d7b8fce63a9f8799ea1fa93c [^]

Related to issue 34590: Revert module dependency to Core until 17Q1 publication

---
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0092698)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0093212)
hgbot   
2017-01-05 09:49   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: b6c5a5f8fe1e9dd7c5af341c865e0e5c9640c929
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jan 05 09:48:40 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/b6c5a5f8fe1e9dd7c5af341c865e0e5c9640c929 [^]

Related to issue 34590: Update module dependency to Core now 17Q1 is publicated

---
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---