Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034587Retail ModulesStoreServerpublic2016-08-09 17:172016-12-07 14:50
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3.4Fixed in VersionRR16Q3.4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034587: Ping service fail method not called in case of multiple servers
DescriptionIn case of multiple servers (central and store) and the store server down the webpos automatically starts pinging the store server.

The ping service does not call the original fail method of the request if there are more than 1 servers ([1]). This results in the synchronizationHelper queue in WebPOS to fill ([2]) up as the request is not correctly finished.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/052f0d3e3b18/web/org.openbravo.mobile.core/source/data/ob-requestrouter.js#l513 [^]

[2]
OB.UTIL.SynchronizationHelper.getBusyQueueStringified()
"[{"busyProcessId":113,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":114,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":133,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":151,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":203,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":207,"msg":"calculateGross"},{"busyProcessId":208,"msg":"taxescalculation"}]"
Steps To ReproduceInstall multi-server, central and store
Login into store with webpos
do a product search
add a product, pay button is enabled
stop the store server
do a product search --> the webpos switches to central and starts pinging the store server
after the first ping the pay button becomes disable
Proposed SolutionAlso call the success/fail method in case of multiple servers
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033663RR16Q4 closed mtaal Ping service fail method not called in case of multiple servers 
Attached Filesdiff 34587.diff (2,195) 2016-11-21 10:10
https://issues.openbravo.com/file_download.php?file_id=10078&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-20 13:42mtaalTypedefect => backport
2016-11-20 13:42mtaalTarget VersionRR16Q4 => RR16Q3.3
2016-11-20 16:11hgbotCheckin
2016-11-20 16:11hgbotNote Added: 0091676
2016-11-20 16:11hgbotStatusscheduled => resolved
2016-11-20 16:11hgbotResolutionopen => fixed
2016-11-20 16:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/15fb8809f9708c2464875dc39e8ad4935f81ad5e [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.mobile.core/rev/ca4c3492070301e680b1a0d8cb9408f10d2d7963 [^]
2016-11-21 10:04hgbotCheckin
2016-11-21 10:04hgbotNote Added: 0091685
2016-11-21 10:04mtaalNote Added: 0091686
2016-11-21 10:04mtaalStatusresolved => new
2016-11-21 10:04mtaalResolutionfixed => open
2016-11-21 10:05mtaalTarget VersionRR16Q3.3 => RR16Q3.4
2016-11-21 10:10mtaalFile Added: 34587.diff
2016-11-21 10:33mtaalStatusnew => scheduled
2016-12-07 10:33hgbotCheckin
2016-12-07 10:33hgbotNote Added: 0092163
2016-12-07 10:33hgbotStatusscheduled => resolved
2016-12-07 10:33hgbotResolutionopen => fixed
2016-12-07 10:33hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.mobile.core/rev/ca4c3492070301e680b1a0d8cb9408f10d2d7963 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.mobile.core/rev/fd558088b87000947cf2b771e63a3a0491ce2d32 [^]
2016-12-07 14:50marvintmReview Assigned Tomigueldejuana => marvintm
2016-12-07 14:50marvintmStatusresolved => closed
2016-12-07 14:50marvintmFixed in Version => RR16Q3.4

Notes
(0091676)
hgbot   
2016-11-20 16:11   
Repository: retail/backports/3.0RR16Q3.3/org.openbravo.mobile.core
Changeset: ca4c3492070301e680b1a0d8cb9408f10d2d7963
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 20 16:11:33 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.mobile.core/rev/ca4c3492070301e680b1a0d8cb9408f10d2d7963 [^]

Fixes issue 34587: Ping service fail method not called in case of multiple servers
Also call success in case of multi-server ping failure, as ping failure is sometimes
expected and then updates server status

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0091685)
hgbot   
2016-11-21 10:04   
Repository: retail/backports/3.0RR16Q3.3/org.openbravo.mobile.core
Changeset: 033e0c43a59881de35fe86da4837a48663bff41d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Nov 21 10:04:07 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.mobile.core/rev/033e0c43a59881de35fe86da4837a48663bff41d [^]

Related to issue 34587: Ping service fail method not called in case of multiple servers
Backout of changeset, will be moved to 3.4

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0091686)
mtaal   
2016-11-21 10:04   
Resolve in 3.4 and not in 3.3
(0092163)
hgbot   
2016-12-07 10:33   
Repository: retail/backports/3.0RR16Q3.4/org.openbravo.mobile.core
Changeset: fd558088b87000947cf2b771e63a3a0491ce2d32
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 07 10:33:37 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.mobile.core/rev/fd558088b87000947cf2b771e63a3a0491ce2d32 [^]

Fixes issue 34587: Ping service fail method not called in case of multiple servers
Also call success in case of multi-server ping failure, as ping failure is sometimes
expected and then updates server status

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---