Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034551Openbravo ERPZ. Otherspublic2016-11-17 10:282016-12-16 18:38
maite 
alekosmp86 
urgentmajoralways
closedfixed 
5
 
3.0PR17Q1 
aferraz
Advanced Payables and Receivables Mngmt
No
0034551: Transaction Date and Ending Date not truncated when reconciliation is created using "Reconcile" process
Reconciliations created using manual reconciliation process (Reconcile button) have not truncated dates
1. Access Financial Account "Caja"
2. Create new transaction setting any gl item and amount. Process transaction
3. Run Reconcile process, select previous transaction, set proper ending balance and process
4. Via database, verify that Transaction Date and Ending Date are not truncated (which is affecting reconciliation's report)
No tags attached.
Issue History
2016-11-17 10:28maiteNew Issue
2016-11-17 10:28maiteAssigned To => Triage Finance
2016-11-17 10:28maiteModules => Advanced Payables and Receivables Mngmt
2016-11-17 10:28maiteResolution time => 1480806000
2016-11-17 10:28maiteTriggers an Emergency Pack => No
2016-11-18 09:38aferrazAssigned ToTriage Finance => collazoandy4
2016-11-21 17:01alekosmp86Assigned Tocollazoandy4 => alekosmp86
2016-11-21 22:09alekosmp86Note Added: 0091724
2016-11-24 18:53hgbotCheckin
2016-11-24 18:53hgbotNote Added: 0091800
2016-11-24 18:53hgbotStatusnew => resolved
2016-11-24 18:53hgbotResolutionopen => fixed
2016-11-24 18:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c876c12bb7913ce7da34862b7eeae382d41b206f [^]
2016-11-24 18:53aferrazReview Assigned To => aferraz
2016-11-24 18:53aferrazNote Added: 0091801
2016-11-24 18:53aferrazStatusresolved => closed
2016-11-24 18:53aferrazFixed in Version => 3.0PR17Q1
2016-11-25 17:05alekosmp86Note Added: 0091856
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092657

Notes
(0091724)
alekosmp86   
2016-11-21 22:09   
Test Plan

Log in the backend using F&B International Group Admin
Go to Financial Account screen
   Select the record with name "Caja"
   Go to Transaction tab
      Create a new document
         Transaction Type: BP Deposit
         G/L Item: Capital Social
         Deposit Amount: 100
      Save the document
   Process the transaction
   Run the Reconcile process
      Select the previously created transaction
      Adjust the ending balance with the proper value
      Click on Reconcile button
Via database, go to FIN_Reconciliation table and notice that fields "dateto" and "statementdate" now have their dates truncated
(0091800)
hgbot   
2016-11-24 18:53   
Repository: erp/devel/pi
Changeset: c876c12bb7913ce7da34862b7eeae382d41b206f
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Nov 21 14:04:51 2016 -0600
URL: http://code.openbravo.com/erp/devel/pi/rev/c876c12bb7913ce7da34862b7eeae382d41b206f [^]

Fixes issue 34551: Dates not truncated when using "Reconcile" process

Reconciliations created using manual reconciliation process (Reconcile button)
were not inserted with truncated dates. When setting the properties for the
reconciliation record being saved, the TransactionDate and EndingDate properties
were being filled with the current date and time. Now those fields are filled only
with the date.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
---
(0091801)
aferraz   
2016-11-24 18:53   
Code review + Testing OK
(0091856)
alekosmp86   
2016-11-25 17:05   
Run this query in order to fix the wrong data created by this issue:

alter table fin_reconciliation disable trigger all;

update fin_reconciliation set dateto=trunc(dateto), statementdate=trunc(statementdate);

alter table fin_reconciliation enable trigger all;
(0092657)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test