Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034549Retail ModulesWeb POSpublic2016-11-17 09:312017-01-09 14:02
Reporterguillermogil 
Assigned Toguillermogil 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034549: Create an structure to disable payment method buttons set as not refundables
DescriptionCreate an structure to disable payment method buttons set as not refundables if the total amount to pay is negative.
Steps To ReproduceN/A
Proposed SolutionSee patch attached
Additional Information
TagsNo tags attached.
Relationships
causes defect 0037776 closed ranjith_qualiantech_com In a terminal without refundable payment methods, it should still be possible to pay a return on credit 
Attached Filespatch PaymentMethodsNotRefundable_Test_9Nov.patch (4,605) 2016-11-17 09:32
https://issues.openbravo.com/file_download.php?file_id=10056&type=bug
patch PaymentMethodsNotRefundable_POSTERMINAL_1Dec.patch (25,029) 2016-12-01 14:32
https://issues.openbravo.com/file_download.php?file_id=10141&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-17 09:31guillermogilNew Issue
2016-11-17 09:31guillermogilAssigned To => guillermogil
2016-11-17 09:31guillermogilTriggers an Emergency Pack => No
2016-11-17 09:32guillermogilFile Added: PaymentMethodsNotRefundable_Test_9Nov.patch
2016-11-17 09:32guillermogilFile Added: PaymentMethodsNotRefundable_POSTERMINAL_10Nov.patch
2016-12-01 14:31guillermogilFile Deleted: PaymentMethodsNotRefundable_POSTERMINAL_10Nov.patch
2016-12-01 14:32guillermogilFile Added: PaymentMethodsNotRefundable_POSTERMINAL_1Dec.patch
2017-01-04 16:36hgbotCheckin
2017-01-04 16:36hgbotNote Added: 0093192
2017-01-04 16:37hgbotCheckin
2017-01-04 16:37hgbotNote Added: 0093193
2017-01-04 16:37hgbotStatusnew => resolved
2017-01-04 16:37hgbotResolutionopen => fixed
2017-01-04 16:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44c7e3f98c74a85be438d945dd0588217eecdd61 [^]
2017-01-04 16:37guillermogilReview Assigned To => marvintm
2017-01-05 16:50hgbotCheckin
2017-01-05 16:50hgbotNote Added: 0093235
2017-01-09 14:02marvintmStatusresolved => closed
2017-01-09 14:02marvintmFixed in Version => RR17Q2
2018-01-30 18:03marvintmRelationship addedcauses 0037776

Notes
(0093192)
hgbot   
2017-01-04 16:36   
Repository: tools/automation/pi-mobile
Changeset: ae381581c98e63305b179bbffbac23655026e25a
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Jan 04 16:32:49 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ae381581c98e63305b179bbffbac23655026e25a [^]

Related to issue 34549: Added test cases for not refundable payments

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifyNoRefundPayment.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifyNoRefundPaymentDefaultPayment.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifyNoRefundablePayments_popup.java
---
(0093193)
hgbot   
2017-01-04 16:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 44c7e3f98c74a85be438d945dd0588217eecdd61
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Jan 04 16:36:20 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44c7e3f98c74a85be438d945dd0588217eecdd61 [^]

Fixed issue 34549: Create an structure to set payment method as not refundables

Merged with refundable payment branch
Now if a payment method is configured as not returnable its button on WebPOS will be disabled if the total amount to pay is negative

---
M src-db/database/model/tables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0093235)
hgbot   
2017-01-05 16:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d0f8b6ba755e2f3531581021a64fa3360ef7dda9
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Thu Jan 05 16:47:05 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0f8b6ba755e2f3531581021a64fa3360ef7dda9 [^]

Related to issue 34549: Fixed an issue with display logic
Fixed an issue with the display logic of the payment providers when the payment method is returnable

---
M src-db/database/sourcedata/AD_FIELD.xml
---