Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034524Retail ModulesStoreServerpublic2016-11-15 10:422016-12-14 17:47
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q1Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034524: Check that synchronized table is also present in the store server dataset
DescriptionFor tables in synchronized table setup which are synchronized from central to store it almost always makes sense to have them also present in the store server dataset for initial dataset creation.

Therefore add a validation/check in the synchronized table validation [1] to check that a table which is synchronized from central to store (or bidirectional) is also included in the store server dataset. This is more a warning than an error.

[1]
http://wiki.openbravo.com/wiki/How_to_Add_a_Table_or_Column_to_a_Store_Server_Solution#Validate_Synced_Tables [^]
Steps To ReproduceSee description
Proposed SolutionSee description
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-15 10:42mtaalNew Issue
2016-11-15 10:42mtaalAssigned To => mtaal
2016-11-15 10:42mtaalOBNetwork customer => No
2016-11-15 10:42mtaalTriggers an Emergency Pack => No
2016-12-04 23:19mtaalReview Assigned To => AugustoMauch
2016-12-04 23:19mtaalNote Added: 0092078
2016-12-04 23:21hgbotCheckin
2016-12-04 23:21hgbotNote Added: 0092079
2016-12-04 23:23hgbotCheckin
2016-12-04 23:23hgbotNote Added: 0092080
2016-12-04 23:23hgbotStatusnew => resolved
2016-12-04 23:23hgbotResolutionopen => fixed
2016-12-04 23:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/a43161ba3b63827a4e25a2c2a0fe8d7eab75c77d [^]
2016-12-07 10:56AugustoMauchNote Added: 0092167
2016-12-07 10:56AugustoMauchStatusresolved => new
2016-12-07 10:56AugustoMauchResolutionfixed => open
2016-12-07 10:58AugustoMauchNote Added: 0092168
2016-12-08 16:43hgbotCheckin
2016-12-08 16:43hgbotNote Added: 0092220
2016-12-08 16:44hgbotCheckin
2016-12-08 16:44hgbotNote Added: 0092221
2016-12-08 16:44hgbotStatusnew => resolved
2016-12-08 16:44hgbotResolutionopen => fixed
2016-12-08 16:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/a43161ba3b63827a4e25a2c2a0fe8d7eab75c77d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/f45889e143eb515dd9e3d433d43a862d862dcd11 [^]
2016-12-14 17:47AugustoMauchNote Added: 0092374
2016-12-14 17:47AugustoMauchStatusresolved => closed

Notes
(0092078)
mtaal   
2016-12-04 23:19   
Updated documentation:

http://wiki.openbravo.com/wiki/How_to_Add_a_Table_or_Column_to_a_Store_Server_Solution#Validate_Synced_Tables [^]
(0092079)
hgbot   
2016-12-04 23:21   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 6b5d0204ca0198784ef8ab9c1968d3922d37f441
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Dec 04 23:21:12 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/6b5d0204ca0198784ef8ab9c1968d3922d37f441 [^]

Related to issue 34524: Check that synchronized table is also present in the store server dataset
In the validation task also log the differences between the dataset and the synchronized tables.
Update build.xml to use the data set id, this seems more robust than using the dataset name.

---
M build.xml
M src/org/openbravo/retail/storeserver/synchronization/process/SyncTablesValidationHandler.java
---
(0092080)
hgbot   
2016-12-04 23:23   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: a43161ba3b63827a4e25a2c2a0fe8d7eab75c77d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Dec 04 23:23:08 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/a43161ba3b63827a4e25a2c2a0fe8d7eab75c77d [^]

Fixes issue 34524: Check that synchronized table is also present in the store server dataset
Add check of synchronized table-store-server creation dataset differences to the synchronized
table validation, other formatting changes to the printed error messages/popup window.

---
M src/org/openbravo/replication/symmetricds/SynchronizationTableValidation.java
M src/org/openbravo/replication/symmetricds/task/SynchronizationDataSetValidationTask.java
---
(0092167)
AugustoMauch   
2016-12-07 10:56   
validate.storeserver.syncsetup task seems not to be working properly, it shows the same result twice:

openbravo@por0942:~/workspaces/src/pi-cs-big-db/modules/org.openbravo.retail.storeserver.synchronization$ ant validate.storeserver.syncsetup
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Buildfile: /home/openbravo/workspaces/src/pi-cs-big-db/modules/org.openbravo.retail.storeserver.synchronization/build.xml

validate.storeserver.syncsetup:
     [echo] Validating Synchronized Tables
[SynchronizationTableValidationTask] 0 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Initializing in-memory model...
[SynchronizationTableValidationTask] 139 [main] INFO org.openbravo.base.model.ModelProvider - Building runtime model
[SynchronizationTableValidationTask] 3375 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Model read in-memory, generating mapping...
[SynchronizationTableValidationTask] 13809 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Dal layer initialized
[SynchronizationTableValidationTask] 13991 [main] INFO org.openbravo.replication.symmetricds.SynchronizationTableValidation -
[SynchronizationTableValidationTask] ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationTableValidationTask] CHECK INVALID PROPERTIES RESULT:
[SynchronizationTableValidationTask] Check passed, all properties are correctly referencing included entities
[SynchronizationTableValidationTask] +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationTableValidationTask]
[SynchronizationTableValidationTask] 14057 [main] INFO org.openbravo.replication.symmetricds.SynchronizationTableValidation -
[SynchronizationTableValidationTask] +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationTableValidationTask] Synchronized entities NOT defined in the store creation dataset:
[SynchronizationTableValidationTask] - OBSTSYN_Error
[SynchronizationTableValidationTask] <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[SynchronizationTableValidationTask]
[SynchronizationTableValidationTask] +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationTableValidationTask] Store server creation entities NOT defined as a synchronized table:
[SynchronizationTableValidationTask] - MaterialMgmtStorageDetail
[SynchronizationTableValidationTask] - CostingAlgorithm
[SynchronizationTableValidationTask] <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[SynchronizationTableValidationTask]
     [echo] Validating Store Server Data Set
[SynchronizationDataSetValidationTask] 0 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Initializing in-memory model...
[SynchronizationDataSetValidationTask] 110 [main] INFO org.openbravo.base.model.ModelProvider - Building runtime model
[SynchronizationDataSetValidationTask] 2915 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Model read in-memory, generating mapping...
[SynchronizationDataSetValidationTask] 13052 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Dal layer initialized
[SynchronizationDataSetValidationTask] 13221 [main] INFO org.openbravo.replication.symmetricds.SynchronizationTableValidation -
[SynchronizationDataSetValidationTask] ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationDataSetValidationTask] CHECK INVALID PROPERTIES RESULT:
[SynchronizationDataSetValidationTask] Check passed, all properties are correctly referencing included entities
[SynchronizationDataSetValidationTask] +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationDataSetValidationTask]
[SynchronizationDataSetValidationTask] 13280 [main] INFO org.openbravo.replication.symmetricds.SynchronizationTableValidation -
[SynchronizationDataSetValidationTask] +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationDataSetValidationTask] Synchronized entities NOT defined in the store creation dataset:
[SynchronizationDataSetValidationTask] - OBSTSYN_Error
[SynchronizationDataSetValidationTask] <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[SynchronizationDataSetValidationTask]
[SynchronizationDataSetValidationTask] +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[SynchronizationDataSetValidationTask] Store server creation entities NOT defined as a synchronized table:
[SynchronizationDataSetValidationTask] - MaterialMgmtStorageDetail
[SynchronizationDataSetValidationTask] - CostingAlgorithm
[SynchronizationDataSetValidationTask] <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[SynchronizationDataSetValidationTask]
(0092168)
AugustoMauch   
2016-12-07 10:58   
Also, there this code is duplicated: [1] and [2]

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/6b5d0204ca01/build.xml#l43 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/6b5d0204ca01/build.xml#l57 [^]

Probably the validate.storeserver.syncsetup task can just call the validate.storeserver.dataset target
(0092220)
hgbot   
2016-12-08 16:43   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 883795735eafb9e427f3172a249ce0dcf95c6323
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Dec 08 16:43:34 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/883795735eafb9e427f3172a249ce0dcf95c6323 [^]

Related to issue 34524: Check that synchronized table is also present in the store server dataset
remove duplicate ant code

---
M build.xml
---
(0092221)
hgbot   
2016-12-08 16:44   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: f45889e143eb515dd9e3d433d43a862d862dcd11
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Dec 08 16:44:22 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/f45889e143eb515dd9e3d433d43a862d862dcd11 [^]

Fixes issue 34524: Check that synchronized table is also present in the store server dataset
Only log differences in dataset and synchronized tables in the synchronized table validation

---
M src/org/openbravo/replication/symmetricds/SynchronizationTableValidation.java
M src/org/openbravo/replication/symmetricds/task/SynchronizationTableValidationTask.java
---
(0092374)
AugustoMauch   
2016-12-14 17:47   
Code reviewed and verified in [1]@f45889e143eb

[1] http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds [^]