Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034521Retail ModulesWeb POSpublic2016-11-15 10:162016-12-07 15:24
Reporterjorge-garcia 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3.4Fixed in VersionRR16Q3.4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-09-12
Regression introduced in releaseRR15Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1ba7e9aa75f69ac696431167c9fbb26cb0e55dbf [^]
Triggers an Emergency PackNo
Summary0034521: [Performance] Discounts calculation is slower when the user increase the number of lines of the receipt
DescriptionDiscounts calculation is more slower when the user increase the number of lines of the receipt
Steps To Reproduce1) Login in the WebPOS
2) Start adding products in the ticket
3) Check the calculation of the receipt became more slower
4) Notice, after the tenth line in the receipt, the calculation takes several seconds.
5) From the twentieth line, the calculation could take twenty or thirty seconds.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034517 closed jorge-garcia [Performance] Discounts calculation is slower when the user increase the number of lines of the receipt 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-15 10:26jorge-garciaTypedefect => backport
2016-11-15 10:26jorge-garciaTarget Version => RR16Q3.4
2016-12-07 13:17hgbotCheckin
2016-12-07 13:17hgbotNote Added: 0092183
2016-12-07 13:17hgbotStatusscheduled => resolved
2016-12-07 13:17hgbotResolutionopen => fixed
2016-12-07 13:17hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/59b7576ec6f692a4723379c05e9fac65fa826bd3 [^]
2016-12-07 13:17hgbotCheckin
2016-12-07 13:17hgbotNote Added: 0092184
2016-12-07 13:17hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/59b7576ec6f692a4723379c05e9fac65fa826bd3 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/2adbf3b2582b4998d7f8eda5fea0bcd274a1b23a [^]
2016-12-07 14:26marvintmAssigned Tojorge-garcia => marvintm
2016-12-07 15:24guilleaerReview Assigned To => guilleaer
2016-12-07 15:24guilleaerStatusresolved => closed
2016-12-07 15:24guilleaerFixed in Version => RR16Q3.4

Notes
(0092183)
hgbot   
2016-12-07 13:17   
Repository: retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal
Changeset: 59b7576ec6f692a4723379c05e9fac65fa826bd3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Dec 07 13:10:07 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/59b7576ec6f692a4723379c05e9fac65fa826bd3 [^]

Fixed issue 34521. [Performance] Discounts calculation is slower when the
user increase the number of lines of the receipt

The problem with this issue is that the functionality of findUsingCache was
never use, because the parameter to stablish the initial date to take a
promotion was always changing with the value of the actual date witch was
a datetime value.

In the backend, it’s not possible to define a promotion neither the starting
date nor ending date fields with a date including hours, minutes and seconds.

The solution is to parse the date to sue only dates without time for the query
criteria.

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0092184)
hgbot   
2016-12-07 13:17   
Repository: retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal
Changeset: 2adbf3b2582b4998d7f8eda5fea0bcd274a1b23a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Dec 07 13:16:43 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/2adbf3b2582b4998d7f8eda5fea0bcd274a1b23a [^]

Fixed issue 34521. Fix the actual problem if we add several lines at once, like in the case of
RFID.
Only launch the calculation of the receipt when the last line to delete is
changed.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---