Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034512Openbravo ERP09. Financial managementpublic2016-11-15 09:132017-05-29 17:43
Reportercaristu 
Assigned ToAtulOpenbravo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034512: [clustering] Close year process is locked just at JVM level
DescriptionThe processYearClose method of the EndYearCloseUtility is a synchronized method. This means that the process has been designed to prevent its execution by different threads in parallel.

In a clustered environment the previous assumption is not guaranteed, as the synchronized method is preventing concurrent executions within the same JVM.

Therefore it could be possible to execute this process in parallel by different threads which belong to different nodes of a clustered environment.
Steps To ReproduceIn description
Proposed Solution
Additional Information
Tagsclustering
Relationships
has duplicate defect 0034507 closed collazoandy4 Unneeded lock in processButtonReg and processButtonClose methods of EndYearCloseUtility 
blocks design defect 0034490 acknowledged Triage Platform Base [clustering] Support clustering 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-15 09:13caristuNew Issue
2016-11-15 09:13caristuAssigned To => Triage Finance
2016-11-15 09:13caristuOBNetwork customer => No
2016-11-15 09:13caristuModules => Core
2016-11-15 09:13caristuTriggers an Emergency Pack => No
2016-11-15 09:13caristuRelationship addedrelated to 0034490
2016-11-15 09:14caristuRelationship deletedrelated to 0034490
2016-11-15 09:14caristuRelationship addedblocks 0034490
2016-11-15 10:17caristuDescription Updatedbug_revision_view_page.php?rev_id=13716#r13716
2016-11-15 11:12caristuTag Attached: clustering
2017-03-23 15:02markmm82Assigned ToTriage Finance => AtulOpenbravo
2017-05-12 07:46AtulOpenbravoStatusnew => scheduled
2017-05-24 10:11hgbotCheckin
2017-05-24 10:11hgbotNote Added: 0096744
2017-05-24 10:11hgbotStatusscheduled => resolved
2017-05-24 10:11hgbotResolutionopen => fixed
2017-05-24 10:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6bf3013c651bc50a81cf929eaff043acc587d49d [^]
2017-05-24 10:13aferrazReview Assigned To => aferraz
2017-05-24 10:13aferrazNote Added: 0096746
2017-05-24 10:13aferrazStatusresolved => closed
2017-05-24 10:13aferrazFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096981
2017-12-27 09:44vmromanosRelationship addedhas duplicate 0034507

Notes
(0096744)
hgbot   
2017-05-24 10:11   
Repository: erp/devel/pi
Changeset: 6bf3013c651bc50a81cf929eaff043acc587d49d
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 23 22:35:39 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6bf3013c651bc50a81cf929eaff043acc587d49d [^]

Fixes issue 34512: Close year process is locked just at JVM level

Removed synchronized keyword in processYearClose, processButtonReg and
processButtonClose methods to allow execution of process in parallel by
different threads in same JVM.

---
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility.java
---
(0096746)
aferraz   
2017-05-24 10:13   
Code review OK
(0096981)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test