Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034511Openbravo ERP09. Financial managementpublic2016-11-15 09:082017-05-29 17:43
Reportercaristu 
Assigned ToAtulOpenbravo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034511: [clustering] CostAdjustmentProcess is locked just at JVM level
DescriptionThe doProcessCostAdjustment method of the CostAdjustmentProcess is a synchronized method. This means that the process has been designed to prevent its execution by different threads in parallel.

In a clustered environment the previous assumption is not guaranteed, as the synchronized method is preventing concurrent executions within the same JVM.

Therefore it could be possible to execute this process in parallel by different threads which belong to different nodes of a clustered environment.
Steps To ReproduceIn description
Proposed Solution
Additional Information
Tagsclustering
Relationships
blocks design defect 0034490 acknowledged Triage Platform Base [clustering] Support clustering 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-15 09:08caristuNew Issue
2016-11-15 09:08caristuAssigned To => platform
2016-11-15 09:08caristuOBNetwork customer => No
2016-11-15 09:08caristuModules => Core
2016-11-15 09:08caristuTriggers an Emergency Pack => No
2016-11-15 09:08caristuRelationship addedblocks 0034490
2016-11-15 09:11caristuCategoryA. Platform => 09. Financial management
2016-11-15 09:11caristuAssigned Toplatform => Triage Finance
2016-11-15 10:17caristuDescription Updatedbug_revision_view_page.php?rev_id=13714#r13714
2016-11-15 11:12caristuTag Attached: clustering
2017-03-23 15:01markmm82Assigned ToTriage Finance => AtulOpenbravo
2017-03-31 13:45AtulOpenbravoStatusnew => scheduled
2017-05-23 19:06hgbotCheckin
2017-05-23 19:06hgbotNote Added: 0096734
2017-05-23 19:06hgbotStatusscheduled => resolved
2017-05-23 19:06hgbotResolutionopen => fixed
2017-05-23 19:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bad50b303382e28ea916885dca5e0e060391820f [^]
2017-05-23 19:06aferrazReview Assigned To => aferraz
2017-05-23 19:06aferrazNote Added: 0096735
2017-05-23 19:06aferrazStatusresolved => closed
2017-05-23 19:06aferrazFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096980

Notes
(0096734)
hgbot   
2017-05-23 19:06   
Repository: erp/devel/pi
Changeset: bad50b303382e28ea916885dca5e0e060391820f
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 23 12:28:01 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bad50b303382e28ea916885dca5e0e060391820f [^]

Fixes issue 34511: CostAdjustmentProcess is locked just at JVM level

Removed synchronized keyword for doProcessCostAdjustment method in order
to allow concurrent execution of the process within the same JVM. It is
observed that every time this method is called to process newly created
cost adjustment object that is different.

---
M src/org/openbravo/costing/CostAdjustmentProcess.java
---
(0096735)
aferraz   
2017-05-23 19:06   
Code review OK
(0096980)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test