Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0034497 | Openbravo ERP | 09. Financial management | public | 2016-11-14 16:18 | 2018-02-22 18:18 |
|
| Reporter | caristu | |
| Assigned To | collazoandy4 | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR18Q2 | |
| Merge Request Status | |
| Review Assigned To | dmiguelez |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0034497: CostingTransactionsHQLTransformer class is not thread safe |
| Description | The application scoped class CostingTransactionsHQLTransformer[1] (it extends application scoped HqlQueryTransformer class) is stateful no thread safe. This means that it does not guarantee its correct execution (even working in a single node) when being executed by different threads in parallel.
[1] https://code.openbravo.com/erp/devel/pi/file/3b0fb57e7fed/src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java [^]
|
| Steps To Reproduce | In description |
| Proposed Solution | |
| Additional Information | |
| Tags | multiThread |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-11-14 16:18 | caristu | New Issue | |
| 2016-11-14 16:18 | caristu | Assigned To | => Triage Finance |
| 2016-11-14 16:18 | caristu | Modules | => Core |
| 2016-11-14 16:18 | caristu | Triggers an Emergency Pack | => No |
| 2016-11-14 16:19 | caristu | Relationship added | related to 0034490 |
| 2016-11-14 16:19 | caristu | Description Updated | bug_revision_view_page.php?rev_id=13694#r13694 |
| 2016-11-15 11:15 | caristu | Summary | [clustering] CostingTransactionsHQLTransformer class is not thread safe => CostingTransactionsHQLTransformer class is not thread safe |
| 2016-11-16 16:39 | alostale | Tag Attached: multiThread | |
| 2016-11-16 16:40 | alostale | Relationship deleted | related to 0034490 |
| 2016-12-01 11:57 | alostale | Severity | minor => major |
| 2016-12-01 11:57 | alostale | Relationship added | blocks 0034664 |
| 2017-12-26 11:28 | vmromanos | Status | new => scheduled |
| 2017-12-26 11:28 | vmromanos | Assigned To | Triage Finance => collazoandy4 |
| 2018-01-08 09:36 | hgbot | Checkin | |
| 2018-01-08 09:36 | hgbot | Note Added: 0101609 | |
| 2018-01-08 09:36 | hgbot | Status | scheduled => resolved |
| 2018-01-08 09:36 | hgbot | Resolution | open => fixed |
| 2018-01-08 09:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/5b6a22a83186f0a6073b2b815011c8cff285ead0 [^] |
| 2018-01-08 09:36 | hgbot | Checkin | |
| 2018-01-08 09:36 | hgbot | Note Added: 0101610 | |
| 2018-01-08 09:40 | dmiguelez | Review Assigned To | => dmiguelez |
| 2018-01-08 09:40 | dmiguelez | Note Added: 0101612 | |
| 2018-01-08 09:40 | dmiguelez | Status | resolved => closed |
| 2018-01-08 09:40 | dmiguelez | Fixed in Version | => 3.0PR18Q2 |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102646 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102647 | |
|
Notes |
|
|
(0101609)
|
|
hgbot
|
|
2018-01-08 09:36
|
|
Repository: erp/devel/pi
Changeset: 5b6a22a83186f0a6073b2b815011c8cff285ead0
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jan 04 13:35:03 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5b6a22a83186f0a6073b2b815011c8cff285ead0 [^]
Fixes issue 34497: CostingTransactionsHQLTransformer class is not thread safe
The orgs and costDimensions fields is now local variable for the transformHqlQuery
method to avoid concurrent modification access when being executed by different
threads in parallel
A refactor was made including the previous fields as method args when it needed
---
M src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
---
|
|
|
|
(0101610)
|
|
hgbot
|
|
2018-01-08 09:36
|
|
Repository: erp/devel/pi
Changeset: cd520d72489f4fb97bed0ba09800404432d76149
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jan 04 13:36:24 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cd520d72489f4fb97bed0ba09800404432d76149 [^]
Relate to Issue 34497: Several minor improvements to the code:
* Updated license year
* Changed StringBuffers with StringBuilders
* Set the names of the constants to uppercase
* Removed unnecessary comparison in if clause
* Use .isEmpty() instead of .size() > 0
---
M src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|