Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034487Openbravo ERPA. Platformpublic2016-11-14 12:172018-02-15 17:15
caristu 
jarmendariz 
lowtrivialN/A
scheduledopen 
5
 
 
Core
No
0034487: Remove unused action handlers
There existis some action handlers that can be removed as they were created for testing puroposes and/or are not being used.

- TestActionHandler [1]
- ComputeWindowActionHandler [2]
- ComputeTranslatedNameActionHandler [3]
- GridExampleActionHandler [4]


[1] https://code.openbravo.com/erp/devel/pi/file/285226a2a73b/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/TestActionHandler.java [^]
[2] https://code.openbravo.com/erp/devel/pi/file/285226a2a73b/modules/org.openbravo.client.application/src/org/openbravo/client/application/ComputeWindowActionHandler.java [^]
[3] https://code.openbravo.com/erp/devel/pi/file/285226a2a73b/modules/org.openbravo.client.application/src/org/openbravo/client/application/ComputeTranslatedNameActionHandler.java [^]
[4] https://code.openbravo.com/erp/devel/pi/file/285226a2a73b/modules/org.openbravo.client.application/src/org/openbravo/client/application/example/GridExampleActionHandler.java [^]
In description
No tags attached.
related to defect 0037758 scheduled jarmendariz API Change: Remove unused ActionHandlers 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Issue History
2016-11-14 12:17caristuNew Issue
2016-11-14 12:17caristuAssigned To => platform
2016-11-14 12:17caristuModules => Core
2016-11-14 12:17caristuTriggers an Emergency Pack => No
2016-11-14 12:25caristuSummary[clustering] Remove TestActionHandler => [clustering] Remove unused action handlers
2016-11-14 12:25caristuDescription Updatedbug_revision_view_page.php?rev_id=13663#r13663
2016-11-14 13:09caristuRelationship addedrelated to 0034490
2016-11-14 17:21caristuSeverityminor => trivial
2016-11-14 17:21caristuReproducibilityalways => N/A
2016-11-15 09:05alostaleRelationship addedblocks 0032688
2016-11-15 09:05alostaleRelationship deletedrelated to 0034490
2016-11-15 09:05alostaleStatusnew => acknowledged
2016-11-15 09:05alostaleSummary[clustering] Remove unused action handlers => Remove unused action handlers
2016-12-01 13:15alostalePriorityhigh => low
2017-12-13 19:28caristuAssigned Toplatform => jarmendariz
2018-01-23 12:48jarmendarizStatusacknowledged => scheduled
2018-01-30 08:59jarmendarizRelationship addedrelated to 0037758
2018-02-15 17:15caristuNote Added: 0102445
2018-02-15 17:35caristuNote Edited: 0102445bug_revision_view_page.php?bugnote_id=0102445#r16711
2018-02-15 17:35caristuNote Edited: 0102445bug_revision_view_page.php?bugnote_id=0102445#r16712
2018-02-15 17:47caristuNote Edited: 0102445bug_revision_view_page.php?bugnote_id=0102445#r16714
2018-02-15 17:47caristuNote Edited: 0102445bug_revision_view_page.php?bugnote_id=0102445#r16715
2018-02-15 17:50caristuNote Edited: 0102445bug_revision_view_page.php?bugnote_id=0102445#r16716
2018-02-15 17:51caristuNote Edited: 0102445bug_revision_view_page.php?bugnote_id=0102445#r16717

Notes
(0102445)
caristu   
2018-02-15 17:15   
(edited on: 2018-02-15 17:51)
- ComputeTranslatedNameActionHandler is not used in core but it is being used by third party modules. It should not be removed.

- ComputeWindowActionHandler can not be removed because it is invoked from JS code. See[1] and [2]. It should not be removed.

- GridExampleActionHandler is referenced from JS example code included in core...See[3]. Also [4] is referenced by third party modules...

[1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js#l386 [^]
[2] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-compatibility.js#l79 [^]
[3] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/example/grid-example.html#l22 [^]
[4] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/example/grid-example.js [^]