Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034481Openbravo ERPA. Platformpublic2016-11-13 22:462016-12-16 18:38
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q1Fixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034481: Webservice and standard login support different request parameters for login, support same parameters in webservice/standard
DescriptionThe webservice login uses the parameters l and p [1]. The standard login supports the parameters user and password [2].

[1]
https://code.openbravo.com/erp/devel/pi/file/9f6bced23888/src/org/openbravo/authentication/AuthenticationManager.java#l353 [^]

[2]
https://code.openbravo.com/erp/devel/pi/file/9f6bced23888/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java#l83 [^]
Steps To ReproduceCheck the code
Proposed SolutionSupport parameters user and password in webservice login and support parameters l and p in standard login
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00344863.0PR17Q1 closed mtaal Support web/mobile service requests which do not create a http session but still supports login 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-13 22:46mtaalNew Issue
2016-11-13 22:46mtaalAssigned To => mtaal
2016-11-13 22:46mtaalModules => Core
2016-11-13 22:46mtaalTriggers an Emergency Pack => No
2016-11-14 12:25mtaalRelationship addedrelated to 0034486
2016-11-14 12:26hgbotCheckin
2016-11-14 12:26hgbotNote Added: 0091447
2016-11-14 12:26hgbotStatusnew => resolved
2016-11-14 12:26hgbotResolutionopen => fixed
2016-11-14 12:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/78990dcd4bf30a37fb0be76b7771f5bc05fa4dfd [^]
2016-11-15 11:22mtaalReview Assigned To => alostale
2016-11-25 09:57alostaleNote Added: 0091817
2016-11-25 09:57alostaleStatusresolved => closed
2016-11-25 09:57alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092614

Notes
(0091447)
hgbot   
2016-11-14 12:26   
Repository: erp/devel/pi
Changeset: 78990dcd4bf30a37fb0be76b7771f5bc05fa4dfd
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Nov 14 12:25:55 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/78990dcd4bf30a37fb0be76b7771f5bc05fa4dfd [^]

Fixes issue 34481: Webservice and standard login support different request parameters for login
Add support for user/password parameter in webservice and l and p parameters in standard
authenticationmanager

---
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---
(0091817)
alostale   
2016-11-25 09:57   
code reviewed
(0092614)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test