Openbravo Issue Tracking System - Retail Modules
View Issue Details
0034475Retail ModulesWeb POSpublic2016-11-11 14:122017-01-16 09:40
asiermartirena 
asiermartirena 
normalmajoralways
closedfixed 
5
 
RR17Q2 
marvintm
No
0034475: In a ShowConfirmation popup, it would be nice to have access to the popup in buttons actions
In a ShowConfirmation popup, it would be nice to have access to the popup object in its buttons actions.
Create a showConfirmation popup.
Verify that during its action code execution there's no access to the popup object.
No tags attached.
depends on backport 0034866RR17Q1 closed asiermartirena In a ShowConfirmation popup, it would be nice to have access to the popup in buttons actions 
Issue History
2016-11-11 14:12asiermartirenaNew Issue
2016-11-11 14:12asiermartirenaAssigned To => asiermartirena
2016-11-11 14:12asiermartirenaTriggers an Emergency Pack => No
2016-11-12 08:48hgbotCheckin
2016-11-12 08:48hgbotNote Added: 0091410
2016-11-12 08:48hgbotStatusnew => resolved
2016-11-12 08:48hgbotResolutionopen => fixed
2016-11-12 08:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a05e98c9107da0fc31549f26590a0ff232ba8115 [^]
2016-11-17 11:01OrekariaNote Added: 0091627
2016-11-17 11:01OrekariaStatusresolved => new
2016-11-17 11:01OrekariaResolutionfixed => open
2016-11-17 11:02OrekariaNote Edited: 0091627bug_revision_view_page.php?bugnote_id=0091627#r13793
2016-11-17 11:02OrekariaNote Edited: 0091627bug_revision_view_page.php?bugnote_id=0091627#r13794
2016-11-17 11:02OrekariaStatusnew => scheduled
2016-12-30 10:31guilleaerStatusscheduled => resolved
2016-12-30 10:31guilleaerFixed in Version => RR17Q1
2016-12-30 10:31guilleaerResolutionopen => fixed
2016-12-30 10:31guilleaerReview Assigned To => guilleaer
2016-12-30 10:31guilleaerNote Added: 0093070
2016-12-30 10:31guilleaerStatusresolved => closed
2016-12-30 10:32guilleaerNote Deleted: 0093070
2016-12-30 10:33guilleaerStatusclosed => new
2016-12-30 10:33guilleaerResolutionfixed => open
2016-12-30 10:33guilleaerFixed in VersionRR17Q1 =>
2016-12-30 10:41guilleaerStatusnew => scheduled
2016-12-30 13:37hgbotCheckin
2016-12-30 13:37hgbotNote Added: 0093075
2017-01-09 13:16marvintmStatusscheduled => acknowledged
2017-01-09 13:17marvintmStatusacknowledged => scheduled
2017-01-09 13:48hgbotCheckin
2017-01-09 13:48hgbotNote Added: 0093256
2017-01-09 13:48hgbotStatusscheduled => resolved
2017-01-09 13:48hgbotResolutionopen => fixed
2017-01-09 13:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a05e98c9107da0fc31549f26590a0ff232ba8115 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5305adc199e54cfac5801f845181ab11d71acc08 [^]
2017-01-16 09:40marvintmReview Assigned Toguilleaer => marvintm
2017-01-16 09:40marvintmStatusresolved => closed
2017-01-16 09:40marvintmFixed in Version => RR17Q2

Notes
(0091410)
hgbot   
2016-11-12 08:48   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a05e98c9107da0fc31549f26590a0ff232ba8115
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Sat Nov 12 08:48:29 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a05e98c9107da0fc31549f26590a0ff232ba8115 [^]

Fixed issue 34475: In a ShowConfirmation popup, it would be nice to have access to the popup in buttons actions

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0091627)
Orekaria   
2016-11-17 11:01   
(edited on: 2016-11-17 11:02)
Offering the original object to an object that can be accessed outside mobile.core, creates a maintenance/API problem, because any change to the object can break the API, i.e. unknown external code depending on it

Please expose exactly the part of the object that you require for your development (or talk with the Retail team)

(0093075)
hgbot   
2016-12-30 13:37   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f6a9e2d36b15241b651ded7e88192ac66b200cc3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Dec 30 10:53:10 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f6a9e2d36b15241b651ded7e88192ac66b200cc3 [^]

Related to issue 34475: Backout this commit because release is going to be closed and this change was not approved

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0093256)
hgbot   
2017-01-09 13:48   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5305adc199e54cfac5801f845181ab11d71acc08
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Jan 09 13:46:38 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5305adc199e54cfac5801f845181ab11d71acc08 [^]

Fixed issue 34475: -this- Argument is passed to action function

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---