Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034469Openbravo ERPA. Platformpublic2016-11-11 10:262016-12-16 18:38
ReporterNaroaIriarte 
Assigned ToNaroaIriarte 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034469: The manage variants record selection is not working properly
DescriptionIf a record is selected by clicking in the checkbox, in the Manage Variants window and after that any action is done, for example use a filter or clean it, the selected record is unchecked. It still appears as it was selected but visually it is not checked.
Steps To Reproduce1- Log in the erp as F&B Admin.
2- Go to "Produc Characteristic" window and create a new product characteristic.
3- Mark the product characteristic as variant and add some values to it.
4- Go to "Product" window and create a new product.
5- Check the "Is Generic" chackbox.
6- Go to the "Characteristic" subtab and add the previously created charaacteristic.
7- Mark it as variant.
8- Run the "Generate Variants" process.
9- Click on the "Manage Variants" process.
10- Select the first record by clicking the checkbox and realize that it is correctly selected, the checkbox is checked and a pushpin icon is shown.
11- Write anything in a filter.
12- Realize that the firstly selected record still appears, that is correct but realize also that the checkbox is no more selected and the pushpin icon has disappeared.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034405pi closed NaroaIriarte 'Manage Variants' process returns no items to show when filtering 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-11 10:26NaroaIriarteNew Issue
2016-11-11 10:26NaroaIriarteAssigned To => platform
2016-11-11 10:26NaroaIriarteModules => Core
2016-11-11 10:26NaroaIriarteTriggers an Emergency Pack => No
2016-11-11 10:27NaroaIriarteRelationship addedrelated to 0034405
2016-11-11 11:09NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-11-11 11:09NaroaIriarteStatusnew => acknowledged
2016-11-14 09:19NaroaIriarteStatusacknowledged => scheduled
2016-11-15 10:58NaroaIriarteReview Assigned To => alostale
2016-11-15 11:09hgbotCheckin
2016-11-15 11:09hgbotNote Added: 0091546
2016-11-15 11:09hgbotStatusscheduled => resolved
2016-11-15 11:09hgbotResolutionopen => fixed
2016-11-15 11:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/12c3032e3ef15240bc862e357a0bbfeff933580c [^]
2016-11-25 09:07alostaleNote Added: 0091805
2016-11-25 09:07alostaleStatusresolved => closed
2016-11-25 09:07alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092629

Notes
(0091546)
hgbot   
2016-11-15 11:09   
Repository: erp/devel/pi
Changeset: 12c3032e3ef15240bc862e357a0bbfeff933580c
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Tue Nov 15 11:08:06 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/12c3032e3ef15240bc862e357a0bbfeff933580c [^]

Fixed issue 34469: The manage variants record selection was not working fine.

When a record was selected and after that another action was done, the record which must remain selected, was not.
The problem was in the "ManageVariantsDS". There was a property which was not being set. In the client there is a place where it is searching the selected records by a "findByKey" method. This method was searching the property "primaryKeys" and it needs to have the id set. In this case, as it was not set, it was not returning anything and it was not being able to find the selected record. That was causing the problem of the unselected record.
The fix consists on implementing the "getDataSourceProperties" method and there set the needed properties of the datasource.

---
M src/org/openbravo/materialmgmt/ManageVariantsDS.java
---
(0091805)
alostale   
2016-11-25 09:07   
code reviewed + tested
(0092629)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test