Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034461Retail ModulesWeb POSpublic2016-11-10 12:462021-01-21 15:33
Reporterxabiermerino 
Assigned Tomario_castello 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034461: [SERQA 2019] When creating a sales order in the pos, the shipment is created with an incorrect warehouse in the header
DescriptionThere are different things to fix:
1) The Query to select the warehouse needs to be improved and check if the WH is active or not. Nowaday this validation is not done and it can select a WH that is not active.
2) The lines of the shipments have a storage bin that does not belong to the warehouse defined in the header. Proposed solution is the following: when inserting the first line of the shipment check if the storage bin belongs to the WH defined in the header. If it belongs to the WH do nothing. If it does not belong, update the WH in header with the correct WH.

Furthermore, The button "Active" in the header of the screen "Warehouse and Storage Bin" is not effective. For instance, if we unflag this field, the warehouse still appears in the Webpos (cf. Video enclosed)
Steps To ReproduceSteps to reproduce: when the store has more than one WH and all of them has the same priority.
1) Create an order in the WebPOS
2) check in the backend the shipment created for that order. The lines has storge bins that don't belong to the WH defined in the header.

Other issue: (see video)
1) In the BO, unflag the field "Active" for the screen "Warehouse and Storage Bin"
2) In the Webpos, creating a ticket, the warehouse is still available
Proposed Solution
Additional Information
TagsSER-QA
Relationships
has duplicate defect 0035358 closed mario_castello Storage Bin does not correspond with the Warehouse in those cases where a store has several warehouses 
related to defect 0043233 closed ranjith_qualiantech_com Stock is not taken from the warehouse that has stock but for the warehouse without stock if it has only one storage bin 
Attached Filesdiff issue34461.diff (1,840) 2016-11-10 13:08
https://issues.openbravo.com/file_download.php?file_id=10032&type=bug
? 34461.mp4 (2,649,068) 2016-11-11 15:43
https://issues.openbravo.com/file_download.php?file_id=10041&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-10 12:46xabiermerinoNew Issue
2016-11-10 12:46xabiermerinoAssigned To => Retail
2016-11-10 12:46xabiermerinoResolution time => 1478818800
2016-11-10 12:46xabiermerinoTriggers an Emergency Pack => No
2016-11-10 12:46xabiermerinoTag Attached: SER-QA
2016-11-10 13:08marvintmFile Added: issue34461.diff
2016-11-10 13:11xabiermerinoResolution time1478818800 => 1479423600
2016-11-10 14:58mario_castelloAssigned ToRetail => mario_castello
2016-11-10 15:08mario_castelloStatusnew => acknowledged
2016-11-10 15:22mario_castelloStatusacknowledged => scheduled
2016-11-11 15:41hgbotCheckin
2016-11-11 15:41hgbotNote Added: 0091405
2016-11-11 15:41hgbotStatusscheduled => resolved
2016-11-11 15:41hgbotResolutionopen => fixed
2016-11-11 15:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c7ecbfdafd982eb0cebf69901caa9f219ff97d1 [^]
2016-11-11 15:42hgbotCheckin
2016-11-11 15:42hgbotNote Added: 0091406
2016-11-11 15:43paul_guiotStatusresolved => scheduled
2016-11-11 15:43paul_guiotResolutionfixed => open
2016-11-11 15:43paul_guiotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c7ecbfdafd982eb0cebf69901caa9f219ff97d1 [^] =>
2016-11-11 15:43paul_guiotDescription Updatedbug_revision_view_page.php?rev_id=13647#r13647
2016-11-11 15:43paul_guiotSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13649#r13649
2016-11-11 15:43paul_guiotFile Added: 34461.mp4
2016-11-15 15:00hgbotCheckin
2016-11-15 15:00hgbotNote Added: 0091566
2016-11-15 15:00hgbotStatusscheduled => resolved
2016-11-15 15:00hgbotResolutionopen => fixed
2016-11-15 15:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bed60ef230869b21181ac5fd23060be171daea9 [^]
2016-11-15 15:13hgbotCheckin
2016-11-15 15:13hgbotNote Added: 0091567
2016-11-21 10:07marvintmNote Added: 0091687
2016-11-21 10:07marvintmStatusresolved => new
2016-11-21 10:07marvintmResolutionfixed => open
2016-11-21 15:39mario_castelloStatusnew => acknowledged
2016-11-21 15:39mario_castelloStatusacknowledged => scheduled
2016-11-25 14:51hgbotCheckin
2016-11-25 14:51hgbotNote Added: 0091850
2016-11-25 14:51hgbotStatusscheduled => resolved
2016-11-25 14:51hgbotResolutionopen => fixed
2016-11-25 14:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bed60ef230869b21181ac5fd23060be171daea9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42c6e292b16f77732ad8890dc3e5edb482c97a7b [^]
2016-11-25 14:53hgbotCheckin
2016-11-25 14:53hgbotNote Added: 0091851
2016-11-25 15:13marvintmReview Assigned To => marvintm
2016-11-25 15:13marvintmStatusresolved => closed
2016-11-25 15:13marvintmFixed in Version => RR17Q1
2017-02-27 18:04mario_castelloRelationship addedblocks 0035358
2017-02-28 15:08mario_castelloRelationship deletedblocks 0035358
2017-02-28 15:09mario_castelloRelationship addedhas duplicate 0035358
2020-02-24 12:06ranjith_qualiantech_comRelationship addedrelated to 0043233
2021-01-21 15:33hgbotNote Added: 0125714

Notes
(0091405)
hgbot   
2016-11-11 15:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0c7ecbfdafd982eb0cebf69901caa9f219ff97d1
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Nov 10 09:33:45 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c7ecbfdafd982eb0cebf69901caa9f219ff97d1 [^]

Fixed issue 34461: Set the same warehouse in the shipmentLines and in the header of the shipment

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0091406)
hgbot   
2016-11-11 15:42   
Repository: tools/automation/pi-mobile
Changeset: ce8d5c699dd0fe1ffcad563e3ed8377a0cdd2d96
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Nov 10 09:57:06 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ce8d5c699dd0fe1ffcad563e3ed8377a0cdd2d96 [^]

Verifies issue 34461: Added automated test I34461_VerifyWareHouseShipmetLines

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34461_VerifyWareHouseShipmetLines.java
---
(0091566)
hgbot   
2016-11-15 15:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9bed60ef230869b21181ac5fd23060be171daea9
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 14 10:03:22 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bed60ef230869b21181ac5fd23060be171daea9 [^]

Fixed issue 34461: Added validation in warehouse class to load the active warehouse

---
M src/org/openbravo/retail/posterminal/term/Warehouses.java
---
(0091567)
hgbot   
2016-11-15 15:13   
Repository: tools/automation/pi-mobile
Changeset: f21a78cdcf6baa268e237ba34aebd2f03d6ec0af
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 14 10:20:49 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f21a78cdcf6baa268e237ba34aebd2f03d6ec0af [^]

Verifies issue 34461: Added automated test I34461_VerifyWareHouseOrderAndShipmetLines

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34461_VerifyWareHouseOrderAndShipmetLines.java
---
(0091687)
marvintm   
2016-11-21 10:07   
Now only the active warehouses are loaded in the Web POS, which is correct. However, the "Store stock: " and "Other stores stock: " buttons seemingly still don't filter by the active property for the warehouses, so they still appear there if they are not active, and this is not correct.
(0091850)
hgbot   
2016-11-25 14:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 42c6e292b16f77732ad8890dc3e5edb482c97a7b
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 21 10:39:07 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42c6e292b16f77732ad8890dc3e5edb482c97a7b [^]

Fixed issue 0034461: [SERQA 2019] When creating a sales order in the pos, the shipment is created with an incorrect warehouse in the header

- Added validation in the hql query for StoreDetailedStock class to load the information for all active warehouse
- Added validation in OtherStoresDetailedStock class

---
M src/org/openbravo/retail/posterminal/stock/OtherStoresDetailedStock.java
M src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
---
(0091851)
hgbot   
2016-11-25 14:53   
Repository: tools/automation/pi-mobile
Changeset: 70c2ceeedd2cdd1644f514a6c9e7d0c6b55f9dde
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Nov 22 08:46:14 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/70c2ceeedd2cdd1644f514a6c9e7d0c6b55f9dde [^]

Verifies issue 34461: Added automated test I34461_VerifyWareHouseAndStock

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34461_VerifyWareHouseAndStock.java
---
(0125714)
hgbot   
2021-01-21 15:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: eea3efdf43d8a3f00d547420379dd59b5d5a520c
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-01-21T20:02:22+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/eea3efdf43d8a3f00d547420379dd59b5d5a520c [^]

Related to BUG-34461: Fixes test I34461_VerifyWareHouseShipmetLines in try high volume
* Handled missed scenarios to set the same warehouse in the shipmentLines and in the header of the shipment
* Refer Commit 0c7ecbfdafd982eb0cebf69901caa9f219ff97d1

---
M src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java
---