Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034459Retail ModulesDiscounts and Promotionspublic2016-11-03 11:032016-12-19 06:24
Reporterplujan 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2016-09-27
Regression introduced in releaseRR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97c95e2c63c9 [^]
Triggers an Emergency PackNo
Summary0034459: [RR16Q4] Persistent deleted tickets do not keep manual discounts
DescriptionWhen persistent deletion of tickets preference is activated, tickets deleted at draft are kept in the backend. If a line has a discount applied, this discount is not persisted.
Steps To ReproduceSteps are the same of this test case: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9692 [^]

1. Set the "Web POS Save Removed Tickets" preference to Y
2. create a draft ticket for two different items.
3. Edit one line and add a manual discount of 5%
4. Click the delete button
5. Repeat steps 2 and 3 to get the same lines again.
6. This time, complete the ticket
7. Go to the backend and check the two records created. Note the line with the discount is different in both tickets. The completed ticket has the "Net Unit Price" with the discount and there is a line in "Discounts and Promotions", while the deleted ticket has the standard Net Unit Price and no discounts and promotions.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034372 closed ranjith_qualiantech_com [RR16Q4] Persistent deleted tickets do not keep manual discounts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-10 09:54ranjith_qualiantech_comTypedefect => backport
2016-11-10 09:54ranjith_qualiantech_comTarget Version => RR16Q4
2016-12-06 10:54hgbotCheckin
2016-12-06 10:54hgbotNote Added: 0092124
2016-12-07 14:06ranjith_qualiantech_comStatusscheduled => resolved
2016-12-07 14:06ranjith_qualiantech_comResolutionopen => fixed
2016-12-09 13:29marvintmReview Assigned To => marvintm
2016-12-09 13:29marvintmStatusresolved => closed
2016-12-09 13:29marvintmFixed in Version => RR16Q4
2016-12-09 15:20hgbotCheckin
2016-12-09 15:20hgbotNote Added: 0092256
2016-12-09 15:20hgbotStatusclosed => resolved
2016-12-09 15:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5afe501174bf71d5f23fea137862dde3d03c485b [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/8029de09561ef045c50ddbc88e740824b6c4030a [^]
2016-12-09 15:21marvintmStatusresolved => closed
2016-12-16 08:40hgbotCheckin
2016-12-16 08:40hgbotNote Added: 0092448
2016-12-16 08:40hgbotStatusclosed => resolved
2016-12-16 08:40hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/8029de09561ef045c50ddbc88e740824b6c4030a [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/8029de09561ef045c50ddbc88e740824b6c4030a [^]
2016-12-19 06:24priyamNote Added: 0092744
2016-12-19 06:24priyamStatusresolved => closed

Notes
(0092124)
hgbot   
2016-12-06 10:54   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: e2f7541ea9843a82470d6d161f69978cd452135c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 10 12:38:51 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/e2f7541ea9843a82470d6d161f69978cd452135c [^]

Related to issue 34459, backport of issue 34372: Save Promotions if the Save Remove ticket preference is enabled

* Calculate price before calculate receipt inorder to set promotional amounts
* Reset lineGrossAmount, grossUnitPrice, standardPrice, listPrice to 0, if ticket is deleted

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092256)
hgbot   
2016-12-09 15:20   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: 8029de09561ef045c50ddbc88e740824b6c4030a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:45:01 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/8029de09561ef045c50ddbc88e740824b6c4030a [^]

Fixes issue 34459, backport of issue 34372: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I34372_VerifyDiscountInDeletedReceipt.java
---
(0092448)
hgbot   
2016-12-16 08:40   
Repository: tools/automation/pi-mobile
Changeset: 8029de09561ef045c50ddbc88e740824b6c4030a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:45:01 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8029de09561ef045c50ddbc88e740824b6c4030a [^]

Fixes issue 34459, backport of issue 34372: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I34372_VerifyDiscountInDeletedReceipt.java
---
(0092744)
priyam   
2016-12-19 06:24   
Closing as merge of pi-mobiles Q4 tag updated the issues.