Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034454Openbravo ERPA. Platformpublic2016-11-09 09:442016-11-10 10:00
JONHM 
alostale 
immediateminoralways
closedfixed 
5
pi 
3.0PR16Q43.0PR16Q4 
caristu
Core
Production - QA Approved
2016-04-18
3.0PR16Q3
http://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
No
0034454: can't add attachment to Invoices after print and attach
If we try to add an attachment in [Purchase Invoice] window when there is already an attachment included, it shows an error "freemarker.template.TemplateModelException".
In an instance with no modules in development

1) Open [Purchase Invoice] window and select some record
2) Press button "Print Record" and press "Yes" to attach the document
3) Expand attachments section and press "Add" to add a new document
---> It shows the error
Caused by: freemarker.template.TemplateModelException: get(title) failed on instance of org.openbravo.client.application.window.OBViewParameterHandler$OBViewParameter
  ...
Caused by: org.hibernate.LazyInitializationException: could not initialize proxy - no Session
    at org.hibernate.proxy.AbstractLazyInitializer.initialize(AbstractLazyInitializer.java:167)
    at org.hibernate.proxy.AbstractLazyInitializer.getImplementation(AbstractLazyInitializer.java:215)
    at org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer.invoke(JavassistLazyInitializer.java:190)
    at org.openbravo.model.ad.ui.Element_$$_javassist_10.getADElementTrlList(Element_$$_javassist_10.java)
    at org.openbravo.client.application.window.OBViewUtil.getParameterTitle(OBViewUtil.java:105)
    at org.openbravo.client.application.window.OBViewParameterHandler$OBViewParameter.getTitle(OBViewParameterHandler.java:241)
    ... 85 more

Note this happens when 2 is the first action in the current session regarding attachments for that window, in case add attachment is executed before, there is no issue.
Workaround: if in this situation, log out and log in to be able to add new attachments.
No tags attached.
blocks defect 0034439 closed alostale can't add attachment to Invoices after print and attach 
Issue History
2016-11-09 15:54alostaleTypedefect => backport
2016-11-09 15:54alostaleTarget Version => 3.0PR16Q4
2016-11-09 16:16alostaleReview Assigned To => caristu
2016-11-09 16:37hgbotCheckin
2016-11-09 16:37hgbotNote Added: 0091297
2016-11-09 16:37hgbotStatusscheduled => resolved
2016-11-09 16:37hgbotResolutionopen => fixed
2016-11-09 16:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/44b5f7915b19586eec7d8b39443c6e9b07be6d60 [^]
2016-11-10 09:44hgbotCheckin
2016-11-10 09:44hgbotNote Added: 0091316
2016-11-10 10:00caristuNote Added: 0091320
2016-11-10 10:00caristuStatusresolved => closed
2016-11-10 10:00caristuFixed in Version => 3.0PR16Q4

Notes
(0091297)
hgbot   
2016-11-09 16:37   
Repository: erp/backports/3.0PR16Q4
Changeset: 44b5f7915b19586eec7d8b39443c6e9b07be6d60
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 09 16:33:22 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/44b5f7915b19586eec7d8b39443c6e9b07be6d60 [^]

fixed bug 34454: can't add attachment to Invoices after print and attach

  When trying to add a new attachemnt just after attaching a printed document,
  a LazyInitializationException was thrown because ADCS cache parameter object
  was partially initialized. Programmatic attachement API initialized the parameters
  but not their translation lists.

  Fixed by initializating translation lists for parameters whenever it is added
  to ADCS.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
---
(0091316)
hgbot   
2016-11-10 09:44   
Repository: erp/backports/3.0PR16Q4
Changeset: d3890f39afaa650dfe96584f26d9a81f03cf1783
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Nov 10 09:42:06 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/d3890f39afaa650dfe96584f26d9a81f03cf1783 [^]

related to bug 34454: fixed the problem for sales windows

  Paramter translation for sales windows is obtained directly from parameter def
  instead of from element. This was not initialized in cached ADCS.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
---
(0091320)
caristu   
2016-11-10 10:00   
Code reviewed + tested OK: working on both sale and purchase flows