Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034452Openbravo ERP07. Sales managementpublic2016-11-09 14:012016-12-16 18:38
asiermartirena 
asiermartirena 
normalmajorhave not tried
closedfixed 
5
 
3.0PR17Q1 
aferraz
Core
No
0034452: In cancel and replace, the inverse order must be set as canceled
In C&R process, the inverse order must have the iscancelled field to true
Do a cancel and replace process.
Check that the inverse order doesn't have the iscancelled field to true.
No tags attached.
Issue History
2016-11-09 14:01asiermartirenaNew Issue
2016-11-09 14:01asiermartirenaAssigned To => asiermartirena
2016-11-09 14:01asiermartirenaModules => Core
2016-11-09 14:01asiermartirenaTriggers an Emergency Pack => No
2016-11-10 08:57hgbotCheckin
2016-11-10 08:57hgbotNote Added: 0091313
2016-11-10 08:57hgbotStatusnew => resolved
2016-11-10 08:57hgbotResolutionopen => fixed
2016-11-10 08:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ef9e568098e412cdf120f6d5e928997250658971 [^]
2016-11-10 09:54asiermartirenaReview Assigned To => aferraz
2016-11-10 10:02psanjuanNote Added: 0091322
2016-11-10 10:17psanjuanNote Added: 0091323
2016-11-10 10:24psanjuanNote Edited: 0091323bug_revision_view_page.php?bugnote_id=0091323#r13629
2016-11-10 10:56psanjuanNote Edited: 0091323bug_revision_view_page.php?bugnote_id=0091323#r13630
2016-11-10 11:00psanjuanNote Added: 0091325
2016-11-10 11:03psanjuanNote Edited: 0091325bug_revision_view_page.php?bugnote_id=0091325#r13632
2016-11-10 11:04psanjuanNote Added: 0091326
2016-11-10 11:06aferrazNote Added: 0091327
2016-11-10 11:06aferrazStatusresolved => closed
2016-11-10 11:06aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092607

Notes
(0091313)
hgbot   
2016-11-10 08:57   
Repository: erp/devel/pi
Changeset: ef9e568098e412cdf120f6d5e928997250658971
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Thu Nov 10 08:57:09 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ef9e568098e412cdf120f6d5e928997250658971 [^]

Fixed issue 34452: In cancel and replace, the inverse order must be set as canceled

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0091322)
psanjuan   
2016-11-10 10:02   
Issue verified.
(0091323)
psanjuan   
2016-11-10 10:17   
(edited on: 2016-11-10 10:56)
Test Plan

Test Case 1 - one cancel and replace flow.

As F&B International Group Admin role go to Sales Order window.
Make sure "Enable Cancel and Replace" preference is active.

Go to sales order window and create a new one for F&B España, Alimentos y Supermercados business partner. Select any product and quantity and complete the order.

Write down sales order number for instace 1000137.

Press on cancel and replace, then done.

Check that a new order in "Temporal" status has been created.
Press Confirm Cancel and replace.

Filter by 10000137.
Go to order number 1000137*R (that is the inverse order) and verify that the check "Is canceled" = yes, together with Canceled order = 1000137

Go to order number 1000137 (that is the original order) and verify that the check "Is canceled" = Yes, together with Replacement Order = 1000137-1

Go to order number 1000137-1 (that is the replacement order) and verify that the check "Is canceled" = No, together with Replaced Order = 1000137

This is correct.

Repeat same test as above by making any change in the "temporal" sales order.
Results should be the same.

(0091325)
psanjuan   
2016-11-10 11:00   
(edited on: 2016-11-10 11:03)
Test Case 2 - more than one cancel and replace flow.

As F&B International Group Admin role go to Sales Order window.
Make sure "Enable Cancel and Replace" preference is active.

Go to sales order window and create a new one for F&B España, Alimentos y Supermercados business partner. Select any product and quantity and complete the order.

Write down sales order number for instace 1000375.

Press on cancel and replace, then done.

Check that a new order in "Temporal" status has been created.
Press Confirm Cancel and replace.

Filter by 10000375

Go to order number 1000375 (that is the original order) and verify that the check "Is canceled" = Yes, together with Replacement Order = 1000375-1

Go to order number 1000375*R (that is the inverse order) and verify that the check "Is canceled" = yes, together with Canceled order = 1000375

Go to order number 1000375-1 (that is the replacement order) and verify that the check "Is canceled" = No, together with Replaced Order = 1000375

From order 1000375-1 press cancel and replace once more. Press Done.
In the temporary sales order created 1000375-2 make any change in Lines tab and Confirm Cancel and Replace.

Filter by 1000375
Go to order number 1000375 (that is the original order) and verify that the check "Is canceled" = Yes, together with Replacement Order = 1000375-1

Go to order number 1000375*R (that is the inverse order) and verify that the check "Is canceled" = yes, together with Canceled order = 1000375

Go to order number 1000375-1 (that is the original order) and verify that the check "Is canceled" = Yes, together with Replaced Order = 1000375 and Replacement Order = 1000375-2

Go to order number 1000375-1*R (that is the inverse order) and verify that the check "Is canceled" = Yes, together with Replaced Order = 1000375 and Canceled Order = 1000375-1

Go to order number 1000375-2 (that is the replacement order) and verify that the check "Is canceled" = No, together with Replaced Order = 1000375-1

(0091326)
psanjuan   
2016-11-10 11:04   
Test Plan above verifed. Issue can be closed.
(0091327)
aferraz   
2016-11-10 11:06   
Code review OK
(0092607)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test