Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034427Retail ModulesWeb POSpublic2016-11-04 11:122016-11-14 11:43
Reporterjorge-garcia 
Assigned Tomario_castello 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3.3Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date2016-09-19
Regression introduced in releaseRR16Q2.3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200182f3db29 [^]
Triggers an Emergency PackNo
Summary0034427: Login window is loaded even if the terminal does not exist in the database
DescriptionLogin window is loaded even if the terminal does not exist in the database.
Steps To ReproduceTry to login here

http://localhost:8080/openbravo/web/org.openbravo.retail.posterminal/?terminal=PEPE#login [^]

Wrong: The login window is rendered.
Solution: The login window should not be rendered and a popup should be shown indication the terminal name doesn't exist (check screenshot attached).

This is happening since 16Q2.3.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034396 closed mario_castello Login window is loaded even if the terminal does not exist in the database 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-08 15:42mario_castelloTypedefect => backport
2016-11-08 15:42mario_castelloTarget Version => RR16Q3.3
2016-11-11 08:51hgbotCheckin
2016-11-11 08:51hgbotNote Added: 0091366
2016-11-11 08:51hgbotStatusscheduled => resolved
2016-11-11 08:51hgbotResolutionopen => fixed
2016-11-11 08:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/832ae441d73b3fcbc628d1a28ee321f5ae62010c [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/c1b67356dffd4d363c3ddf2d7e3ae7ecf8a28fdf [^]
2016-11-14 11:43migueldejuanaReview Assigned To => migueldejuana
2016-11-14 11:43migueldejuanaNote Added: 0091440
2016-11-14 11:43migueldejuanaStatusresolved => closed

Notes
(0091366)
hgbot   
2016-11-11 08:51   
Repository: retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal
Changeset: c1b67356dffd4d363c3ddf2d7e3ae7ecf8a28fdf
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 04 16:37:03 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/c1b67356dffd4d363c3ddf2d7e3ae7ecf8a28fdf [^]

Fixed issue 34427, backport of issue 34396: Added validation for the terminal list to prevent throwed an unhandled exception.

When the terminal not exist the terminalList are empty and the process are throwing an exception when try to get an object from an empty list.

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0091440)
migueldejuana   
2016-11-14 11:43   
Tested and reviewed