Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034418Retail ModulesWeb POSpublic2016-10-27 12:512016-12-16 08:40
Reporterplujan 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034418: [RR16Q4] Split lines pop up does not allow to write certain number of lines to split
DescriptionThe "number of lines" field does not work well when using the keyboard. For example, if I have a quantity of 11, I am not allowed to write "10". See steps.
Steps To Reproduce1. Using a ticket with a product line of 11 items, edit the line and click the "Split" button.
2. The pop up is shown, two lines is the default.
3. I want to have 1 line of two items and 9 lines of one, so I focus the Number of Lines field and try to write "10".
4. Result of typing "10" is "11". This is because the first "1", is being replaced by a "2", and then the "0" forms a "20" which is also replaced by the maximum of "11".
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034315 closed jorge-garcia [RR16Q4] Split lines pop up does not allow to write certain number of lines to split 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-08 10:58jorge-garciaTypedefect => backport
2016-11-08 10:58jorge-garciaTarget Version => RR16Q4
2016-11-08 15:34hgbotCheckin
2016-11-08 15:34hgbotNote Added: 0091242
2016-11-08 15:35hgbotCheckin
2016-11-08 15:35hgbotNote Added: 0091245
2016-11-08 15:36hgbotCheckin
2016-11-08 15:36hgbotNote Added: 0091246
2016-11-08 15:36hgbotStatusscheduled => resolved
2016-11-08 15:36hgbotResolutionopen => fixed
2016-11-08 15:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/01c2f6d968e25b2d30bd6f88fa0a92be9a378334 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.mobile.core/rev/813d384f480bf17a882b740eee349bdb5a16a1fa [^]
2016-11-11 11:39plujanSummary[RR16Q3] Split lines pop up does not allow to write certain number of lines to split => [RR16Q4] Split lines pop up does not allow to write certain number of lines to split
2016-12-09 13:24marvintmReview Assigned To => marvintm
2016-12-09 13:24marvintmStatusresolved => closed
2016-12-09 13:24marvintmFixed in Version => RR16Q4
2016-12-16 08:40hgbotCheckin
2016-12-16 08:40hgbotNote Added: 0092440

Notes
(0091242)
hgbot   
2016-11-08 15:34   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: fb80d512095d60dfbb4f11469e0e7f77bdbf6c12
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:18:11 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/fb80d512095d60dfbb4f11469e0e7f77bdbf6c12 [^]

Verifies issue 34418: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

Added test I34315_AllowToPutNumberOneInNumberOfLines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34315_AllowToPutNumberOneInNumberOfLines.java
---
(0091245)
hgbot   
2016-11-08 15:35   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 1d667613b949f100fb45a26fecd6821803cadde6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:25:35 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/1d667613b949f100fb45a26fecd6821803cadde6 [^]

Related to issue 34418: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

Fix the NaN problem.

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
---
(0091246)
hgbot   
2016-11-08 15:36   
Repository: retail/backports/3.0RR16Q4/org.openbravo.mobile.core
Changeset: 813d384f480bf17a882b740eee349bdb5a16a1fa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:26:45 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.mobile.core/rev/813d384f480bf17a882b740eee349bdb5a16a1fa [^]

Fixed issue 34418: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

The problem was that the value “1” is not allowed in the split lines pop up
(it doesn0t make sense). The pop up changed dynamically the value to “2”.

The solution is to not change dynamically that value and change it only when
the user confirms the value.

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---
(0092440)
hgbot   
2016-12-16 08:40   
Repository: tools/automation/pi-mobile
Changeset: fb80d512095d60dfbb4f11469e0e7f77bdbf6c12
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:18:11 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fb80d512095d60dfbb4f11469e0e7f77bdbf6c12 [^]

Verifies issue 34418: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

Added test I34315_AllowToPutNumberOneInNumberOfLines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34315_AllowToPutNumberOneInNumberOfLines.java
---