Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034417Retail ModulesWeb POSpublic2016-10-26 18:282016-12-16 08:39
Reporterplujan 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034417: [RR16Q4] Splitting several many lines results in a poor system performance
DescriptionSplit lines functionality cannot be used to split big amounts, it will take too long to finish and might result in a system's inconsistent state. See steps.
Steps To ReproduceScenario A (expected flow):
Login into the webPOS and create a line for a product.
Click edit and change the quantity to 3.
Click the "split" button and get three lines of one product.
Pay and complete the sales flow.

Scenario B:
Login into the webPOS and create a line for a product.
Click edit and change the quantity to 100.
Click the "split" button and make 100 lines of one item each.
Note that the first line keeps the total amount and the rest of the lines are slowly added for a line-total of 0.00. (Note: in test environment around seven seconds by line, making a total of 700 secs waiting time)
Since it is taking too long, I let it finish while doing some other thing, so I click the New button to create a new order. An exception is shown (see attached screenshot)

Scenario C:
If after scenario B I return to the order, the process has stopped (no new lines were added). If I pay this order, the exception is shown again and the system remains in a greyed-out screen.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034307 closed jorge-garcia [RR16Q4] Splitting several many lines results in a poor system performance 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-08 10:57jorge-garciaTypedefect => backport
2016-11-08 10:57jorge-garciaTarget Version => RR16Q4
2016-11-08 15:34hgbotCheckin
2016-11-08 15:34hgbotNote Added: 0091239
2016-11-08 15:34hgbotCheckin
2016-11-08 15:34hgbotNote Added: 0091240
2016-11-08 15:35hgbotCheckin
2016-11-08 15:35hgbotNote Added: 0091243
2016-11-08 15:35hgbotStatusscheduled => resolved
2016-11-08 15:35hgbotResolutionopen => fixed
2016-11-08 15:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ca6025a511711faf878e589d824792d5ae9cd7aa [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/aba72683832b26bd5b0959488d6373e926960b00 [^]
2016-11-11 11:39plujanSummary[RR16Q3] Splitting several many lines results in a poor system performance => [RR16Q4] Splitting several many lines results in a poor system performance
2016-12-09 13:19marvintmReview Assigned To => marvintm
2016-12-09 13:19marvintmStatusresolved => closed
2016-12-09 13:19marvintmFixed in Version => RR16Q4
2016-12-16 08:39hgbotCheckin
2016-12-16 08:39hgbotNote Added: 0092437
2016-12-16 08:39hgbotCheckin
2016-12-16 08:39hgbotNote Added: 0092438

Notes
(0091239)
hgbot   
2016-11-08 15:34   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: 2328a104b3685a11d03550a596040ca1782476a1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:09:03 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/2328a104b3685a11d03550a596040ca1782476a1 [^]

Related to issue 34417: [RR16Q3] Splitting several many lines results in a poor
system performance

Added some new TestIds for Split Lines PopUp.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
---
(0091240)
hgbot   
2016-11-08 15:34   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: 056a4b3feb84d76b3a5fab68ff7f6da4230400a7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:12:52 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/056a4b3feb84d76b3a5fab68ff7f6da4230400a7 [^]

Verifies issue 34417: [RR16Q3] Splitting several many lines results in a poor
system performance

Added test I34307_PerformanceTestWithSplitOfTwentyLines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34307_PerformanceTestWithSplitOfTwentyLines.java
---
(0091243)
hgbot   
2016-11-08 15:35   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: aba72683832b26bd5b0959488d6373e926960b00
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:21:17 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/aba72683832b26bd5b0959488d6373e926960b00 [^]

Fixed issue 34417: [RR16Q3] Splitting several many lines results in a poor
system performance

There some change to be mentioned:
* Change the limit of lines that could be created in split lines from 100 to 20.
* Disable New and Delete buttons in Point-Of-Sale window during the adding
of product from split lines.
* Use the functionality of Ob.Dal.usingCache to search the related services of
a product.
* Added a name unique name to the warning message component from the split
lines pop up.

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092437)
hgbot   
2016-12-16 08:39   
Repository: tools/automation/pi-mobile
Changeset: 2328a104b3685a11d03550a596040ca1782476a1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:09:03 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2328a104b3685a11d03550a596040ca1782476a1 [^]

Related to issue 34417: [RR16Q3] Splitting several many lines results in a poor
system performance

Added some new TestIds for Split Lines PopUp.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
---
(0092438)
hgbot   
2016-12-16 08:39   
Repository: tools/automation/pi-mobile
Changeset: 056a4b3feb84d76b3a5fab68ff7f6da4230400a7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 08 15:12:52 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/056a4b3feb84d76b3a5fab68ff7f6da4230400a7 [^]

Verifies issue 34417: [RR16Q3] Splitting several many lines results in a poor
system performance

Added test I34307_PerformanceTestWithSplitOfTwentyLines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34307_PerformanceTestWithSplitOfTwentyLines.java
---