Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0034396 | Retail Modules | Web POS | public | 2016-11-04 11:12 | 2016-12-16 08:40 |
|
| Reporter | jorge-garcia | |
| Assigned To | mario_castello | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | migueldejuana |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | Production - Confirmed Stable |
| Regression date | 2016-09-19 |
| Regression introduced in release | RR16Q2.3 |
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200182f3db29 [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0034396: Login window is loaded even if the terminal does not exist in the database |
| Description | Login window is loaded even if the terminal does not exist in the database. |
| Steps To Reproduce | Try to login here
http://localhost:8080/openbravo/web/org.openbravo.retail.posterminal/?terminal=PEPE#login [^]
Wrong: The login window is rendered.
Solution: The login window should not be rendered and a popup should be shown indication the terminal name doesn't exist (check screenshot attached).
This is happening since 16Q2.3. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | backport | 0034426 | RR16Q4 | closed | mario_castello | Login window is loaded even if the terminal does not exist in the database | | depends on | backport | 0034427 | RR16Q3.3 | closed | mario_castello | Login window is loaded even if the terminal does not exist in the database | | depends on | backport | 0034428 | RR16Q2.4 | closed | mario_castello | Login window is loaded even if the terminal does not exist in the database |
|
| Attached Files |  Screenshot from 2016-11-04 11-09-22.png (150,732) 2016-11-04 11:12
https://issues.openbravo.com/file_download.php?file_id=10014&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-11-04 11:12 | jorge-garcia | New Issue | |
| 2016-11-04 11:12 | jorge-garcia | Assigned To | => Retail |
| 2016-11-04 11:12 | jorge-garcia | File Added: Screenshot from 2016-11-04 11-09-22.png | |
| 2016-11-04 11:12 | jorge-garcia | OBNetwork customer | => No |
| 2016-11-04 11:12 | jorge-garcia | Triggers an Emergency Pack | => No |
| 2016-11-04 23:33 | mario_castello | Assigned To | Retail => mario_castello |
| 2016-11-04 23:33 | mario_castello | Status | new => acknowledged |
| 2016-11-04 23:33 | mario_castello | Status | acknowledged => scheduled |
| 2016-11-04 23:46 | mario_castello | Note Added: 0091185 | |
| 2016-11-04 23:47 | mario_castello | Note Edited: 0091185 | bug_revision_view_page.php?bugnote_id=0091185#r13557 |
| 2016-11-07 16:16 | mario_castello | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200182f3db29 [^] |
| 2016-11-07 17:34 | mario_castello | Regression date | => 2016-09-19 |
| 2016-11-07 17:34 | mario_castello | Regression introduced in release | => RR16Q2.3 |
| 2016-11-08 15:08 | hgbot | Checkin | |
| 2016-11-08 15:08 | hgbot | Note Added: 0091236 | |
| 2016-11-08 15:08 | hgbot | Status | scheduled => resolved |
| 2016-11-08 15:08 | hgbot | Resolution | open => fixed |
| 2016-11-08 15:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/832ae441d73b3fcbc628d1a28ee321f5ae62010c [^] |
| 2016-11-08 15:11 | hgbot | Checkin | |
| 2016-11-08 15:11 | hgbot | Note Added: 0091237 | |
| 2016-11-08 15:42 | mario_castello | Status | resolved => new |
| 2016-11-08 15:42 | mario_castello | Resolution | fixed => open |
| 2016-11-08 15:42 | mario_castello | Status | new => scheduled |
| 2016-11-08 15:44 | mario_castello | Status | scheduled => resolved |
| 2016-11-08 15:44 | mario_castello | Resolution | open => fixed |
| 2016-11-08 16:00 | jorge-garcia | Regression level | => Production - Confirmed Stable |
| 2016-11-11 08:49 | hgbot | Checkin | |
| 2016-11-11 08:49 | hgbot | Note Added: 0091354 | |
| 2016-11-11 08:50 | hgbot | Checkin | |
| 2016-11-11 08:50 | hgbot | Note Added: 0091361 | |
| 2016-11-11 08:51 | hgbot | Checkin | |
| 2016-11-11 08:51 | hgbot | Note Added: 0091365 | |
| 2016-11-11 08:53 | hgbot | Checkin | |
| 2016-11-11 08:53 | hgbot | Note Added: 0091370 | |
| 2016-11-11 09:40 | hgbot | Checkin | |
| 2016-11-11 09:40 | hgbot | Note Added: 0091376 | |
| 2016-11-11 13:32 | migueldejuana | Review Assigned To | => migueldejuana |
| 2016-11-11 13:32 | migueldejuana | Note Added: 0091399 | |
| 2016-11-11 13:32 | migueldejuana | Status | resolved => closed |
| 2016-11-21 16:30 | hgbot | Checkin | |
| 2016-11-21 16:30 | hgbot | Note Added: 0091711 | |
| 2016-11-21 19:15 | hgbot | Checkin | |
| 2016-11-21 19:15 | hgbot | Note Added: 0091722 | |
| 2016-11-24 12:52 | hgbot | Checkin | |
| 2016-11-24 12:52 | hgbot | Note Added: 0091779 | |
| 2016-11-24 12:52 | hgbot | Checkin | |
| 2016-11-24 12:52 | hgbot | Note Added: 0091781 | |
| 2016-12-06 10:54 | hgbot | Checkin | |
| 2016-12-06 10:54 | hgbot | Note Added: 0092126 | |
| 2016-12-09 15:19 | hgbot | Checkin | |
| 2016-12-09 15:19 | hgbot | Note Added: 0092253 | |
| 2016-12-16 08:40 | hgbot | Checkin | |
| 2016-12-16 08:40 | hgbot | Note Added: 0092445 | |
|
Notes |
|
|
(0091185)
|
|
mario_castello
|
2016-11-04 23:46
(edited on: 2016-11-04 23:47) |
|
|
|
|
(0091236)
|
|
hgbot
|
|
2016-11-08 15:08
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 832ae441d73b3fcbc628d1a28ee321f5ae62010c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 04 16:37:03 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/832ae441d73b3fcbc628d1a28ee321f5ae62010c [^]
Fixed issue 34396: Added validation for the terminal list to prevent throwed an unhandled exception.
When the terminal not exist the terminalList are empty and the process are throwing an exception when try to get an object from an empty list.
---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
|
|
|
|
(0091237)
|
|
hgbot
|
|
2016-11-08 15:11
|
|
Repository: tools/automation/pi-mobile
Changeset: ca3ea4beab8c19df5bb3a5a505983217aac9e350
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 07 10:24:01 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ca3ea4beab8c19df5bb3a5a505983217aac9e350 [^]
Related to issue 34396: Added automated test I34396_VerifyLoginNotExitsTerminal
---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34396_VerifyLoginNotExitsTerminal.java
---
|
|
|
|
(0091354)
|
|
hgbot
|
|
2016-11-11 08:49
|
|
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal
Changeset: 4afcff794f23b3606cd5c44bdec24b5b9260db7a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 04 16:37:03 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/4afcff794f23b3606cd5c44bdec24b5b9260db7a [^]
Fixed issue 34428, backport of issue 34396: Added validation for the terminal list to prevent throwed an unhandled exception.
When the terminal not exist the terminalList are empty and the process are throwing an exception when try to get an object from an empty list.
---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
|
|
|
|
(0091361)
|
|
hgbot
|
|
2016-11-11 08:50
|
|
|
|
|
(0091365)
|
|
hgbot
|
|
2016-11-11 08:51
|
|
Repository: retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal
Changeset: c1b67356dffd4d363c3ddf2d7e3ae7ecf8a28fdf
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 04 16:37:03 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/c1b67356dffd4d363c3ddf2d7e3ae7ecf8a28fdf [^]
Fixed issue 34427, backport of issue 34396: Added validation for the terminal list to prevent throwed an unhandled exception.
When the terminal not exist the terminalList are empty and the process are throwing an exception when try to get an object from an empty list.
---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
|
|
|
|
(0091370)
|
|
hgbot
|
|
2016-11-11 08:53
|
|
|
|
|
(0091376)
|
|
hgbot
|
|
2016-11-11 09:40
|
|
|
|
|
|
|
|
|
(0091711)
|
|
hgbot
|
|
2016-11-21 16:30
|
|
|
|
|
(0091722)
|
|
hgbot
|
|
2016-11-21 19:15
|
|
Repository: tools/automation/pi-mobile
Changeset: f0f05b0da48aedc8af5f7f85d66a9c39bec29b6e
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 07 10:24:01 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f0f05b0da48aedc8af5f7f85d66a9c39bec29b6e [^]
Related to issue 34396: Added automated test I34396_VerifyLoginNotExitsTerminal
---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34396_VerifyLoginNotExitsTerminal.java
---
|
|
|
|
(0091779)
|
|
hgbot
|
|
2016-11-24 12:52
|
|
Repository: tools/automation/pi-mobile
Changeset: 876c144996291031208cd27a07af8026ac8b1f89
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 07 10:24:01 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/876c144996291031208cd27a07af8026ac8b1f89 [^]
Related to issue 34396: Added automated test I34396_VerifyLoginNotExitsTerminal
---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34396_VerifyLoginNotExitsTerminal.java
---
|
|
|
|
(0091781)
|
|
hgbot
|
|
2016-11-24 12:52
|
|
Repository: tools/automation/pi-mobile
Changeset: 6c8d810439c398b139f824b62da36c3f17354474
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Nov 11 09:40:07 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6c8d810439c398b139f824b62da36c3f17354474 [^]
Related to issue 34396: Added automated test I34396_VerifyLoginNotExitsTerminal (fix TestIds)
---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I34065_UpdatePendingWhenLoadOrder.java
---
|
|
|
|
(0092126)
|
|
hgbot
|
|
2016-12-06 10:54
|
|
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 98b592247d5ab064a1971328989b2d0e37dad1ff
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 04 16:37:03 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/98b592247d5ab064a1971328989b2d0e37dad1ff [^]
Fixes issue 34426, backport of issue 34396: Added validation for the terminal list to prevent throwed an unhandled exception.
When the terminal not exist the terminalList are empty and the process are throwing an exception when try to get an object from an empty list.
---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
|
|
|
|
(0092253)
|
|
hgbot
|
|
2016-12-09 15:19
|
|
|
|
|
(0092445)
|
|
hgbot
|
|
2016-12-16 08:40
|
|
|