Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034393Retail ModulesWeb POSpublic2016-10-21 13:302016-12-05 13:45
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-08-16
Regression introduced in releaseRR16Q2.3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a426e814fec5#l2.7 [^]
Triggers an Emergency PackNo
Summary0034393: Click quickly twice in a product does not add 2 products but 1. In previous releases it did work.
DescriptionClicking in a product quickly produces some clicks are not caught by Web POS.
If, f.e., in an empty receipt it is added a new product and the user wants to add two units of the same products, the user would click twice quickly in the same product, but since RR16Q2.3 onwards it is not possible. (The oldest release I have had access to where I have been able to reproduce this issue is RR16Q2.3). In RR16Q1.3 it is working right so this issue is not reproducible.
It has been tested in livebuilds and no extra modules are required.

Videos reproducing the issue performing 3 clicks:
Correct behaviour (RR16Q1.3): https://drive.google.com/open?id=0Bz1bUfkEffVISHR1d2hQMFhXb2s [^]
Wrong behaviour (RR16Q2.3): https://drive.google.com/open?id=0Bz1bUfkEffVIY3F5UnlMY3c2Ykk [^]
Steps To Reproduce0-Login POS as vallblanca.
1-Create a new receipt.
2-Click BROWSE tab and go to Best sellers Category.
3-Now, click twice quickly in "Avalanche transceiver" product. Only one product will be added. In RR16Q1.3 release backwards the performance is better and it is possible to perform that action.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034271 closed ranjith_qualiantech_com Click quickly twice in a product does not add 2 products but 1. In previous releases it did work. 
Attached Filesdiff Completebackport_mobilecore.diff (729) 2016-12-02 12:47
https://issues.openbravo.com/file_download.php?file_id=10147&type=bug
diff Completebackport_posterminal.diff (4,030) 2016-12-02 12:47
https://issues.openbravo.com/file_download.php?file_id=10148&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-04 10:58ranjith_qualiantech_comTypedefect => backport
2016-11-04 10:58ranjith_qualiantech_comTarget Version => RR16Q4
2016-12-02 12:47jorge-garciaFile Added: Completebackport_mobilecore.diff
2016-12-02 12:47jorge-garciaFile Added: Completebackport_posterminal.diff
2016-12-02 12:48jorge-garciaNote Added: 0092027
2016-12-02 14:58hgbotCheckin
2016-12-02 14:58hgbotNote Added: 0092039
2016-12-03 06:30hgbotCheckin
2016-12-03 06:30hgbotNote Added: 0092064
2016-12-03 06:30hgbotStatusscheduled => resolved
2016-12-03 06:30hgbotResolutionopen => fixed
2016-12-03 06:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1edbfb39154c4d941b8eb41c313fff9e150eb6e [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.mobile.core/rev/05d5c9993d70e298d07c873ea4195217975411a2 [^]
2016-12-05 13:45guilleaerReview Assigned To => guilleaer
2016-12-05 13:45guilleaerStatusresolved => closed
2016-12-05 13:45guilleaerFixed in Version => RR16Q4

Notes
(0092027)
jorge-garcia   
2016-12-02 12:48   
Attached complete solution to the issue
(0092039)
hgbot   
2016-12-02 14:58   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: f6637957834d46f3e083cd5f0471b6d724391edd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Dec 02 19:28:13 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/f6637957834d46f3e083cd5f0471b6d724391edd [^]

Related to issue 34393 : Validating product addition while multiple clicking

* If the product has mandatory services, service screen should shown & only one unit should be added
* If the product doesn't have mandatory services, unit should be added based on no of clicks

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0092064)
hgbot   
2016-12-03 06:30   
Repository: retail/backports/3.0RR16Q4/org.openbravo.mobile.core
Changeset: 05d5c9993d70e298d07c873ea4195217975411a2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Dec 02 19:26:55 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.mobile.core/rev/05d5c9993d70e298d07c873ea4195217975411a2 [^]

Fixes issue 34393 : Set scanningFocus to false to avoid product scanning for services in search tab

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---