Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034388Retail ModulesDiscounts and Promotionspublic2016-10-26 09:282022-01-10 13:15
Reporterprakashmurugesan88 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034388: [SER-QA 1942] Error while deleting a receipt that has line with discounts applied.
DescriptionIt appears an error in the console "Divide by 0" when deleting a receipt that has line with discounts applied.

Error occurs in the following line,

https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts-but-dev/file/6c275711a250/web/org.openbravo.retail.discounts/js/promotion-discount.js#l36 [^]
Steps To ReproduceSteps to reproduce in live builds,

    Backend:
    Set Preference "Web POS Save Removed Tickets" = "Y".

    POS Terminal:
    create a new receipt.
    Add a product GPS handheld.
    Ensure discount GPS_10_per is applied to the line.
    Click on thrash icon and confirm deletion of the receipt.

    Check in browser console "Divide by 0" error will be displayed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034299 closed mario_castello [SER-QA 1942] Error while deleting a receipt that has line with discounts applied. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-04 10:11marvintmTypedefect => backport
2016-11-04 10:11marvintmTarget Version => RR16Q4
2016-12-06 10:54hgbotCheckin
2016-12-06 10:54hgbotNote Added: 0092128
2016-12-09 14:58hgbotCheckin
2016-12-09 14:58hgbotNote Added: 0092249
2016-12-09 15:03OrekariaNote Deleted: 0092128
2016-12-09 15:19hgbotCheckin
2016-12-09 15:19hgbotNote Added: 0092252
2016-12-09 15:19hgbotStatusscheduled => resolved
2016-12-09 15:19hgbotResolutionopen => fixed
2016-12-09 15:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8eec55651e77c64fb85720d618279c9f01e8e714 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^]
2016-12-12 17:04hgbotCheckin
2016-12-12 17:04hgbotNote Added: 0092293
2016-12-12 17:04hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/0349abe8cc312ad8c0aa82c3d8fcfdf1b34b4028 [^]
2016-12-12 17:27marvintmStatusresolved => closed
2016-12-12 17:27marvintmFixed in Version => RR16Q4
2016-12-16 08:40hgbotCheckin
2016-12-16 08:40hgbotNote Added: 0092444
2016-12-16 08:40hgbotStatusclosed => resolved
2016-12-16 08:40hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/0349abe8cc312ad8c0aa82c3d8fcfdf1b34b4028 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^]
2016-12-19 06:24priyamNote Added: 0092746
2016-12-19 06:24priyamStatusresolved => closed
2022-01-10 12:13hgbotNote Added: 0134169
2022-01-10 13:15hgbotNote Added: 0134171

Notes
(0092249)
hgbot   
2016-12-09 14:58   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 77ae9fb0ba7de664c844170e8c23ea2eb22be2f7
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Dec 09 14:58:02 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/77ae9fb0ba7de664c844170e8c23ea2eb22be2f7 [^]

Related to issue 34388, backport of issue 34299: Fixed divide by zero error while deleting verified return with Web POS Save Removed Tickets preference acivated

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092252)
hgbot   
2016-12-09 15:19   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: ea0a16cf68d5517550d495a80e336ded449ae38b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:36:22 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^]

Fixes issue 34388, backport of issue 34299: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I34299_VerifiedReturnsWithDiscountAndSaveRemoveTicket.java
---
(0092293)
hgbot   
2016-12-12 17:04   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 0349abe8cc312ad8c0aa82c3d8fcfdf1b34b4028
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Dec 12 17:03:52 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/0349abe8cc312ad8c0aa82c3d8fcfdf1b34b4028 [^]

Fixed issue 34388. Removed change as it's not needed, because in pi it was removed by a subsequent fix

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092444)
hgbot   
2016-12-16 08:40   
Repository: tools/automation/pi-mobile
Changeset: ea0a16cf68d5517550d495a80e336ded449ae38b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:36:22 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^]

Fixes issue 34388, backport of issue 34299: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I34299_VerifiedReturnsWithDiscountAndSaveRemoveTicket.java
---
(0092746)
priyam   
2016-12-19 06:24   
Closing as merge of pi-mobiles Q4 tag updated the issues.
(0134169)
hgbot   
2022-01-10 12:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/683 [^]
(0134171)
hgbot   
2022-01-10 13:15   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/683 [^]