Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034385Openbravo ERPZ. Otherspublic2016-11-04 09:152016-12-16 18:38
Reportermaite 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034385: Payment of 0 amount created when voiding an unpaid invoice should be created with Exchange Rate record from invoice (if any)
DescriptionAt the moment, in case an original invoice has specific rate set in Exchange Rate tab and it is Voided then reversed invoice inherits this exchange rate. Payment of 0 amount automatically created should also inherit this rate in order to avoid differences when posting it
Steps To Reproduce1. Register Sales Invoice for España organization and any BP. Add any line. Add Exchange Rate between EUR and USD as 5. Complete and Post invoice
2. Run VOID process. Realize that reversed invoice also has this exchange rate of 5. Post invoice
3. Navigate to related payment of 0 and realize that exchange rate tab is empty. In case different rate is defined at Conversion Rates window you will be posting differences when should not be the case
Proposed Solutionpayment of 0 should also copy specific Exchange Rate of invoices it is cancelling
Additional Information
TagsNo tags attached.
Relationships
related to defect 00309713.0PR16Q1 closed aferraz When voiding an unpaid invoice, payment schedule details should be canceled instead of deleted 
related to defect 0034322 closed rqueralta Payment of 0 amount created when voiding an unpaid invoice is created in Awaiting Execution status 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-04 09:15maiteNew Issue
2016-11-04 09:15maiteAssigned To => Triage Finance
2016-11-04 09:15maiteModules => Advanced Payables and Receivables Mngmt
2016-11-04 09:15maiteResolution time => 1480028400
2016-11-04 09:15maiteTriggers an Emergency Pack => No
2016-11-04 09:15maiteRelationship addedrelated to 0030971
2016-11-04 09:15maiteIssue Monitored: networkb
2016-11-04 10:02aferrazAssigned ToTriage Finance => nonofrancisco
2016-11-04 10:03aferrazRelationship addedrelated to 0034322
2016-11-11 15:27rqueraltaAssigned Tononofrancisco => rqueralta
2016-11-11 15:27rqueraltaStatusnew => scheduled
2016-11-14 04:15rqueraltaNote Added: 0091427
2016-11-24 17:18hgbotCheckin
2016-11-24 17:18hgbotNote Added: 0091789
2016-11-24 17:18hgbotStatusscheduled => resolved
2016-11-24 17:18hgbotResolutionopen => fixed
2016-11-24 17:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c1d19a6b6689346b0e62435877298cf92eaa8068 [^]
2016-11-24 17:18hgbotCheckin
2016-11-24 17:18hgbotNote Added: 0091790
2016-11-24 17:19aferrazReview Assigned To => aferraz
2016-11-24 17:19aferrazNote Added: 0091791
2016-11-24 17:19aferrazStatusresolved => closed
2016-11-24 17:19aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092655
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092656

Notes
(0091427)
rqueralta   
2016-11-14 04:15   
Test plan:

As F&B International Group Admin

  Go to Sales Order window
  1.Register Sales Invoice for España organization and any BP.
  - Add any line.
  - Add Exchange Rate between EUR and USD as 5.
  - Complete and Post invoice
  2.Run VOID process.
  - Realize that reversed invoice also has this exchange rate of 5.
  - Post invoice
  Go to Payment In window
  - Navigate to related payment of 0.
  - Realize that exchange rate tab is filled with the exhange rate of invoice it is cancelling.
(0091789)
hgbot   
2016-11-24 17:18   
Repository: erp/devel/pi
Changeset: c1d19a6b6689346b0e62435877298cf92eaa8068
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Sun Nov 13 14:52:51 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/c1d19a6b6689346b0e62435877298cf92eaa8068 [^]

Fixes issue 34385: Payment of 0 amount created when voiding an unpaid invoice

Payment of 0 amount created when voiding an unpaid invoice it is created with Exchange Rate of cancelling invoice.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0091790)
hgbot   
2016-11-24 17:18   
Repository: erp/devel/pi
Changeset: 98b5f1a7b29dfe29c45614d189b1f24c3eb5a4b0
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Nov 24 17:10:27 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/98b5f1a7b29dfe29c45614d189b1f24c3eb5a4b0 [^]

Related to issue 34385: Code review improvements

Set payment exchange rate foreign amount as zero, as payment amount will be always zero.
Copy every record in Exchange rates tab.
Remove unnecessary query.
Remove unnecessary admin mode.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0091791)
aferraz   
2016-11-24 17:19   
Code review + Testing OK
(0092655)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092656)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test