Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034380Retail ModulesWeb POSpublic2016-11-03 16:442016-11-25 15:10
Reporterjonibc 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034380: [SERQA 2064] CustomerAddrCreationHook always receive location as null.
DescriptionWhen implementing CustomerAddrCreationHook we always receive location entity as null, so is not possible to make modifications in the hook. createBPartnerAddr and editBPartnerAddr methods always return null.
Steps To Reproduce1- Put a breakpoint before calling the hook.
2- Select a customer.
3- Create a new address for the customer.
4. Check that we always receive a null location, so we are not able to do modifications.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Filesdiff CustomerAddrLoader.diff (10,643) 2016-11-03 16:44
https://issues.openbravo.com/file_download.php?file_id=10010&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-03 16:44jonibcNew Issue
2016-11-03 16:44jonibcAssigned To => Retail
2016-11-03 16:44jonibcFile Added: CustomerAddrLoader.diff
2016-11-03 16:44jonibcTriggers an Emergency Pack => No
2016-11-11 14:14xabiermerinoResolution time => 1479423600
2016-11-11 14:14xabiermerinoSummaryCustomerAddrCreationHook always receive location as null. => [SERQA 2064] CustomerAddrCreationHook always receive location as null.
2016-11-11 14:14xabiermerinoTag Attached: SER-QA
2016-11-17 15:39mario_castelloAssigned ToRetail => mario_castello
2016-11-17 15:39mario_castelloStatusnew => acknowledged
2016-11-21 15:17jonibcIssue Monitored: jonibc
2016-11-21 15:22hgbotCheckin
2016-11-21 15:22hgbotNote Added: 0091703
2016-11-21 15:22hgbotStatusacknowledged => resolved
2016-11-21 15:22hgbotResolutionopen => fixed
2016-11-21 15:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4e4d263892cd16242b701d88322620b19ccf25c4 [^]
2016-11-22 13:14marvintmNote Added: 0091737
2016-11-22 13:14marvintmStatusresolved => new
2016-11-22 13:14marvintmResolutionfixed => open
2016-11-22 14:31mario_castelloStatusnew => acknowledged
2016-11-22 14:31mario_castelloStatusacknowledged => scheduled
2016-11-25 14:43hgbotCheckin
2016-11-25 14:43hgbotNote Added: 0091849
2016-11-25 14:43hgbotStatusscheduled => resolved
2016-11-25 14:43hgbotResolutionopen => fixed
2016-11-25 14:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4e4d263892cd16242b701d88322620b19ccf25c4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/491209862834af66d8bad2ff2857406ad8d9dc62 [^]
2016-11-25 15:10marvintmNote Added: 0091853
2016-11-25 15:10marvintmReview Assigned To => marvintm
2016-11-25 15:10marvintmStatusresolved => closed
2016-11-25 15:10marvintmFixed in Version => RR17Q1

Notes
(0091703)
hgbot   
2016-11-21 15:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4e4d263892cd16242b701d88322620b19ccf25c4
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 18 10:53:55 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4e4d263892cd16242b701d88322620b19ccf25c4 [^]

Fixed issue 34380: Return the BPLocation in CustomerLoader class and CustomerAddrLoader class

---
M src/org/openbravo/retail/posterminal/CustomerAddrLoader.java
M src/org/openbravo/retail/posterminal/CustomerLoader.java
---
(0091737)
marvintm   
2016-11-22 13:14   
Changes in CustomerAddrLoader are correct. However, changes in CustomerLoader are not needed, and they create problems with the incoming refactor of the Customer selector, as now it will be possible to create two addresses while creating a new customer, so the changes in CustomerLoader should be reverted.
(0091849)
hgbot   
2016-11-25 14:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 491209862834af66d8bad2ff2857406ad8d9dc62
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Nov 22 07:48:11 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/491209862834af66d8bad2ff2857406ad8d9dc62 [^]

Fixed issue 0034380: [SERQA 2064] CustomerAddrCreationHook always receive location as null.

- Return the Location in createBPartnerAddr function instead of null
- Return the Location in editBPartnerAddr function instead of null

---
M src/org/openbravo/retail/posterminal/CustomerAddrLoader.java
---
(0091853)
marvintm   
2016-11-25 15:10   
Just for reference: before applying this last change, the previous changes were reverted:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/87c5bfcbc94e [^]