Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034332Openbravo ERP03. Procurement managementpublic2016-10-28 11:132016-12-16 18:38
ngarcia 
rqueralta 
urgentmajoralways
closedfixed 
5
 
3.0PR17Q1 
aferraz
Core
No
0034332: Purchase Order field is empty in Purchase Invoice header when selecting the Goods Receipt in Create Lines From process
Purchase Order field is empty in Purchase Invoice header when selecting the Goods Receipt in Create Lines From process
As group admin role:
   Create a purchase order and a goods receipt
   Go to purchase invoice window and open the create lines from process
   Select the previously created order in Order field and check all its lines
   Check the Purchase Order field is filled in Purchase Invoice header
   Remove the lines and open the create lines from process again
   Select the previously created receipt in Goods Receipt field and check all its lines
   Check the Purchase Order field is empty in Purchase Invoice header. This is not consistent
   Remove the lines
   Go to Goods Receipt window and launch the Generate Invoice From Receipt process
   Check the Purchase Order field is filled in Purchase Invoice header
No tags attached.
related to design defect 0024236 new dmiguelez Purchase Invoice: Purchase Order reference is incorrectly reflected when lines are for different purchase orders 
Issue History
2016-10-28 11:13ngarciaNew Issue
2016-10-28 11:13ngarciaAssigned To => Triage Finance
2016-10-28 11:13ngarciaModules => Core
2016-10-28 11:13ngarciaTriggers an Emergency Pack => No
2016-10-28 11:13ngarciaIssue Monitored: networkb
2016-10-28 11:16ngarciaRelationship addedrelated to 0024236
2016-10-28 11:43ngarciaResolution time => 1479423600
2016-10-28 11:43ngarciaPriorityhigh => urgent
2016-10-28 11:43ngarciaSeverityminor => major
2016-11-03 20:58aferrazAssigned ToTriage Finance => nonofrancisco
2016-11-06 21:15rqueraltaAssigned Tononofrancisco => rqueralta
2016-11-06 21:16rqueraltaStatusnew => scheduled
2016-11-06 21:17rqueraltaNote Added: 0091186
2016-11-07 14:56psanjuanNote Added: 0091200
2016-11-07 15:22psanjuanNote Added: 0091204
2016-11-07 15:23psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13559
2016-11-07 15:24psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13560
2016-11-07 15:30psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13561
2016-11-07 15:36psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13562
2016-11-07 15:42psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13563
2016-11-07 15:42psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13564
2016-11-07 15:49psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13565
2016-11-08 10:00psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13566
2016-11-08 10:02psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13567
2016-11-08 10:09psanjuanNote Edited: 0091204bug_revision_view_page.php?bugnote_id=0091204#r13568
2016-11-08 10:12psanjuanNote Added: 0091221
2016-11-08 13:11hgbotCheckin
2016-11-08 13:11hgbotNote Added: 0091233
2016-11-08 13:11hgbotStatusscheduled => resolved
2016-11-08 13:11hgbotResolutionopen => fixed
2016-11-08 13:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/90f6105a394e6ff0c9d13e5c312af56e57491dfe [^]
2016-11-08 13:12aferrazReview Assigned To => aferraz
2016-11-08 13:12aferrazNote Added: 0091234
2016-11-08 13:12aferrazStatusresolved => closed
2016-11-08 13:12aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092600

Notes
(0091186)
rqueralta   
2016-11-06 21:17   
Test plan:

As F&B International Group Admin

  - Go to Purchase Order window
  Create a Purchase Order and book it

  - Go to Goods Receipt window
  Create a Goods Receipt
  Open the Create Line From and select the Purchase Order created before
  Complete the Goods Receipt document
  - Go to purchase invoice window
  Open the create lines from process
  Select the previously created order in Order field and check all its lines
  Check the Purchase Order field is filled in Purchase Invoice header
  Remove the lines
  Open the create lines from process again
  Select the previously created receipt in Goods Receipt field and check all its lines
  Check the Purchase Order field is filled in Purchase Invoice header.
(0091200)
psanjuan   
2016-11-07 14:56   
Issue verified.
(0091204)
psanjuan   
2016-11-07 15:22   
(edited on: 2016-11-08 10:09)
Test Plan

**Test Case 1 - 01 purchase order + 01 goods receipt + 01 purchase invoice

As F&B International Group Admin role, create a purchase order.
Create a goods receipt by using "Create Lines From" function, select the order.
Select all the lines and Complete the receipt.
Check that purchase order field in the header is filled in Goods Receipt header.

Go to purchase invoice window and create a new one.
Run "Create lines from" process, and select the previously created order in Order field. Check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines and run the "Create lines from" process again.
Select the previously created receipt in Goods Receipt field and check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines once again.

Go to Goods Receipt window and launch the Generate Invoice From Receipt process
Check the Purchase Order field is filled in Purchase Invoice header

** Test Case 2 - 01 purchase order + 02 goods receipt + 01 purchase invoice

As F&B International Group Admin role, create a purchase order for 10 units of a product.
Create first goods receipt by using "Create Lines From" function, select the line but change the quantity to receive to 5. Complete.
Check that purchase order field in the header is filled in Goods Receipt header.

Create second goods receipt by using "Create Lines From" function, select the order, select the line and the quantity remaining.
Check that purchase order field in the header is filled in Goods Receipt header.

Go to purchase invoice window and create a new one.
Run "Create lines from" process, and select the previously created order in Order field. Check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines and run the "Create lines from" process again.
Select first receipt in Goods Receipt field and check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines once again and run the "Create lines from" process again.
Select second receipt in Goods Receipt field and check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Repeat same test, this time do not removing the lines but invoicing the two receipts within the same invoice.

Check the Purchase Order field is filled in Purchase Invoice header.

** Test Case 3 - 02 purchase orders + 01 goods receipt + 01 purchase invoice

As F&B International Group Admin role, create a purchase order for 10 units of a product.

Create a second purchase order for 5 units of a product.

Create a goods receipt by using "Create Lines From" function, select both orders within the same receipt. Complete it.

Check that purchase order field in the header is NOT filled in Goods Receipt header, as it is not unique, but in Goods Receipt Lines tab.

Go to purchase invoice window and create a new one.
Run "Create lines from" process, and select one of the previously created order in Order field. Check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines and run the "Create lines from" process again.
Select second order and check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines once again and run the "Create lines from" process again.
Select the receipt in Goods Receipt field and check all its lines.

Check the Purchase Order field is NOT filled in Purchase Invoice header, as in regards to the receipts is not unique, but in Purchase Invoice Lines tab.

** Test Case 4 - 02 purchase order + 02 goods receipt + 01 purchase invoice

As F&B International Group Admin role, create a purchase order for 10 units of a product.

Create a second purchase order for 15 units of another product.

Create a goods receipt by using "Create Lines From" function, select first order and change movement quantity to 5. Repeat same step for the second order and change movement quantity to 10. Complete this first receipt.

Create a second goods receipt by using "Create Lines From" function, select first order and receipt remaining quantity. Repeat same step for the second order, therefore remaining quantity is receipt. Complete this second receipt.

Check that purchase order field in the header is NOT filled in Goods Receipt header, as it is not unique, but in Goods Receipt Lines tab.


Go to purchase invoice window and create a new one.

Run "Create lines from" process, and select one of the previously created orders in Order field. Check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines and run the "Create lines from" process again.
Select second order and check all its lines.

Check the Purchase Order field is filled in Purchase Invoice header.

Remove invoice lines once again and run the "Create lines from" process again.
Select first receipt in Goods Receipt field and check all its lines.

Check the Purchase Order field is NOT filled in Purchase Invoice header, as in regards to the receipts is not unique, but in Purchase Invoice Lines tab.

Remove invoice lines once again and run the "Create lines from" process again.
Select second receipt in Goods Receipt field and check all its lines.

Check the Purchase Order field is NOT filled in Purchase Invoice header, as in regards to the receipts is not unique, but in Purchase Invoice Lines tab.

Remove invoice lines once again.

Go to first Goods Receipt window and launch the Generate Invoice From Receipt process

Check the Purchase Order field is NOT filled in Purchase Invoice header, but in the purchase invoice lines as corresponding.

Go to second Goods Receipt window and launch the Generate Invoice From Receipt process

Check the Purchase Order field is NOT filled in Purchase Invoice header, but in the purchase invoice lines as corresponding.


Repeat test plan above for sales cycle.

(0091221)
psanjuan   
2016-11-08 10:12   
Test plan above verified.

Issue can be code reviewed and closed.
(0091233)
hgbot   
2016-11-08 13:11   
Repository: erp/devel/pi
Changeset: 90f6105a394e6ff0c9d13e5c312af56e57491dfe
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Nov 08 13:07:05 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/90f6105a394e6ff0c9d13e5c312af56e57491dfe [^]

Fixes issue 34332: Purchase Order field is empty in Purchase Invoice header

Purchase Order field was empty in Purchase Invoice header when selecting the Goods Receipt
in Create Lines From process, because the Purchase Order Id of Goods Receipt was not take into account to fill
Purchase Order field in Purchase Invoice header. Now the Purchase Order Id of Goods Receipt is retrieved to fill this field.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
---
(0091234)
aferraz   
2016-11-08 13:12   
Code review + Testing OK
(0092600)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test