Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034315Retail ModulesWeb POSpublic2016-10-27 12:512016-11-24 17:12
Reporterplujan 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034315: [RR16Q4] Split lines pop up does not allow to write certain number of lines to split
DescriptionThe "number of lines" field does not work well when using the keyboard. For example, if I have a quantity of 11, I am not allowed to write "10". See steps.
Steps To Reproduce1. Using a ticket with a product line of 11 items, edit the line and click the "Split" button.
2. The pop up is shown, two lines is the default.
3. I want to have 1 line of two items and 9 lines of one, so I focus the Number of Lines field and try to write "10".
4. Result of typing "10" is "11". This is because the first "1", is being replaced by a "2", and then the "0" forms a "20" which is also replaced by the maximum of "11".
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034418RR16Q4 closed jorge-garcia [RR16Q4] Split lines pop up does not allow to write certain number of lines to split 
Attached Filesdiff posterminal_issue_0034315.diff (1,001) 2016-10-31 11:03
https://issues.openbravo.com/file_download.php?file_id=9996&type=bug
diff mobilecore_issue_0034315.diff (922) 2016-10-31 11:04
https://issues.openbravo.com/file_download.php?file_id=9997&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-27 12:51plujanNew Issue
2016-10-27 12:51plujanAssigned To => Retail
2016-10-27 12:51plujanOBNetwork customer => No
2016-10-27 12:51plujanTriggers an Emergency Pack => No
2016-10-31 11:03ebecerraFile Added: posterminal_issue_0034315.diff
2016-10-31 11:04ebecerraFile Added: mobilecore_issue_0034315.diff
2016-11-03 11:42jorge-garciaStatusnew => scheduled
2016-11-03 11:42jorge-garciaAssigned ToRetail => jorge-garcia
2016-11-07 17:39hgbotCheckin
2016-11-07 17:39hgbotNote Added: 0091206
2016-11-07 17:39hgbotCheckin
2016-11-07 17:39hgbotNote Added: 0091209
2016-11-07 17:39hgbotStatusscheduled => resolved
2016-11-07 17:39hgbotResolutionopen => fixed
2016-11-07 17:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/01c2f6d968e25b2d30bd6f88fa0a92be9a378334 [^]
2016-11-07 17:41hgbotCheckin
2016-11-07 17:41hgbotNote Added: 0091213
2016-11-08 10:58jorge-garciaNote Added: 0091229
2016-11-08 10:58jorge-garciaStatusresolved => new
2016-11-08 10:58jorge-garciaResolutionfixed => open
2016-11-08 10:58jorge-garciaStatusnew => scheduled
2016-11-08 10:59jorge-garciaStatusscheduled => resolved
2016-11-08 10:59jorge-garciaFixed in Version => RR17Q1
2016-11-08 10:59jorge-garciaResolutionopen => fixed
2016-11-11 11:39plujanSummary[RR16Q3] Split lines pop up does not allow to write certain number of lines to split => [RR16Q4] Split lines pop up does not allow to write certain number of lines to split
2016-11-24 16:43migueldejuanaReview Assigned To => migueldejuana
2016-11-24 17:12migueldejuanaNote Added: 0091788
2016-11-24 17:12migueldejuanaStatusresolved => closed

Notes
(0091206)
hgbot   
2016-11-07 17:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d90a5054ba752acaf5c9eeb632de09c0fbb81cbc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 03 15:14:45 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d90a5054ba752acaf5c9eeb632de09c0fbb81cbc [^]

Related to issue 34315: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

Fix the NaN problem.

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
---
(0091209)
hgbot   
2016-11-07 17:39   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 01c2f6d968e25b2d30bd6f88fa0a92be9a378334
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 03 15:07:37 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/01c2f6d968e25b2d30bd6f88fa0a92be9a378334 [^]

Fixed issue 34315: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

The problem was that the value “1” is not allowed in the split lines pop up
(it doesn0t make sense). The pop up changed dynamically the value to “2”.

The solution is to not change dynamically that value and change it only when
the user confirms the value.

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---
(0091213)
hgbot   
2016-11-07 17:41   
Repository: tools/automation/pi-mobile
Changeset: c2f45f1df3bbc4b6c0f0d32d1fb4174829af088e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 07 09:08:42 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c2f45f1df3bbc4b6c0f0d32d1fb4174829af088e [^]

Verifies issue 34315: [RR16Q3] Split lines pop up does not allow to write
certain number of lines to split

Added test I34315_AllowToPutNumberOneInNumberOfLines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34315_AllowToPutNumberOneInNumberOfLines.java
---
(0091229)
jorge-garcia   
2016-11-08 10:58   
Create backport for 16Q4
(0091788)
migueldejuana   
2016-11-24 17:12   
Tested and reviewed 2cb39d0f8890