Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034314Retail ModulesWeb POSpublic2016-10-27 12:422016-11-16 17:37
Reporterplujan 
Assigned Tojorge-garcia 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034314: [RR16Q4] Not a number message is shown in Split lines pop up
DescriptionWhen splitting lines, if a quantity for a line is left blank, a NaN message is shown in both header fields "Split Quantity" and "Difference". See steps.
Steps To Reproduce1. Create a ticket and add a product with a quantity of two or more
2. Edit the line and click "split" button
3. The split lines pop up shows up. By default it suggests to split in two lines.
4. Go to line 1 quantity and select the value by tapping it.
5. Open the keyboard and type a letter. Note the letter is erased, leaving the field blank.
6. Go to line 2 quantity. Note the NaN fields as shown in attached screenshot.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034419RR16Q4 closed jorge-garcia [RR16Q4] Not a number message is shown in Split lines pop up 
related to defect 0034477 new Retail [RR16Q4] When splitting lines, any field left blank it is counted as 1 creating wrong quantities 
Attached Filespng SplitLinesNaN.png (31,991) 2016-10-27 12:42
https://issues.openbravo.com/file_download.php?file_id=9967&type=bug
png

diff posterminal_issue_0034314.diff (653) 2016-10-31 10:55
https://issues.openbravo.com/file_download.php?file_id=9995&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-27 12:42plujanNew Issue
2016-10-27 12:42plujanAssigned To => Retail
2016-10-27 12:42plujanFile Added: SplitLinesNaN.png
2016-10-27 12:42plujanTriggers an Emergency Pack => No
2016-10-27 13:23plujanSummaryNot a number message is shown in Split lines pop up => [RR16Q3] Not a number message is shown in Split lines pop up
2016-10-31 09:55ebecerraFile Added: issue_0034314.diff
2016-10-31 10:54ebecerraFile Deleted: issue_0034314.diff
2016-10-31 10:55ebecerraFile Added: posterminal_issue_0034314.diff
2016-11-03 11:42jorge-garciaStatusnew => scheduled
2016-11-03 11:42jorge-garciaAssigned ToRetail => jorge-garcia
2016-11-07 17:39hgbotCheckin
2016-11-07 17:39hgbotNote Added: 0091207
2016-11-07 17:39hgbotStatusscheduled => resolved
2016-11-07 17:39hgbotResolutionopen => fixed
2016-11-07 17:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df58608d3753c5e0590655215b3f5dc9916e739b [^]
2016-11-07 17:41hgbotCheckin
2016-11-07 17:41hgbotNote Added: 0091212
2016-11-08 10:59jorge-garciaNote Added: 0091230
2016-11-08 10:59jorge-garciaStatusresolved => new
2016-11-08 10:59jorge-garciaResolutionfixed => open
2016-11-08 10:59jorge-garciaStatusnew => scheduled
2016-11-08 10:59jorge-garciaStatusscheduled => resolved
2016-11-08 10:59jorge-garciaFixed in Version => RR17Q1
2016-11-08 10:59jorge-garciaResolutionopen => fixed
2016-11-11 11:39plujanSummary[RR16Q3] Not a number message is shown in Split lines pop up => [RR16Q4] Not a number message is shown in Split lines pop up
2016-11-11 14:58plujanRelationship addedrelated to 0034477
2016-11-16 17:37migueldejuanaNote Added: 0091609
2016-11-16 17:37migueldejuanaStatusresolved => closed

Notes
(0091207)
hgbot   
2016-11-07 17:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: df58608d3753c5e0590655215b3f5dc9916e739b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 03 15:17:28 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df58608d3753c5e0590655215b3f5dc9916e739b [^]

Fixed issue 34314: [RR16Q3] Not a number message is shown in Split lines
pop up

Fix the NaN problem when the user enters a character in the qty of a line..

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
---
(0091212)
hgbot   
2016-11-07 17:41   
Repository: tools/automation/pi-mobile
Changeset: fa7af6b8c656d254991a7fd9821e755ceb5d5bff
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 07 09:08:16 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fa7af6b8c656d254991a7fd9821e755ceb5d5bff [^]

Verifies issue 34314: [RR16Q3] Not a number message is shown in Split lines
pop up

Added test I34314_ProblemWithNonNumericValues.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34314_ProblemWithNonNumericValues.java
---
(0091230)
jorge-garcia   
2016-11-08 10:59   
Create backport for 16Q4
(0091609)
migueldejuana   
2016-11-16 17:37   
Tested and reviewed in 795a217b6a23