Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034309Retail ModulesWeb POSpublic2016-10-27 08:392016-11-22 18:52
Reporterjorgewederago 
Assigned Tojorgewederago 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034309: We have found that the object keyboard was sent through several calls in WebPOS
DescriptionWe have found that the call findProductByBarcode was passing the keyboard object. A new object was creted when RFID was created and, in some cases, it was overwritting the keyboard object. This behaviour was causing some issues when we were trying to add a new parameter to addProductToReceipt.
Steps To ReproduceReview the current parameters in findProductByBarcode in ob.keboard.js, there are three parameters in that call. In keyboard.js findProductByBarCode was receiving 3 parameters but the third parameter was overwritten by attrs.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-27 08:39jorgewederagoNew Issue
2016-10-27 08:39jorgewederagoAssigned To => jorgewederago
2016-10-27 08:39jorgewederagoOBNetwork customer => Yes
2016-10-27 08:39jorgewederagoTriggers an Emergency Pack => No
2016-10-27 08:40jorgewederagoReview Assigned To => marvintm
2016-10-27 09:37hgbotCheckin
2016-10-27 09:37hgbotNote Added: 0090941
2016-10-27 09:37hgbotStatusnew => resolved
2016-10-27 09:37hgbotResolutionopen => fixed
2016-10-27 09:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4cdf9b3e7cbcfcbc5f01392538db21c5bbee3106 [^]
2016-10-27 09:37hgbotCheckin
2016-10-27 09:37hgbotNote Added: 0090942
2016-10-27 09:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4cdf9b3e7cbcfcbc5f01392538db21c5bbee3106 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b2d89723ef11c0731140c20bcc67e8e7c7408218 [^]
2016-10-27 11:24hgbotCheckin
2016-10-27 11:24hgbotNote Added: 0090947
2016-11-22 18:52marvintmStatusresolved => closed
2016-11-22 18:52marvintmFixed in Version => RR17Q1

Notes
(0090941)
hgbot   
2016-10-27 09:37   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4cdf9b3e7cbcfcbc5f01392538db21c5bbee3106
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Thu Oct 27 09:35:54 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4cdf9b3e7cbcfcbc5f01392538db21c5bbee3106 [^]

Fixed issue 34309: Keyboard object was overwritten in findProductByBarcode

A new parameter has beend added to findProductByBarcode as well as to addProductToReceipt

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0090942)
hgbot   
2016-10-27 09:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b2d89723ef11c0731140c20bcc67e8e7c7408218
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Thu Oct 27 09:36:07 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b2d89723ef11c0731140c20bcc67e8e7c7408218 [^]

Fixed issue 34309: Keyboard object was overwritten in findProductByBarcode

A new parameter has beend added to findProductByBarcode to avoid the overwritting.
This new parameter is sent in the callback in order to be able to set all the information in addProductToReceipt

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0090947)
hgbot   
2016-10-27 11:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a14a08ae6bc2638607fd9a9126956909f225beb4
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Thu Oct 27 11:23:23 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a14a08ae6bc2638607fd9a9126956909f225beb4 [^]

Related to issue 34309:Parameter added to barcodeActionHandler in rfidWebsocket

The new parameter has been added to meet the changes on findProductByBarcode

---
M web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js
---