Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034307Retail ModulesWeb POSpublic2016-10-26 18:282016-11-25 09:35
Reporterplujan 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034307: [RR16Q4] Splitting several many lines results in a poor system performance
DescriptionSplit lines functionality cannot be used to split big amounts, it will take too long to finish and might result in a system's inconsistent state. See steps.
Steps To ReproduceScenario A (expected flow):
Login into the webPOS and create a line for a product.
Click edit and change the quantity to 3.
Click the "split" button and get three lines of one product.
Pay and complete the sales flow.

Scenario B:
Login into the webPOS and create a line for a product.
Click edit and change the quantity to 100.
Click the "split" button and make 100 lines of one item each.
Note that the first line keeps the total amount and the rest of the lines are slowly added for a line-total of 0.00. (Note: in test environment around seven seconds by line, making a total of 700 secs waiting time)
Since it is taking too long, I let it finish while doing some other thing, so I click the New button to create a new order. An exception is shown (see attached screenshot)

Scenario C:
If after scenario B I return to the order, the process has stopped (no new lines were added). If I pay this order, the exception is shown again and the system remains in a greyed-out screen.
Proposed Solution
Additional Information
TagsPerformance
Relationships
depends on backport 0034417RR16Q4 closed jorge-garcia [RR16Q4] Splitting several many lines results in a poor system performance 
Attached Filespng SpliLinesException.png (79,445) 2016-10-26 18:28
https://issues.openbravo.com/file_download.php?file_id=9962&type=bug
png

diff posterminal_issue_0034307.diff (746) 2016-10-31 11:25
https://issues.openbravo.com/file_download.php?file_id=9998&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-26 18:28plujanNew Issue
2016-10-26 18:28plujanAssigned To => Retail
2016-10-26 18:28plujanFile Added: SpliLinesException.png
2016-10-26 18:28plujanTriggers an Emergency Pack => No
2016-10-26 18:28plujanSummary[RR16Q3] Splitting too many lines results in a poor system performance => [RR16Q3] Splitting several many lines results in a poor system performance
2016-10-27 11:13plujanTag Attached: Performance
2016-10-31 11:25ebecerraFile Added: posterminal_issue_0034307.diff
2016-11-03 10:27jorge-garciaStatusnew => scheduled
2016-11-03 10:27jorge-garciaAssigned ToRetail => jorge-garcia
2016-11-07 17:39hgbotCheckin
2016-11-07 17:39hgbotNote Added: 0091208
2016-11-07 17:39hgbotStatusscheduled => resolved
2016-11-07 17:39hgbotResolutionopen => fixed
2016-11-07 17:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ca6025a511711faf878e589d824792d5ae9cd7aa [^]
2016-11-07 17:41hgbotCheckin
2016-11-07 17:41hgbotNote Added: 0091210
2016-11-07 17:41hgbotCheckin
2016-11-07 17:41hgbotNote Added: 0091211
2016-11-08 10:57jorge-garciaNote Added: 0091228
2016-11-08 10:57jorge-garciaStatusresolved => new
2016-11-08 10:57jorge-garciaResolutionfixed => open
2016-11-08 10:57jorge-garciaStatusnew => scheduled
2016-11-08 10:58jorge-garciaStatusscheduled => resolved
2016-11-08 10:58jorge-garciaFixed in Version => RR17Q1
2016-11-08 10:58jorge-garciaResolutionopen => fixed
2016-11-11 11:38plujanSummary[RR16Q3] Splitting several many lines results in a poor system performance => [RR16Q4] Splitting several many lines results in a poor system performance
2016-11-24 16:43migueldejuanaReview Assigned To => migueldejuana
2016-11-25 09:35migueldejuanaNote Added: 0091812
2016-11-25 09:35migueldejuanaStatusresolved => closed

Notes
(0091208)
hgbot   
2016-11-07 17:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ca6025a511711faf878e589d824792d5ae9cd7aa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 03 17:58:31 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ca6025a511711faf878e589d824792d5ae9cd7aa [^]

Fixed issue 34307: [RR16Q3] Splitting several many lines results in a poor
system performance

There some change to be mentioned:
* Change the limit of lines that could be created in split lines from 100 to 20.
* Disable New and Delete buttons in Point-Of-Sale window during the adding
of product from split lines.
* Use the functionality of Ob.Dal.usingCache to search the related services of
a product.
* Added a name unique name to the warning message component from the split
lines pop up.

---
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091210)
hgbot   
2016-11-07 17:41   
Repository: tools/automation/pi-mobile
Changeset: 56059ce0db2047a075cb19575625dfe2608ecbaa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 03 17:54:22 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/56059ce0db2047a075cb19575625dfe2608ecbaa [^]

Related to issue 34307: [RR16Q3] Splitting several many lines results in a poor
system performance

Added some new TestIds for Split Lines PopUp.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
---
(0091211)
hgbot   
2016-11-07 17:41   
Repository: tools/automation/pi-mobile
Changeset: 0c906fbe99fb4f5c94a180a6b083d02b74ecd7cb
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 07 09:07:28 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0c906fbe99fb4f5c94a180a6b083d02b74ecd7cb [^]

Verifies issue 34307: [RR16Q3] Splitting several many lines results in a poor
system performance

Added test I34307_PerformanceTestWithSplitOfTwentyLines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34307_PerformanceTestWithSplitOfTwentyLines.java
---
(0091228)
jorge-garcia   
2016-11-08 10:57   
Create backport to 16Q4
(0091812)
migueldejuana   
2016-11-25 09:35   
Tested and reviewed