Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034296Retail ModulesWeb POSpublic2016-10-25 21:482016-11-14 09:27
ReporterOsmany 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034296: [SER-QA 1937] It is not posible return a product when we changed several configurations.
DescriptionIt is not posible return a product when we changed several configurations. Only reproducible with remote for customer preference activated.
Steps To ReproduceLog in ERP
- Set customer the remote preferences.
Go to Product window. Search "Avalanche transceiver" product.
- Set Allow Anonymous Sale as N

Log in Web POS.
-Assing 'Arturo Montoro' customer to this receipt.
-Add "Avalanche transceiver" product to receipt.
-Pay.
-Menu. Verified Returns.
-Search receipt payed.
-Select line to return. Press apply button.
-Realize that appear an error: "Anonymous Sale is not allowed for selected product. Change business partner to be able to add this product". That is wrong. Because the business partner changed.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-25 21:48OsmanyNew Issue
2016-10-25 21:48OsmanyAssigned To => mario_castello
2016-10-25 21:48OsmanyOBNetwork customer => Yes
2016-10-25 21:48OsmanyResolution time => 1477954800
2016-10-25 21:48OsmanyTriggers an Emergency Pack => No
2016-10-25 21:48OsmanyTag Attached: SER-QA
2016-10-26 09:07adrianromeroResolution time1477954800 => 1478559600
2016-10-26 09:07adrianromeroSummaryIt is not posible return a product when we changed several configurations. => [SER-QA 1937] It is not posible return a product when we changed several configurations.
2016-10-26 15:38mario_castelloStatusnew => acknowledged
2016-10-27 17:13mario_castelloStatusacknowledged => scheduled
2016-10-31 16:46hgbotCheckin
2016-10-31 16:46hgbotNote Added: 0091022
2016-10-31 16:46hgbotStatusscheduled => resolved
2016-10-31 16:46hgbotResolutionopen => fixed
2016-10-31 16:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d4fc3564a20503450719e926826a6638fae32a1 [^]
2016-10-31 16:46hgbotCheckin
2016-10-31 16:46hgbotNote Added: 0091023
2016-10-31 16:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d4fc3564a20503450719e926826a6638fae32a1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/1a632bf97e3b1e03b37ebaf67dd65a14dda3dace [^]
2016-10-31 16:49hgbotCheckin
2016-10-31 16:49hgbotNote Added: 0091024
2016-10-31 16:49hgbotCheckin
2016-10-31 16:49hgbotNote Added: 0091025
2016-11-01 08:54marvintmReview Assigned To => marvintm
2016-11-01 08:54marvintmStatusresolved => closed
2016-11-01 08:54marvintmFixed in Version => RR17Q1
2016-11-02 12:07asiermartirenaNote Added: 0091057
2016-11-03 16:13marvintmNote Added: 0091083
2016-11-03 16:13marvintmStatusclosed => new
2016-11-03 16:13marvintmResolutionfixed => open
2016-11-03 16:13marvintmFixed in VersionRR17Q1 =>
2016-11-03 16:13marvintmStatusnew => scheduled
2016-11-03 23:28hgbotCheckin
2016-11-03 23:28hgbotNote Added: 0091156
2016-11-03 23:28hgbotStatusscheduled => resolved
2016-11-03 23:28hgbotResolutionopen => fixed
2016-11-03 23:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/1a632bf97e3b1e03b37ebaf67dd65a14dda3dace [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5239e0b438b948d599cd4b600fbc2b8148bb44b8 [^]
2016-11-14 09:27marvintmStatusresolved => closed

Notes
(0091022)
hgbot   
2016-10-31 16:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2d4fc3564a20503450719e926826a6638fae32a1
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Oct 28 08:50:45 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d4fc3564a20503450719e926826a6638fae32a1 [^]

Fixed issue 34296: Added function finishSaveData to execute the callback to the end this function

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091023)
hgbot   
2016-10-31 16:46   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 1a632bf97e3b1e03b37ebaf67dd65a14dda3dace
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Oct 27 10:26:52 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/1a632bf97e3b1e03b37ebaf67dd65a14dda3dace [^]

Fixed issue 34296: Call function createOrderLines when finish the function setBPandLoc.

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0091024)
hgbot   
2016-10-31 16:49   
Repository: tools/automation/pi-mobile
Changeset: 2c8edfc99838b16577cd08b93d1c16cc53da5727
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Oct 27 11:17:42 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2c8edfc99838b16577cd08b93d1c16cc53da5727 [^]

Related to issue 34296: Added automated test I34296_VerifiedReturnsAndRemoteCustomer

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I34296_VerifiedReturnsAndRemoteCustomer.java
---
(0091025)
hgbot   
2016-10-31 16:49   
Repository: tools/automation/pi-mobile
Changeset: 1988198c46327577b4ba405a54c9472084fdabb4
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Oct 27 11:25:11 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1988198c46327577b4ba405a54c9472084fdabb4 [^]

Related to issue 34296: Fixed test I32898_VerifiedReturnsAndRemoteCustomer

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I32898_VerifiedReturnsAndRemoteCustomer.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32898_VerifiedReturnsAndRemoteCustomer.java
---
(0091057)
asiermartirena   
2016-11-02 12:07   
In the returns module part, be aware that a piece of code has been moved which was executed after this code:

currentDate.setHours(0);
currentDate.setMinutes(0);
currentDate.setSeconds(0);
currentDate.setMilliseconds(0);

Now the code moved can be executed before it and shouldn't.
This lines must be moved with the previous ones.
(0091083)
marvintm   
2016-11-03 16:13   
As Asier mentions, those lines are missing in the diff and they should be moved to the proper place.
(0091156)
hgbot   
2016-11-03 23:28   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 5239e0b438b948d599cd4b600fbc2b8148bb44b8
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Nov 03 16:27:09 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5239e0b438b948d599cd4b600fbc2b8148bb44b8 [^]

Fixed issue 34296: Moved a piece of code to execute in a correct place

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---