Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034292Retail ModulesWeb POSpublic2016-10-25 17:462016-12-21 12:37
Reportermtaal 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034292: [BUT Issues: 1861] Pay Open Tickets is slow and UI stalls
DescriptionWhen I do pay open tickets I noticed that the UI stalls before the ticket is sent to the server and after it.

The best visualized is this when setting Synchronized Mode preference to Y.
Steps To ReproduceCreate 2 open tickets
Open the developer console log
Do pay open tickets
Notice that almost 1000 times the same message is printed
Pay button is disabled; {"isSynchronized":false,"isToolbarEnabled":true,"isDisabledRequest":false}; line: Object.disabledChanged

Put a breakpoint in the right place to see the stacktrace life, the disableChanged method is called from several places.
Proposed SolutionPrevent the 'expensive' disableChanged method from being called. Find the root cause why 1000s of javascript calls are needed.
Additional Information
Tagsser, SER-QA
Relationships
related to defect 0034118 closed mtaal [STORE SERVER] Pay open tickets functionality does not work correctly in multiserver (online/offline) using synchronized mode. 
has duplicate defect 0029693 closed jorge-garcia To use "Pay Open Tickets" feature with several tickets induces POS to get stuck 
related to design defect 0034397 acknowledged Retail [RR16Q4] Pay Open Tickets has a bad performance in certain environments. It induces a situation where a ticket can be completed 
causes defect 0035034 closed mario_castello [RR17Q1] Remaining to Pay totals don't update when changing the amounts to layaway in the Pay Open Tickets window 
Attached Fileslog store1.openbravo.com-1477408775536.log (777,359) 2016-10-25 17:47
https://issues.openbravo.com/file_download.php?file_id=9954&type=bug
png Selection_046.png (290,767) 2016-10-25 17:47
https://issues.openbravo.com/file_download.php?file_id=9955&type=bug
png Selection_045.png (70,618) 2016-10-25 17:47
https://issues.openbravo.com/file_download.php?file_id=9956&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-10-25 17:46mtaalNew Issue
2016-10-25 17:46mtaalAssigned To => Retail
2016-10-25 17:46mtaalTriggers an Emergency Pack => No
2016-10-25 17:46mtaalRelationship addedrelated to 0034118
2016-10-25 17:47mtaalFile Added: store1.openbravo.com-1477408775536.log
2016-10-25 17:47mtaalFile Added: Selection_046.png
2016-10-25 17:47mtaalFile Added: Selection_045.png
2016-10-26 10:07daniOpenbravoIssue Monitored: daniOpenbravo
2016-10-26 10:07daniOpenbravoTag Attached: ser
2016-10-26 10:07daniOpenbravoTag Attached: SER-QA
2016-10-26 10:08daniOpenbravoSummaryPay Open Tickets is slow and UI stalls => [BUT Issues: 1861] Pay Open Tickets is slow and UI stalls
2016-11-09 18:22xabiermerinoResolution time => 1479250800
2016-11-11 13:35SandrahuguetRelationship addedrelated to 0034397
2016-11-25 15:14marvintmResolution time1479250800 => 1481151600
2016-12-12 11:58marvintmTypedefect => design defect
2016-12-12 11:58marvintmResolution time1481151600 =>
2016-12-12 12:11marvintmRegression date => 2016-08-12
2016-12-12 12:11marvintmTypedesign defect => defect
2016-12-12 12:13marvintmResolution time => 1481151600
2016-12-12 12:13marvintmRegression date2016-08-12 =>
2016-12-13 09:30marvintmStatusnew => scheduled
2016-12-13 09:30marvintmAssigned ToRetail => marvintm
2016-12-15 17:19marvintmSeverityminor => major
2016-12-20 13:42jorge-garciaAssigned Tomarvintm => jorge-garcia
2016-12-21 11:23hgbotCheckin
2016-12-21 11:23hgbotNote Added: 0092899
2016-12-21 11:23hgbotStatusscheduled => resolved
2016-12-21 11:23hgbotResolutionopen => fixed
2016-12-21 11:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/365193450d5df02d4bfdc157512d6368547c0879 [^]
2016-12-21 12:37guilleaerReview Assigned To => guilleaer
2016-12-21 12:37guilleaerStatusresolved => closed
2016-12-21 12:37guilleaerFixed in Version => RR17Q1
2017-01-13 13:21marvintmRelationship addedhas duplicate 0029693
2017-01-25 15:15mario_castelloRelationship addedrelated to 0035034
2017-01-25 16:54mario_castelloRelationship deletedrelated to 0035034
2017-01-25 16:55mario_castelloRelationship addedcauses 0035034

Notes
(0092899)
hgbot   
2016-12-21 11:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 365193450d5df02d4bfdc157512d6368547c0879
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Dec 20 17:33:12 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/365193450d5df02d4bfdc157512d6368547c0879 [^]

Fixed issue 34292: Pay Open Tickets is slow and UI stalls

Log messages indicates several triggers are being raised by some functionality.

In this case, the origin of the problem was a change listener defined in
multiOrder list. Every time one receipt change, this event was raised.

Now, this change listener has been removed in multiOrders list.

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---