Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034290Retail ModulesQuotationspublic2016-10-25 16:302017-01-13 20:01
Reporterrbianchini 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR16Q2.3 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR16Q2.3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e62ef3273a5a [^]
Triggers an Emergency PackNo
Summary0034290: Error when create anorder from a quotation in some cases
DescriptionIf the client is configured to not allow negative stock, and the Web POS stock validation module is installed, when the cashier creates an order from a quotation that contains services, The message "Not enough stock" is shown and the order is not created. But if you add a service in an order, the normal flow is executed.
This error is reproduced in 16Q2.3, but it cannot be reproduced in 16Q1.3
Steps To Reproduce1 - Install the module "Web POS stock validation"
2 - Configure the client to not allow negative stock
3 - Create a Product with product type "Service"
4 - Log in web pos and create a new Quotation with the product created in previous step
5 - In the menu, click the entry: Create Sales Order
6 - Firm the cuotation and create the sales order
7 - The message "Not enough stock" is shown (wrong, becouse a service is not stocked)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0032368 closed mario_castello Reactivation of Quotations does not recheck stock 
has duplicate defect 0034954 closed mario_castello Error when create an order from a quotation with services and Stock Validation module 
Attached Filesdiff fixStockValidation1.1.305.diff (6,174) 2016-11-18 15:55
https://issues.openbravo.com/file_download.php?file_id=10076&type=bug
diff fixStockValidation1.1.500.diff (9,088) 2017-01-13 20:01
https://issues.openbravo.com/file_download.php?file_id=10305&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-25 16:30rbianchiniNew Issue
2016-10-25 16:30rbianchiniAssigned To => Retail
2016-10-25 16:30rbianchiniResolution time => 1479178800
2016-10-25 16:30rbianchiniRegression level => Production - Confirmed Stable
2016-10-25 16:30rbianchiniRegression introduced in release => RR16Q2.3
2016-10-25 16:30rbianchiniTriggers an Emergency Pack => No
2016-10-25 18:01mario_castelloAssigned ToRetail => mario_castello
2016-10-25 20:06mario_castelloStatusnew => acknowledged
2016-10-25 20:43mario_castelloStatusacknowledged => scheduled
2016-10-26 23:49hgbotCheckin
2016-10-26 23:49hgbotNote Added: 0090933
2016-10-27 00:11hgbotCheckin
2016-10-27 00:11hgbotNote Added: 0090934
2016-10-27 00:11hgbotStatusscheduled => resolved
2016-10-27 00:11hgbotResolutionopen => fixed
2016-10-27 00:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/725abce813b2ab6f9776371f7caac52530daa7cf [^]
2016-11-04 11:39marvintmNote Added: 0091169
2016-11-04 11:39marvintmStatusresolved => new
2016-11-04 11:39marvintmResolutionfixed => open
2016-11-04 11:39marvintmStatusnew => scheduled
2016-11-07 23:14hgbotCheckin
2016-11-07 23:14hgbotNote Added: 0091215
2016-11-07 23:14hgbotStatusscheduled => resolved
2016-11-07 23:14hgbotResolutionopen => fixed
2016-11-07 23:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/725abce813b2ab6f9776371f7caac52530daa7cf [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/0514ba64174fb31ff45e85f9e459dbb662bec0f2 [^]
2016-11-11 14:06guilleaerResolution time1479178800 => 1479164400
2016-11-11 14:06guilleaerRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e62ef3273a5a [^]
2016-11-11 16:47guilleaerReview Assigned To => guilleaer
2016-11-11 16:47guilleaerStatusresolved => closed
2016-11-11 16:47guilleaerFixed in Version => RR17Q1
2016-11-14 15:20rbianchiniNote Added: 0091464
2016-11-18 15:55mario_castelloFile Added: fixStockValidation1.1.305.diff
2016-11-28 19:52dmitry_mezentsevRelationship addedcaused by 0032368
2016-12-30 15:34rbianchiniNote Added: 0093081
2017-01-13 18:32mario_castelloRelationship addedrelated to 0034954
2017-01-13 18:33mario_castelloRelationship deletedrelated to 0034954
2017-01-13 19:40mario_castelloFile Added: 34290fixStockValidation1.1.500.diff
2017-01-13 19:41mario_castelloRelationship addedhas duplicate 0034954
2017-01-13 20:01mario_castelloFile Deleted: 34290fixStockValidation1.1.500.diff
2017-01-13 20:01mario_castelloFile Added: fixStockValidation1.1.500.diff

Notes
(0090933)
hgbot   
2016-10-26 23:49   
Repository: tools/automation/pi-mobile
Changeset: e59ae827dabebdc1a79fe6ac41b48b318ef42128
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Oct 26 15:49:03 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e59ae827dabebdc1a79fe6ac41b48b318ef42128 [^]

Related to issue 34290: Added automated test I34290_OrderFromQuotationWithServiceNotAllowNegativeStock

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/I34290_OrderFromQuotationWithServiceNotAllowNegativeStock.java
---
(0090934)
hgbot   
2016-10-27 00:11   
Repository: erp/pmods/org.openbravo.retail.stockvalidation
Changeset: 725abce813b2ab6f9776371f7caac52530daa7cf
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Oct 26 16:11:29 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/725abce813b2ab6f9776371f7caac52530daa7cf [^]

Fixed issue 34290: Added validation for not consulting the stock of the products that marked as not stocked

---
M src/org/openbravo/retail/stockvalidation/OrderFromQuotationStockChecker.java
M web/org.openbravo.retail.stockvalidation/js/modals.js
---
(0091169)
marvintm   
2016-11-04 11:39   
The general idea of the fix (not to check stock in case the product is not stockable) is correct, but the way this is implemented is not the most efficient.

Instead of doing the request to the backend and then checking the property there, the request could be avoided entirely, which would save us quite a bit of overhead, and would also improve perceived performance by the user.
(0091215)
hgbot   
2016-11-07 23:14   
Repository: erp/pmods/org.openbravo.retail.stockvalidation
Changeset: 0514ba64174fb31ff45e85f9e459dbb662bec0f2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 07 15:22:34 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/0514ba64174fb31ff45e85f9e459dbb662bec0f2 [^]

Fixed issue 34290: Added validation for the products that have been marked as not stocked.
Prevent to execute the stock validation process in the backend for this products.

---
M web/org.openbravo.retail.stockvalidation/js/modals.js
---
(0091464)
rbianchini   
2016-11-14 15:20   
Hello,

Can i have a patch for Openbravo 3.0 PR16Q2.3, please?
(0093081)
rbianchini   
2016-12-30 15:34   
Hello,

Can i have a patch for Openbravo 3.0 RR16Q3.4, please?