0034273: Payment schedule due date should be correctly set for invoices based on payment terms

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034273

Retail Modules

Web POS

public

2016-10-21 17:13

Reporter

guilleaer

Assigned To

Retail

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0034273: Payment schedule due date should be correctly set for invoices based on payment terms

Description

Payment schedule due date should be correctly set for invoices based on payment terms.

Currently we are just setting it when pay on credit

Orderloader (line 1830)
        if (wasPaidOnCredit) {
          paymentScheduleInvoice.setDueDate(getCalculatedDueDateBasedOnPaymentTerms(
              order.getOrderDate(), order.getPaymentTerms()));
          paymentScheduleInvoice.setExpectedDate(paymentScheduleInvoice.getDueDate());
        } else {
          paymentScheduleInvoice.setDueDate(order.getOrderDate());
          paymentScheduleInvoice.setExpectedDate(order.getOrderDate());
        }

Steps To Reproduce

Create an order using specific payment terms.

Due date is not correctly calculated.

Steps of issue https://issues.openbravo.com/view.php?id=33830 [^] can be followed to reproduce (using an standard payment method)

Proposed Solution

execute getCalculatedDueDateBasedOnPaymentTerms always

Additional Information