Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034271Retail ModulesWeb POSpublic2016-10-21 13:302016-12-05 11:49
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-08-16
Regression introduced in releaseRR16Q2.3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a426e814fec5#l2.7 [^]
Triggers an Emergency PackNo
Summary0034271: Click quickly twice in a product does not add 2 products but 1. In previous releases it did work.
DescriptionClicking in a product quickly produces some clicks are not caught by Web POS.
If, f.e., in an empty receipt it is added a new product and the user wants to add two units of the same products, the user would click twice quickly in the same product, but since RR16Q2.3 onwards it is not possible. (The oldest release I have had access to where I have been able to reproduce this issue is RR16Q2.3). In RR16Q1.3 it is working right so this issue is not reproducible.
It has been tested in livebuilds and no extra modules are required.

Videos reproducing the issue performing 3 clicks:
Correct behaviour (RR16Q1.3): https://drive.google.com/open?id=0Bz1bUfkEffVISHR1d2hQMFhXb2s [^]
Wrong behaviour (RR16Q2.3): https://drive.google.com/open?id=0Bz1bUfkEffVIY3F5UnlMY3c2Ykk [^]
Steps To Reproduce0-Login POS as vallblanca.
1-Create a new receipt.
2-Click BROWSE tab and go to Best sellers Category.
3-Now, click twice quickly in "Avalanche transceiver" product. Only one product will be added. In RR16Q1.3 release backwards the performance is better and it is possible to perform that action.
Proposed Solution
Additional Information
TagsPerformance
Relationships
depends on backport 0034393RR16Q4 closed ranjith_qualiantech_com Click quickly twice in a product does not add 2 products but 1. In previous releases it did work. 
depends on backport 0034394RR16Q3.4 closed ranjith_qualiantech_com Click quickly twice in a product does not add 2 products but 1. In previous releases it did work. 
depends on backport 0034395RR16Q2.5 closed ranjith_qualiantech_com Click quickly twice in a product does not add 2 products but 1. In previous releases it did work. 
caused by defect 0033520 closed ranjith_qualiantech_com [RR16Q3][ProductServices] Clicking several times in a product to add it to a receipt prevents Product Services to appear 
Attached Filespatch issue 34271 posterminal 7127.patch (3,118) 2016-10-27 14:30
https://issues.openbravo.com/file_download.php?file_id=9970&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-21 13:30lorenzofidalgoNew Issue
2016-10-21 13:30lorenzofidalgoAssigned To => Retail
2016-10-21 13:30lorenzofidalgoRegression level => Production - Confirmed Stable
2016-10-21 13:30lorenzofidalgoRegression introduced in release => RR16Q2.3
2016-10-21 13:30lorenzofidalgoTriggers an Emergency Pack => No
2016-10-21 13:30lorenzofidalgoTag Attached: Performance
2016-10-21 14:12lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=13445#r13445
2016-10-21 14:13lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=13446#r13446
2016-10-24 12:04ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-10-24 12:05ranjith_qualiantech_comStatusnew => scheduled
2016-10-25 15:57ranjith_qualiantech_comRelationship addedcaused by 0033549
2016-10-25 16:08ranjith_qualiantech_comRelationship deletedcaused by 0033549
2016-10-25 16:08ranjith_qualiantech_comRelationship addedcaused by 0033520
2016-10-27 14:30ranjith_qualiantech_comFile Added: issue 34271 posterminal 7127.patch
2016-11-02 14:31hgbotCheckin
2016-11-02 14:31hgbotNote Added: 0091065
2016-11-02 14:31hgbotStatusscheduled => resolved
2016-11-02 14:31hgbotResolutionopen => fixed
2016-11-02 14:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1edbfb39154c4d941b8eb41c313fff9e150eb6e [^]
2016-11-04 10:56ranjith_qualiantech_comRegression date => 2016-08-16
2016-11-04 10:56ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a426e814fec5#l2.7 [^]
2016-11-04 10:57ranjith_qualiantech_comNote Added: 0091167
2016-11-04 10:57ranjith_qualiantech_comStatusresolved => new
2016-11-04 10:57ranjith_qualiantech_comResolutionfixed => open
2016-11-04 10:58ranjith_qualiantech_comStatusnew => scheduled
2016-11-04 10:58ranjith_qualiantech_comStatusscheduled => resolved
2016-11-04 10:58ranjith_qualiantech_comResolutionopen => fixed
2016-11-10 09:55guilleaerNote Added: 0091318
2016-11-10 09:55guilleaerStatusresolved => new
2016-11-10 09:55guilleaerResolutionfixed => open
2016-11-10 09:58ranjith_qualiantech_comStatusnew => scheduled
2016-11-16 05:40hgbotCheckin
2016-11-16 05:40hgbotNote Added: 0091588
2016-11-16 05:40hgbotStatusscheduled => resolved
2016-11-16 05:40hgbotResolutionopen => fixed
2016-11-16 05:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1edbfb39154c4d941b8eb41c313fff9e150eb6e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/795a217b6a2374fe5df24651cfdc2b44fff0a296 [^]
2016-11-16 05:40hgbotCheckin
2016-11-16 05:40hgbotNote Added: 0091589
2016-11-25 13:20marvintmNote Added: 0091840
2016-11-25 13:20marvintmStatusresolved => new
2016-11-25 13:20marvintmResolutionfixed => open
2016-11-25 13:20marvintmStatusnew => scheduled
2016-11-30 09:50hgbotCheckin
2016-11-30 09:50hgbotNote Added: 0091915
2016-11-30 09:50hgbotStatusscheduled => resolved
2016-11-30 09:50hgbotResolutionopen => fixed
2016-11-30 09:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/795a217b6a2374fe5df24651cfdc2b44fff0a296 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a540a13f15dfa348390924f06556498f5089ec79 [^]
2016-11-30 09:50hgbotCheckin
2016-11-30 09:50hgbotNote Added: 0091916
2016-12-05 11:49guilleaerReview Assigned To => guilleaer
2016-12-05 11:49guilleaerStatusresolved => closed
2016-12-05 11:49guilleaerFixed in Version => RR17Q1

Notes
(0091065)
hgbot   
2016-11-02 14:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f1edbfb39154c4d941b8eb41c313fff9e150eb6e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 02 19:00:52 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1edbfb39154c4d941b8eb41c313fff9e150eb6e [^]

Fixes issue 34271 : Validating product addition while double clicking

* If the product have services, service screen should shown & only one unit should be added
* If the product doesn't have services, unit should be added based on no of clicks

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0091167)
ranjith_qualiantech_com   
2016-11-04 10:57   
Opening for creating backports
(0091318)
guilleaer   
2016-11-10 09:55   
Reopened.

I have detected one scenario where system allow to add several units when the product has services.

-> mark terminal type as "use extenar input"
-> scan the same product several times very fast
(0091588)
hgbot   
2016-11-16 05:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 795a217b6a2374fe5df24651cfdc2b44fff0a296
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Nov 15 16:22:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/795a217b6a2374fe5df24651cfdc2b44fff0a296 [^]

Fixes issue 34271 : Prevent adding of product, if last added product has mandatory services

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0091589)
hgbot   
2016-11-16 05:40   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c37c53ff7e722d2689dd86dbabfedf4b7547453a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 16 10:09:21 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c37c53ff7e722d2689dd86dbabfedf4b7547453a [^]

Related to issue 34271 : Set scanningFocus to false to avoid product scanning

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0091840)
marvintm   
2016-11-25 13:20   
There is currently a problem with this fix, if the preference "Do not allow negative lines" is enabled.

If it is, then if the following steps are followed, a big Javascript error is raised:

- Log in the Web POS.
- Open Verified Returns, and select one line to return.
- Try to add a positive line with a different product. A JS error will be shown.
(0091915)
hgbot   
2016-11-30 09:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a540a13f15dfa348390924f06556498f5089ec79
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:19:04 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a540a13f15dfa348390924f06556498f5089ec79 [^]

Fixes issue 34271 : Validating orderline in PostAddProductToOrder hook

* If any error occurs while adding product, related services should not be checked

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091916)
hgbot   
2016-11-30 09:50   
Repository: tools/automation/pi-mobile
Changeset: 1cb46800b9e9788dc7d7f6d80e7e9a529f6a0424
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 30 14:19:22 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1cb46800b9e9788dc7d7f6d80e7e9a529f6a0424 [^]

Verifies issue 34271 : Added automated test 'I34271_VerifyReceiptonMultiClickProduct'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34271_VerifyReceiptonMultiClickProduct.java
---