Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034260Openbravo ERP09. Financial managementpublic2016-10-21 06:352016-12-16 18:38
Reporterpradeepvarma 
Assigned Tomarkmm82 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034260: Currency not getting selected based on the organization selected in Simple G/L Journal
DescriptionThe currency is by defualt set to a default currency when a new record is created in the simple g/l journal window.
And when a different organization is selected the currency is not changed based on the organization selected.
Steps To Reproduce1. Log in to any livebuild instance
2. Open the simple g/l journal record.
-> Default orgn select will be a Spanish orgn and the currency will by EUR.
3. Change the organization to US East cost and check the currency will still remain as EUR.
4. The video for the same is attached here with.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0022296 closed markmm82 The field currency should be updated with the currency of the general ledger configuration while entering a G/L Journal Header 
related to defect 0033798 scheduled nonofrancisco General Ledger is not updated when organization changes 
related to design defect 0032441 closed Triage Omni OMS Organization and Currency fields are showing the last saved value as default value in Simple G/L Journal window 
Attached Files? currency_of_organization_simple_gl_journal.mp4 (1,315,010) 2016-10-21 06:35
https://issues.openbravo.com/file_download.php?file_id=9938&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-21 06:35pradeepvarmaNew Issue
2016-10-21 06:35pradeepvarmaAssigned To => Triage Finance
2016-10-21 06:35pradeepvarmaFile Added: currency_of_organization_simple_gl_journal.mp4
2016-10-21 06:35pradeepvarmaModules => Core
2016-10-21 06:35pradeepvarmaTriggers an Emergency Pack => No
2016-10-21 13:01egoitzResolution time => 1478214000
2016-10-21 13:22aferrazRelationship addedrelated to 0022296
2016-10-24 17:53aferrazAssigned ToTriage Finance => markmm82
2016-10-25 17:09markmm82Statusnew => scheduled
2016-11-03 20:07aferrazRelationship addedrelated to 0033798
2016-11-03 20:09aferrazResolution time1478214000 =>
2016-11-03 20:09aferrazSeveritymajor => minor
2016-11-08 13:17psanjuanNote Added: 0091235
2016-11-09 11:11psanjuanNote Added: 0091262
2016-11-09 11:12psanjuanNote Edited: 0091262bug_revision_view_page.php?bugnote_id=0091262#r13589
2016-11-09 11:24psanjuanNote Edited: 0091262bug_revision_view_page.php?bugnote_id=0091262#r13590
2016-11-09 11:35psanjuanNote Edited: 0091262bug_revision_view_page.php?bugnote_id=0091262#r13591
2016-11-09 11:39psanjuanNote Edited: 0091262bug_revision_view_page.php?bugnote_id=0091262#r13592
2016-11-09 11:44psanjuanNote Added: 0091264
2016-11-09 12:06psanjuanNote Edited: 0091264bug_revision_view_page.php?bugnote_id=0091264#r13594
2016-11-09 12:07psanjuanNote Edited: 0091264bug_revision_view_page.php?bugnote_id=0091264#r13595
2016-11-09 12:08psanjuanNote Edited: 0091262bug_revision_view_page.php?bugnote_id=0091262#r13596
2016-11-09 12:08psanjuanNote Edited: 0091262bug_revision_view_page.php?bugnote_id=0091262#r13597
2016-11-09 12:09psanjuanNote Edited: 0091264bug_revision_view_page.php?bugnote_id=0091264#r13598
2016-11-09 12:11psanjuanNote Added: 0091268
2016-11-09 12:18psanjuanNote Edited: 0091268bug_revision_view_page.php?bugnote_id=0091268#r13600
2016-11-09 12:20psanjuanNote Edited: 0091268bug_revision_view_page.php?bugnote_id=0091268#r13601
2016-11-09 12:21psanjuanNote Added: 0091269
2016-11-09 12:21psanjuanNote Edited: 0091268bug_revision_view_page.php?bugnote_id=0091268#r13602
2016-11-09 12:21psanjuanNote Edited: 0091269bug_revision_view_page.php?bugnote_id=0091269#r13604
2016-11-09 12:22psanjuanNote Added: 0091270
2016-11-09 12:43hgbotCheckin
2016-11-09 12:43hgbotNote Added: 0091276
2016-11-09 12:43hgbotStatusscheduled => resolved
2016-11-09 12:43hgbotResolutionopen => fixed
2016-11-09 12:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c5a35b41929c37703e651e7775bb0e85881f0725 [^]
2016-11-09 12:44hgbotCheckin
2016-11-09 12:44hgbotNote Added: 0091277
2016-11-09 12:45aferrazReview Assigned To => aferraz
2016-11-09 12:45aferrazNote Added: 0091279
2016-11-09 12:45aferrazStatusresolved => closed
2016-11-09 12:45aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092602
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092603
2017-06-07 09:00ngarciaRelationship addedrelated to 0032441

Notes
(0091235)
psanjuan   
2016-11-08 13:17   
Issue verified as.

As F&B International Group Admin role set below values as default session values:
Organization : F&B España
Warehouse: España Region Norte
Language : English.

Check "Set as Default", and then press "Apply".

Go to Simple G/L Journal window and create a new one.

Verify that default organization shown is not F&B España but F&B US Inc and the currency is EUR.

Change it to F&B España. Change it to F&B US and check that currency remains as EUR.

This is not correct. Issue verified.
(0091262)
psanjuan   
2016-11-09 11:11   
(edited on: 2016-11-09 12:08)
Test Plan

Test case 1

As F&B International Group Admin role set
Organization = F&B España
Warehouse = España Region Norte
Language = English
as default values.

Press Apply

Go to Simple G/L Journal and create a new one.
Check that F&B España organization is selected, same as Currency = EUR.
Enter a Description and Save.
Close the window.

Go to Profile and set as default:
Organization = F&B US
Warehouse = US East Cost
Language = English
Press Apply.

Go to Simple G/L Journal and create a new one.
Check that F&B US organization is selected, same as Currency = USD
Enter a Description and Save.
Close the window.

Go to Profile and set as default:
Organization = F&B España - Region Norte.
Warehouse = España Region Norte
Language = English
Press Apply.

Go to Simple G/L Journal and create a new one.
Check that F&B España Region Norte organization is selected, same as Currency = EUR

Change Organization to F&B US.
Check that Currency changes to USD

Change Organization to F&B España without saving.
Check that Currency changes to EUR.

Change Organization to F&B US East Coast without saving.
Check that Currency changes to USD

Test case 2 - USD General Ledger while posting in EUR currency.

Change Organization to F&B España without saving.
Check that currency changes to EUR.
Select General Ledger to F&B International Group US Dollar
Check that currency remains as EUR.

Go to Lines and enter two lines as:
Account 1110 Debit Amount = 100.00 (EUR). Check General Ledger Currency Debit = 120.00 USD (100.00 EUR * 1.2 EUR to USD rate)
Account 1130 Credit Amount = 100.00 (EUR). Check General Ledger Currency Credit = 120.00 USD (100.00 EUR * 1.2 EUR to USD rate)
Complete and post


Verify there is only one journal entries report for F&B International Group US Dollar as shown below:

120.00 (1110) Debit
120.00 (1130) Credit
(0091264)
psanjuan   
2016-11-09 11:44   
(edited on: 2016-11-09 12:09)
Test Case 3 EUR General Ledger while posting in EUR

Go to Simple G/L Journal and create a new one.
Check that F&B España organization is selected, same as currency = EUR
Check that F&B España US Euro General Ledger is selected.
Enter a description.

Go to lines and create a two new lines with below setup:
10300 account - 100.00 EUR (debit)
10340 account - 100.00 EUR (Credit)
Complete and Post.

Verify there is only one journal entries report for F&B España EUR as shown below:

100.00 (1110) Debit
100.00 (1130) Credit
(0091268)
psanjuan   
2016-11-09 12:11   
(edited on: 2016-11-09 12:21)
Test Case 4 - Multi-General Ledger while posting in EUR

Go to Simple G/L Journal and create a new one.
Check that F&B España is selected, Currency = EUR.
Enter a Description. Check Multi-General Ledger.

Go to lines and create a two new lines with below setup:
line one - select a G/L item - 100.00 EUR (debit)
line two - select a G/L item - 100.00 EUR (Credit)
Complete and Post.

Verify there are two journal entries reports, one for each General Ledger Account, as G/L Items setup has two accounts one for each General Ledger.

For F&B España EUR as shown below:

100.00 (1110) Debit
100.00 (1130) Credit

For F&B Interantional USD as shown below:

120.00 (1110) Debit
120.00 (1130) Credit
(0091269)
psanjuan   
2016-11-09 12:21   
Test Case 5 - Multi-General Ledger while posting in USD

Go to Simple G/L Journal and create a new one.
Check that F&B España is selected, Currency = EUR. Change currency to USD.
Enter a Description. Check Multi-General Ledger.

Go to lines and create a two new lines with below setup:
line one - select a G/L item - 100.00 USD (debit)
line two - select a G/L item - 100.00 USD (Credit)
Complete and Post.

Verify there are two journal entries reports, one for each General Ledger Account, as G/L Items setup has two accounts one for each General Ledger.

For F&B España EUR as shown below:

83.33 (1110) Debit
83.33 (1130) Credit

For F&B Interantional USD as shown below:

100.00 (1110) Debit
100.00 (1130) Credit
(0091270)
psanjuan   
2016-11-09 12:22   
Test Plan above verified.

Issue can be code reviewed and closed.
(0091276)
hgbot   
2016-11-09 12:43   
Repository: erp/devel/pi
Changeset: c5a35b41929c37703e651e7775bb0e85881f0725
Author: Mark <markmm82 <at> gmail.com>
Date: Fri Nov 04 09:23:33 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/c5a35b41929c37703e651e7775bb0e85881f0725 [^]

Fixes issue 34260: Currency selected based on org in Simple G/L Journal

When a different organization is selected the currency is changed based on the organization selected.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java
---
(0091277)
hgbot   
2016-11-09 12:44   
Repository: erp/devel/pi
Changeset: e0bcd0b2606d2c69623d2d21cd1bb59e1ac2118c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 09 11:12:18 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e0bcd0b2606d2c69623d2d21cd1bb59e1ac2118c [^]

Related to issue 34260: Code review improvements

Change GL_JournalBatch | AD_Org_ID default value to login organization.
Change GL_Journal | AD_Org_ID default value to login organization in Simple G/L Journal window and to parent organization in G/L Journal window.
Add callout also to GL_JournalBatch | AD_Org_ID column.
Use OBCurrencyUtils.getOrgCurrency to get organization's currency in SL_Journal_Period.java.

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java
---
(0091279)
aferraz   
2016-11-09 12:45   
Code review OK
(0092602)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092603)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test