Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034257Retail ModulesWeb POSpublic2016-10-20 17:542016-11-18 11:19
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2.4Fixed in VersionRR16Q2.4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034257: Import entries need to be executed in time order (by terminal)
DescriptionThere are some ImportEntryProccesors to manage the order of models (Order, Cashup...) to be processed in the backend. The first idea was to process in parallel all models to have good performance processing big amount of imports. But there are some restrictions between models to be processed (i.e.: Orders have to be processed before Cashup) and we introduced those restrictions in ImportEntryProccesors classes to manage correctly the execution order.
We continue discovering restrictions.
Steps To ReproduceThere are examples than can happen randomly. Having bad connection and being offline very frequently will help to suffer this.
The next example happens always but it only happens till 16Q4 because in this release has been included a development which always updates cashup info before any order cash mgmt request.

1- Login
2- Create an order
3- Go to Cash up
4- Go offline
5- Finish the cashup process
6- Do a cash management
7- Go online and messages will be synchronized
8- Consequence:
8.1- In 16Q4: Everything fine as explained above
8.2- In 16Q3.2 and 16Q2.3: ERROR--> We will see and error in Errors while importing... window
8.3- Previous releases: ERROR--> We will not see any error but created cash mgmt will not be related with the cashup and in consequence will not be reconciliated.
Proposed SolutionWe have decided to process imports filtering by terminal in sent order, without restrictions between models. We will process imports in the same order that actions were done in Web POS.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034254 closed migueldejuana Import entries need to be executed in time order (by terminal) 
Attached Filesdiff 34254_Q2.3Posterminal.diff (18,520) 2016-10-27 08:27
https://issues.openbravo.com/file_download.php?file_id=9964&type=bug
diff 34254_Q2.3MobileCore.diff (1,985) 2016-10-27 09:21
https://issues.openbravo.com/file_download.php?file_id=9965&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-20 17:54migueldejuanaTypedefect => backport
2016-10-20 17:54migueldejuanaTarget Version => RR16Q2.4
2016-10-21 11:54migueldejuanaFile Added: 34254_Q2.3MobileCore.diff
2016-10-21 11:55migueldejuanaFile Added: 34254_Q2.3Posterminal.diff
2016-10-27 08:26migueldejuanaFile Deleted: 34254_Q2.3MobileCore.diff
2016-10-27 08:26migueldejuanaFile Deleted: 34254_Q2.3Posterminal.diff
2016-10-27 08:26migueldejuanaFile Added: 34254_Q2.3MobileCore.diff
2016-10-27 08:27migueldejuanaFile Added: 34254_Q2.3Posterminal.diff
2016-10-27 09:21migueldejuanaFile Deleted: 34254_Q2.3MobileCore.diff
2016-10-27 09:21migueldejuanaFile Added: 34254_Q2.3MobileCore.diff
2016-11-11 08:48hgbotCheckin
2016-11-11 08:48hgbotNote Added: 0091351
2016-11-11 08:48hgbotStatusscheduled => resolved
2016-11-11 08:48hgbotResolutionopen => fixed
2016-11-11 08:48hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core/rev/e7f1fee64b6f64609dd620ae4b3fdeffcae29b15 [^]
2016-11-11 08:49hgbotCheckin
2016-11-11 08:49hgbotNote Added: 0091357
2016-11-11 08:49hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core/rev/e7f1fee64b6f64609dd620ae4b3fdeffcae29b15 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/47d9c95b179a49f69ee5b7c27ded02f0ab53bd5a [^]
2016-11-14 18:26guilleaerReview Assigned To => guilleaer
2016-11-14 18:26guilleaerStatusresolved => closed
2016-11-14 18:26guilleaerFixed in Version => RR16Q2.4
2016-11-15 15:45hgbotCheckin
2016-11-15 15:45hgbotNote Added: 0091572
2016-11-15 15:45hgbotStatusclosed => resolved
2016-11-15 15:45hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/47d9c95b179a49f69ee5b7c27ded02f0ab53bd5a [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/61251d86535e72bc042080a15d146bb3c7744fd2 [^]
2016-11-15 15:46hgbotCheckin
2016-11-15 15:46hgbotNote Added: 0091573
2016-11-15 15:46hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/61251d86535e72bc042080a15d146bb3c7744fd2 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core/rev/b18186c70f498d285b49423cf80d2dcdcca99976 [^]
2016-11-15 16:50marvintmReview Assigned Toguilleaer => marvintm
2016-11-15 16:50marvintmStatusresolved => closed
2016-11-18 10:47hgbotCheckin
2016-11-18 10:47hgbotNote Added: 0091651
2016-11-18 10:47hgbotStatusclosed => resolved
2016-11-18 10:47hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core/rev/b18186c70f498d285b49423cf80d2dcdcca99976 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/13b6fbdefc8aba0608ec4d0014fa7ef98b03b5dd [^]
2016-11-18 11:19guilleaerStatusresolved => closed

Notes
(0091351)
hgbot   
2016-11-11 08:48   
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core
Changeset: e7f1fee64b6f64609dd620ae4b3fdeffcae29b15
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Nov 11 08:32:12 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core/rev/e7f1fee64b6f64609dd620ae4b3fdeffcae29b15 [^]

Fixed issue 34257, backport of issue 34254: Import entries need to be executed in time order (by terminal)

---
A src/org/openbravo/mobile/core/process/SerializedByTermImportEntryProcessorRunnable.java
---
(0091357)
hgbot   
2016-11-11 08:49   
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal
Changeset: 47d9c95b179a49f69ee5b7c27ded02f0ab53bd5a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Nov 11 08:37:17 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/47d9c95b179a49f69ee5b7c27ded02f0ab53bd5a [^]

Fixed issue 34257, backport of issue 34254: Import entries need to be executed in time order (by terminal)

---
M src/org/openbravo/retail/posterminal/importprocess/CashManagementImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CashUpImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/OrderImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/QuotationsRejectEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/VoidLayawayEntryProcessor.java
---
(0091572)
hgbot   
2016-11-15 15:45   
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal
Changeset: 61251d86535e72bc042080a15d146bb3c7744fd2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 15 15:41:28 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/61251d86535e72bc042080a15d146bb3c7744fd2 [^]

Fixed issue 0034257: Import entries need to be executed in time order (by terminal)

- Move from mobile.core to posterminal because obposPosterminal column is in posterminal

---
M src/org/openbravo/retail/posterminal/importprocess/CashManagementImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CashUpImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/OrderImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/QuotationsRejectEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/VoidLayawayEntryProcessor.java
A src/org/openbravo/retail/posterminal/process/SerializedByTermImportEntryProcessorRunnable.java
---
(0091573)
hgbot   
2016-11-15 15:46   
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core
Changeset: b18186c70f498d285b49423cf80d2dcdcca99976
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 15 15:38:02 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.mobile.core/rev/b18186c70f498d285b49423cf80d2dcdcca99976 [^]

Fixed issue 0034257: Import entries need to be executed in time order (by terminal)

- Move from mobile.core to posterminal because obposPosterminal column is in posterminal

---
R src/org/openbravo/mobile/core/process/SerializedByTermImportEntryProcessorRunnable.java
---
(0091651)
hgbot   
2016-11-18 10:47   
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal
Changeset: 13b6fbdefc8aba0608ec4d0014fa7ef98b03b5dd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Nov 17 18:09:45 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/13b6fbdefc8aba0608ec4d0014fa7ef98b03b5dd [^]

Fixed issue 0034257: Import entries need to be executed in time order (by terminal)

- Send initial Cash Up before sending Open till Cash Management to do not point to a non existing Cash up

---
M web/org.openbravo.retail.posterminal/js/utils/cashManagementUtils.js
---