Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034251Retail ModulesGift cards and gift voucherspublic2016-10-20 12:122017-01-16 22:56
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR16Q2 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2016-06-21
Regression introduced in releaseRR16Q3.2
Regression introduced by commithttps://code.openbravo.com/retail/try/org.openbravo.retail.posterminal/rev/bcb475a1bca5 [^]
Triggers an Emergency PackNo
Summary0034251: gift card line can not be edited
Descriptionwhen a gift card is added to one receipt, you can not edit the price of the gift card
Steps To Reproducein terminal https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]

. add line: head lamp ultralight
. add line: gift card infinite
select gift card line:
. set a new price. Pop up is displayed:
This line can not be edited
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034265RR16Q4 closed ranjith_qualiantech_com gift card line can not be edited 
caused by defect 0033300 closed ranjith_qualiantech_com [SERQA 1298] It is possible to remove lines from paid tickets using the '-' button of the keyboard 
has duplicate defect 0034363 closed Retail It is not possible to change the gift voucher's price 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-20 12:12malsasuaNew Issue
2016-10-20 12:12malsasuaAssigned To => Retail
2016-10-20 12:12malsasuaResolution time => 1477519200
2016-10-20 12:12malsasuaRegression level => Production - Confirmed Stable
2016-10-20 12:12malsasuaTriggers an Emergency Pack => No
2016-10-20 12:27heccamIssue Monitored: heccam
2016-10-20 13:33plujanIssue Monitored: plujan
2016-10-20 15:32ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-10-20 15:32ranjith_qualiantech_comStatusnew => scheduled
2016-10-21 10:18hgbotCheckin
2016-10-21 10:18hgbotNote Added: 0090747
2016-10-21 10:18hgbotStatusscheduled => resolved
2016-10-21 10:18hgbotResolutionopen => fixed
2016-10-21 10:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c214a110c17ddeb73320b88e9499a19208313aa7 [^]
2016-10-21 10:18hgbotCheckin
2016-10-21 10:18hgbotNote Added: 0090748
2016-10-21 10:33ranjith_qualiantech_comRegression date => 2016-06-21
2016-10-21 10:33ranjith_qualiantech_comRegression introduced in release => RR16Q3.2
2016-10-21 10:33ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/retail/try/org.openbravo.retail.posterminal/rev/bcb475a1bca5 [^]
2016-10-21 10:33ranjith_qualiantech_comStatusresolved => new
2016-10-21 10:33ranjith_qualiantech_comResolutionfixed => open
2016-10-21 10:33ranjith_qualiantech_comStatusnew => scheduled
2016-10-21 10:34ranjith_qualiantech_comStatusscheduled => resolved
2016-10-21 10:34ranjith_qualiantech_comResolutionopen => fixed
2016-10-27 15:47marvintmNote Added: 0090960
2016-10-27 15:47marvintmStatusresolved => new
2016-10-27 15:47marvintmResolutionfixed => open
2016-10-27 15:47marvintmStatusnew => scheduled
2016-10-31 12:31hgbotCheckin
2016-10-31 12:31hgbotNote Added: 0091020
2016-11-01 07:16hgbotCheckin
2016-11-01 07:16hgbotNote Added: 0091032
2016-11-01 08:40ranjith_qualiantech_comStatusscheduled => resolved
2016-11-01 08:40ranjith_qualiantech_comResolutionopen => fixed
2016-11-01 09:01marvintmReview Assigned To => marvintm
2016-11-01 09:01marvintmStatusresolved => closed
2016-11-02 08:50malsasuaRelationship addedhas duplicate 0034363
2016-11-06 12:42dmitry_mezentsevRelationship addedcaused by 0033300
2017-01-16 22:56dmitry_mezentsevRegression levelProduction - Confirmed Stable => Production - QA Approved
2017-01-16 22:56dmitry_mezentsevNote Added: 0093618

Notes
(0090747)
hgbot   
2016-10-21 10:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c214a110c17ddeb73320b88e9499a19208313aa7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 21 13:47:46 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c214a110c17ddeb73320b88e9499a19208313aa7 [^]

Fixes issue 34251 : Line should not be edited if the line "isEditablePrice" is true and input through keypoard price button

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0090748)
hgbot   
2016-10-21 10:18   
Repository: tools/automation/pi-mobile
Changeset: 9b0dd99adca65fe03e660cea1a27edb3c5a8600c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 21 13:47:06 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9b0dd99adca65fe03e660cea1a27edb3c5a8600c [^]

Verifies issue 34251 : Added automated test 'I34251_VerifyGiftCardEditPrice'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I34251_VerifyGiftCardEditPrice.java
---
(0090960)
marvintm   
2016-10-27 15:47   
The case described in the issue doesn't work right now. If I add a unit of HeadLamp Ultralight, then I add a gift card infinite, and then I try to change the price of the gift card line, I get an error popup ("The line cannot be edited").

Additionally, the automated test is also wrong. It's currently checking that the total is 103.6, and that is incorrect, because as it is changing the price of the gift card line to 200, it should be 203.6.
(0091020)
hgbot   
2016-10-31 12:31   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: bd2d07a3d6c7553809d602ebb87da226ccfc3074
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Oct 31 17:00:29 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/bd2d07a3d6c7553809d602ebb87da226ccfc3074 [^]

Related to issue 34251 : Giftcard Product price should be editable

---
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0091032)
hgbot   
2016-11-01 07:16   
Repository: tools/automation/pi-mobile
Changeset: dfd3cf1c2623ff8575db8e71ceea4d37d91742a9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Nov 01 10:16:56 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dfd3cf1c2623ff8575db8e71ceea4d37d91742a9 [^]

Verifies issue 34251 : Modified automated test 'I34251_VerifyGiftCardEditPrice'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I34251_VerifyGiftCardEditPrice.java
---
(0093618)
dmitry_mezentsev   
2017-01-16 22:56   
At this point the release was still QAA