Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034245Retail ModulesWeb POSpublic2016-10-20 07:492016-11-28 15:59
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3.3Fixed in VersionRR16Q3.3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2016-06-27
Regression introduced in releaseRR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/10ca4126a517c37c89fcc2034eac97bdd0be4e21 [^]
Triggers an Emergency PackNo
Summary0034245: Generic products are not shown
DescriptionWe cannot see Generic products in Browser tab because the commit which causes the regression doesn't take into account Generic products.
If pricelist is null for a product(Generic) active will be 'N' and it won't be loaded/shown in web Pos.
Steps To Reproduce- Login
- Open Browse
- Mountanering category
- At the end of the list of products, Thermal t-shirt should be shown
Proposed SolutionBackout the commit which causes the regression because it is not and issue, it is a limitation of the incremental refresh. Incremental refresh, will remove products from local database only when active column is unchecked. If the rest of columns of the product change, it will be loaded in the total refresh.
Not only sale column affects to the product to be loaded or not, also if we remove it from the assortment or from the pricelist...
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034243 closed migueldejuana Generic products are not shown 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-20 07:49migueldejuanaTypedefect => backport
2016-10-20 07:49migueldejuanaTarget Version => RR16Q3.4
2016-10-25 09:22migueldejuanaTarget VersionRR16Q3.4 => RR16Q3.3
2016-10-25 09:25hgbotCheckin
2016-10-25 09:25hgbotNote Added: 0090845
2016-10-25 09:25hgbotStatusscheduled => resolved
2016-10-25 09:25hgbotResolutionopen => fixed
2016-10-25 09:25hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/e7bd5a131764d962257fb0bd311d60adcad52339 [^]
2016-10-25 09:27hgbotCheckin
2016-10-25 09:27hgbotNote Added: 0090846
2016-10-25 09:27hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/e7bd5a131764d962257fb0bd311d60adcad52339 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.3/pi-mobile/rev/dd56d8afbd079d7799093d49b59eb78b108e739b [^]
2016-11-15 18:20guilleaerReview Assigned To => guilleaer
2016-11-15 18:20guilleaerStatusresolved => closed
2016-11-15 18:20guilleaerFixed in Version => RR16Q3.3
2016-11-24 12:51hgbotCheckin
2016-11-24 12:51hgbotNote Added: 0091776
2016-11-24 12:51hgbotStatusclosed => resolved
2016-11-24 12:51hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q3.3/pi-mobile/rev/dd56d8afbd079d7799093d49b59eb78b108e739b [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/dd56d8afbd079d7799093d49b59eb78b108e739b [^]
2016-11-28 15:59migueldejuanaStatusresolved => closed

Notes
(0090845)
hgbot   
2016-10-25 09:25   
Repository: retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal
Changeset: e7bd5a131764d962257fb0bd311d60adcad52339
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 25 09:25:25 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/e7bd5a131764d962257fb0bd311d60adcad52339 [^]

Fixed issue 0034245: Generic products are not shown

Backed out changeset 10ca4126a517

It is not an issue, is a design defect. It is a limitation of the incremental refresh. Incremental refresh, will remove products from local database only when active column is unchecked. If the rest of columns of the product change, it will be loaded in the total refresh.
Not only sale column affects to the product to be loaded or not, also if we remove it from the assortment or from the pricelist...

---
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
---
(0090846)
hgbot   
2016-10-25 09:27   
Repository: retail/backports/3.0RR16Q3.3/pi-mobile
Changeset: dd56d8afbd079d7799093d49b59eb78b108e739b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 21 13:48:55 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/pi-mobile/rev/dd56d8afbd079d7799093d49b59eb78b108e739b [^]

Fixed issue 0034245: Generic products are not shown

- Remove backouted issue test and add to final folder Generic product test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MJU/products/I32609_GenericProducts.java
---
(0091776)
hgbot   
2016-11-24 12:51   
Repository: tools/automation/pi-mobile
Changeset: dd56d8afbd079d7799093d49b59eb78b108e739b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 21 13:48:55 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dd56d8afbd079d7799093d49b59eb78b108e739b [^]

Fixed issue 0034245: Generic products are not shown

- Remove backouted issue test and add to final folder Generic product test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MJU/products/I32609_GenericProducts.java
---