Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034244Retail ModulesWeb POSpublic2016-10-20 07:492016-12-19 06:24
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2016-06-27
Regression introduced in releaseRR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/10ca4126a517c37c89fcc2034eac97bdd0be4e21 [^]
Triggers an Emergency PackNo
Summary0034244: Generic products are not shown
DescriptionWe cannot see Generic products in Browser tab because the commit which causes the regression doesn't take into account Generic products.
If pricelist is null for a product(Generic) active will be 'N' and it won't be loaded/shown in web Pos.
Steps To Reproduce- Login
- Open Browse
- Mountanering category
- At the end of the list of products, Thermal t-shirt should be shown
Proposed SolutionBackout the commit which causes the regression because it is not and issue, it is a limitation of the incremental refresh. Incremental refresh, will remove products from local database only when active column is unchecked. If the rest of columns of the product change, it will be loaded in the total refresh.
Not only sale column affects to the product to be loaded or not, also if we remove it from the assortment or from the pricelist...
Additional Information
TagsNo tags attached.
Relationships
has duplicate backport 0034269RR16Q4.1 closed migueldejuana Generic products are not shown 
blocks defect 0034243 closed migueldejuana Generic products are not shown 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-20 07:49migueldejuanaTypedefect => backport
2016-10-20 07:49migueldejuanaTarget Version => RR16Q4.1
2016-10-21 11:57migueldejuanaRelationship addedhas duplicate 0034269
2016-10-21 13:41migueldejuanaTarget VersionRR16Q4.1 => RR16Q4
2016-10-25 07:44hgbotCheckin
2016-10-25 07:44hgbotNote Added: 0090837
2016-10-25 07:44hgbotStatusscheduled => resolved
2016-10-25 07:44hgbotResolutionopen => fixed
2016-10-25 07:44hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/c18e80a9a1c843ea096ce1a0f23d706680f96f97 [^]
2016-10-25 09:30hgbotCheckin
2016-10-25 09:30hgbotNote Added: 0090847
2016-10-25 09:30hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/c18e80a9a1c843ea096ce1a0f23d706680f96f97 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/c2cb03b405b9c322712d3a7ea338d9572d681990 [^]
2016-12-09 13:15marvintmReview Assigned To => marvintm
2016-12-09 13:15marvintmStatusresolved => closed
2016-12-09 13:15marvintmFixed in Version => RR16Q4
2016-12-16 08:39hgbotCheckin
2016-12-16 08:39hgbotNote Added: 0092434
2016-12-16 08:39hgbotStatusclosed => resolved
2016-12-16 08:39hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/c2cb03b405b9c322712d3a7ea338d9572d681990 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/c2cb03b405b9c322712d3a7ea338d9572d681990 [^]
2016-12-19 06:24priyamNote Added: 0092747
2016-12-19 06:24priyamStatusresolved => closed

Notes
(0090837)
hgbot   
2016-10-25 07:44   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: c18e80a9a1c843ea096ce1a0f23d706680f96f97
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 21 13:46:48 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/c18e80a9a1c843ea096ce1a0f23d706680f96f97 [^]

Fixed issue 0034244: Generic products are not shown

Backed out changeset 10ca4126a517

It is not an issue, is a design defect. It is a limitation of the incremental refresh. Incremental refresh, will remove products from local database only when active column is unchecked. If the rest of columns of the product change, it will be loaded in the total refresh.
Not only sale column affects to the product to be loaded or not, also if we remove it from the assortment or from the pricelist...

---
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
---
(0090847)
hgbot   
2016-10-25 09:30   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: c2cb03b405b9c322712d3a7ea338d9572d681990
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 21 13:45:22 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/c2cb03b405b9c322712d3a7ea338d9572d681990 [^]

Fixed issue 0034244: Generic products are not shown

- Remove backouted issue test and add to final folder Generic product test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MJU/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33314_LoadProductBasedonSaleFlag.java
---
(0092434)
hgbot   
2016-12-16 08:39   
Repository: tools/automation/pi-mobile
Changeset: c2cb03b405b9c322712d3a7ea338d9572d681990
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 21 13:45:22 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c2cb03b405b9c322712d3a7ea338d9572d681990 [^]

Fixed issue 0034244: Generic products are not shown

- Remove backouted issue test and add to final folder Generic product test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MJU/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33314_LoadProductBasedonSaleFlag.java
---
(0092747)
priyam   
2016-12-19 06:24   
Closing as merge of pi-mobiles Q4 tag updated the issues.