Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034243Retail ModulesWeb POSpublic2016-10-20 07:492016-11-23 16:06
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2016-06-27
Regression introduced in releaseRR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/10ca4126a517c37c89fcc2034eac97bdd0be4e21 [^]
Triggers an Emergency PackNo
Summary0034243: Generic products are not shown
DescriptionWe cannot see Generic products in Browser tab because the commit which causes the regression doesn't take into account Generic products.
If pricelist is null for a product(Generic) active will be 'N' and it won't be loaded/shown in web Pos.
Steps To Reproduce- Login
- Open Browse
- Mountanering category
- At the end of the list of products, Thermal t-shirt should be shown
Proposed SolutionBackout the commit which causes the regression because it is not and issue, it is a limitation of the incremental refresh. Incremental refresh, will remove products from local database only when active column is unchecked. If the rest of columns of the product change, it will be loaded in the total refresh.
Not only sale column affects to the product to be loaded or not, also if we remove it from the assortment or from the pricelist...
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034244RR16Q4 closed migueldejuana Generic products are not shown 
depends on backport 0034245RR16Q3.3 closed migueldejuana Generic products are not shown 
depends on backport 0034269RR16Q4.1 closed migueldejuana Generic products are not shown 
caused by defect 0033314 closed ranjith_qualiantech_com when a product is updated as sales product, it is not removed from terminal 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-20 07:49migueldejuanaNew Issue
2016-10-20 07:49migueldejuanaAssigned To => migueldejuana
2016-10-20 07:49migueldejuanaRegression level => Production - QA Approved
2016-10-20 07:49migueldejuanaRegression date => 2016-06-27
2016-10-20 07:49migueldejuanaRegression introduced in release => RR16Q3
2016-10-20 07:49migueldejuanaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/10ca4126a517c37c89fcc2034eac97bdd0be4e21 [^]
2016-10-20 07:49migueldejuanaTriggers an Emergency Pack => No
2016-10-20 07:49migueldejuanaStatusnew => scheduled
2016-10-20 07:49migueldejuanaRelationship addedcaused by 0033314
2016-10-20 16:28hgbotCheckin
2016-10-20 16:28hgbotNote Added: 0090728
2016-10-20 16:28hgbotStatusscheduled => resolved
2016-10-20 16:28hgbotResolutionopen => fixed
2016-10-20 16:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/748d5a4b04c0965c75087599004bfd93314fa93e [^]
2016-10-20 16:28hgbotCheckin
2016-10-20 16:28hgbotNote Added: 0090729
2016-10-20 16:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/748d5a4b04c0965c75087599004bfd93314fa93e [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/b16f3c1e010d01ab7c8a96c98f082bbd18113cb2 [^]
2016-10-21 11:56migueldejuanaStatusresolved => new
2016-10-21 11:56migueldejuanaResolutionfixed => open
2016-10-21 11:56migueldejuanaStatusnew => scheduled
2016-10-21 11:56migueldejuanaStatusscheduled => resolved
2016-10-21 11:56migueldejuanaResolutionopen => fixed
2016-11-22 08:56migueldejuanaReview Assigned To => Orekaria
2016-11-23 16:06OrekariaStatusresolved => closed
2016-11-23 16:06OrekariaFixed in Version => RR17Q1

Notes
(0090728)
hgbot   
2016-10-20 16:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 748d5a4b04c0965c75087599004bfd93314fa93e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 20 07:58:06 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/748d5a4b04c0965c75087599004bfd93314fa93e [^]

Fixed issue 0034243: Generic products are not shown

Backed out changeset 10ca4126a517

It is not an issue, is a design defect. It is a limitation of the incremental refresh. Incremental refresh, will remove products from local database only when active column is unchecked. If the rest of columns of the product change, it will be loaded in the total refresh.
Not only sale column affects to the product to be loaded or not, also if we remove it from the assortment or from the pricelist...

---
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
---
(0090729)
hgbot   
2016-10-20 16:28   
Repository: tools/automation/pi-mobile
Changeset: b16f3c1e010d01ab7c8a96c98f082bbd18113cb2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 20 08:25:23 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b16f3c1e010d01ab7c8a96c98f082bbd18113cb2 [^]

Fixed issue 0034243: Generic products are not shown

- Remove backouted issue test and add to final folder Generic product test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MJU/products/I32609_GenericProducts.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33314_LoadProductBasedonSaleFlag.java
---