Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034229Openbravo ERP09. Financial managementpublic2016-10-14 12:332016-10-21 14:06
Reporterlorenzofidalgo 
Assigned Toasiermartirena 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2016-10-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/89f61788c100 [^]
Triggers an Emergency PackNo
Summary0034229: Document no. sequence is no longer respected when Payment with "Amount = 0.00" is involved
DescriptionWhen a record is generated, it automatically sets the following number of the last record created. Now, when a Payment is created with "Amount = 0.00" the string "*Z*" is concatenated. This induces the Document no. does not set the following number and it is duplicated instead.
Steps To Reproduce1-Go to "Payment In" window.
2-Click "Create a new record in a form" button and memorize the "Document No.".
3-Changing no values (it is important Amount = 0.00, as it is by default), click again in "Create a new record in a form" and change the number that appears in "Document No." field by the number of the just saved record. (It is required, usually, only decrement a unit). Save the record.
4-Go to grid view and realise there are two records with the same document number (finished with *Z*). Sequential document numbers have not been created.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034207 closed asiermartirena Document no. sequence is no longer respected when Payment with "Amount = 0.00" is involved 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-18 11:26aferrazTypedefect => backport
2016-10-18 11:26aferrazTarget Version => 3.0PR16Q4
2016-10-21 14:02hgbotCheckin
2016-10-21 14:02hgbotNote Added: 0090770
2016-10-21 14:02hgbotStatusscheduled => resolved
2016-10-21 14:02hgbotResolutionopen => fixed
2016-10-21 14:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/ab88529b8138d12db09602fe6a0c64f01c078c59 [^]
2016-10-21 14:03hgbotCheckin
2016-10-21 14:03hgbotNote Added: 0090771
2016-10-21 14:06aferrazReview Assigned To => aferraz
2016-10-21 14:06aferrazNote Added: 0090773
2016-10-21 14:06aferrazStatusresolved => closed
2016-10-21 14:06aferrazFixed in Version => 3.0PR16Q4

Notes
(0090770)
hgbot   
2016-10-21 14:02   
Repository: erp/backports/3.0PR16Q4
Changeset: ab88529b8138d12db09602fe6a0c64f01c078c59
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Tue Oct 18 11:45:46 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/ab88529b8138d12db09602fe6a0c64f01c078c59 [^]

Fixed issue 34229: The sequence to create payments docNo was not correctly updated

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
---
(0090771)
hgbot   
2016-10-21 14:03   
Repository: erp/backports/3.0PR16Q4
Changeset: 82381c190c1b73761ae5a10e15d639a0abe1738e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 21 12:56:10 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4/rev/82381c190c1b73761ae5a10e15d639a0abe1738e [^]

Related to issue 34229: Code review improvements

Throw error only if we are not reactivating payment in APRM_FIN_PMT_CHECK_TRG trigger.
Remove onSave event in FIN_PaymentEventListener.
Zero payment sufix will only be added in case we are processing the payment and it will only be removed in case we are reactivating the payment.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_PMT_CHECK_TRG.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0090773)
aferraz   
2016-10-21 14:06   
Code review + Testing OK