Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034223Openbravo ERP07. Sales managementpublic2016-10-17 18:192016-11-28 20:35
Reporteregoitz 
Assigned Tocollazoandy4 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusscheduledResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034223: It is possible to add two lines with the same line number on the sales/purchase orders
DescriptionWhen inserting lines in grid view you can insert two lines (or more) with the same line number.
Steps To Reproduce-Add a sales order header
-On grid view add a line (see that number line 10) is inserted.
-Fill all the mandatory fields and use the down arrow to crate a new line
-The new line is created with line number 20.
-If you click again the drow arrow key without filling any field a new line is also create with 20 line number.
-The previous one is keep as error but you can save it later.

The same behaviour happens on the header but the documentno is updated when saving if you have not modify it.

Proposed Solution Use the line numbers on the same way than documentno, so in case that you don't modify it is is automatically increased when needed.
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0034198 closed platform Duplicated line numbers in PO and SO 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-17 18:19egoitzNew Issue
2016-10-17 18:19egoitzAssigned To => Triage Finance
2016-10-17 18:19egoitzModules => Core
2016-10-17 18:19egoitzResolution time => 1478214000
2016-10-17 18:19egoitzTriggers an Emergency Pack => No
2016-10-20 19:18aferrazAssigned ToTriage Finance => markmm82
2016-10-20 20:25markmm82Statusnew => scheduled
2016-10-25 16:49markmm82Note Added: 0090876
2016-10-25 18:29aferrazReview Assigned To => aferraz
2016-10-25 18:29aferrazRelationship addedduplicate of 0034198
2016-10-25 18:29aferrazStatusscheduled => closed
2016-10-25 18:29aferrazResolutionopen => duplicate
2016-11-21 10:31egoitzAssigned Tomarkmm82 => Triage Finance
2016-11-21 10:31egoitzNote Added: 0091690
2016-11-21 10:31egoitzStatusclosed => new
2016-11-21 10:31egoitzResolutionduplicate => open
2016-11-21 12:37aferrazSeveritymajor => minor
2016-11-21 12:37aferrazTypedefect => design defect
2016-11-21 12:48aferrazNote Added: 0091694
2016-11-28 20:04collazoandy4Assigned ToTriage Finance => collazoandy4
2016-11-28 20:35collazoandy4Statusnew => scheduled

Notes
(0090876)
markmm82   
2016-10-25 16:49   
Test Plan:
1. Add a sales order header for Alimentos y Supermercado S.A bp.
2. On grid view add a line (first line)
   Check that line number 10 is inserted before and after save.
3. Right clic in the grid and select "Insert row" action (Also you can do that with Ctrl+i shortcut) to create a new line (second line).
   Notice that the new line is created with line number 20. Do not fill all mandatory fields.
4. Click again to Insert a new row without filling any field of the previous line, a new line is also created with the same 20 line number (third line).
   The previous one is keep as error but you can save it later.
5. Fill all the mandatory fields of the last line. Notice it is saved with line number: 20.
6. Go to the second line, and see it is showing as error and linenumbe remains the same: 20. Fill all the mandatory fields and let the line number as 20. Save the line.
   Notice that line number is updated to 30 when saving if you have not modify it.

Repeat the test plan above for purchase workflow.
(0091690)
egoitz   
2016-11-21 10:31   
Using the insert row option after click with the right button on the grid is not consistent.
If you use the new in grid view toolbar button the problem is reproducible.

Using the arrows as explained on the steps to reproduce also reproduced the problem.
(0091694)
aferraz   
2016-11-21 12:48   
Moved to minor as user should force the system in order to get a wrong line number.

Moved to design defect as problem does not happen only in Sales/Purchase Order windows but in any tab with a Line No. field.

Proposed solution: we should add an Event Handler same as SetDocumentNoHandler in order to re-check assigned line number when saving/updating any entity with a lineno property.