Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034184Openbravo ERP09. Financial managementpublic2016-10-11 09:552016-11-03 17:53
Reporterdmiguelez 
Assigned Todmiguelez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034184: API Change Request. Add parameters in CostingUtils and CostAdjustmentUtils methods
DescriptionAdd MaterialTransaction trx parameter to CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock methods.
Send currency to CostAdjustmentUtils.getStockOnTransactionDate and CostingUtils.getCurrentStock.
Both parameters are necessary in order to persist data to improve performance.
Steps To ReproduceAdd MaterialTransaction trx parameter to CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock methods.
Send currency to CostAdjustmentUtils.getStockOnTransactionDate and CostingUtils.getCurrentStock.
Both parameters are necessary in order to persist data to improve performance.

The risk is minor because updated methods are not referenced by any published module.
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 00339683.0PR17Q1 closed dmiguelez Wrong costs calculated with Backdated Transactions 
blocks backport 00341903.0PR16Q4 closed dmiguelez Wrong costs calculated with Backdated Transactions 
blocks backport 00339693.0PR16Q3.3 closed dmiguelez Wrong costs calculated with Backdated Transactions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-11 09:55dmiguelezNew Issue
2016-10-11 09:55dmiguelezAssigned To => Triage Finance
2016-10-11 09:55dmiguelezModules => Core
2016-10-11 09:55dmiguelezTriggers an Emergency Pack => No
2016-10-11 09:56aferrazRelationship addedblocks 0033968
2016-10-11 09:57aferrazAssigned ToTriage Finance => dmitry_mezentsev
2016-10-25 11:23dmitry_mezentsevTag Attached: Approved
2016-10-25 11:23dmitry_mezentsevAssigned Todmitry_mezentsev => dmiguelez
2016-10-25 12:28aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13470#r13470
2016-10-26 11:58hgbotCheckin
2016-10-26 11:58hgbotNote Added: 0090916
2016-10-26 11:58hgbotStatusnew => resolved
2016-10-26 11:58hgbotResolutionopen => fixed
2016-10-26 11:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/8f4a7d1ab044aeb563737cd5a09e2d8fba688e84 [^]
2016-10-26 12:49hgbotCheckin
2016-10-26 12:49hgbotNote Added: 0090917
2016-10-26 12:49hgbotCheckin
2016-10-26 12:49hgbotNote Added: 0090920
2016-10-26 12:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/8f4a7d1ab044aeb563737cd5a09e2d8fba688e84 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/961adc88383573f8289715fbd4276c280eaf84e5 [^]
2016-10-27 11:27aferrazReview Assigned To => aferraz
2016-10-27 11:27aferrazStatusresolved => closed
2016-10-27 11:27aferrazFixed in Version => 3.0PR17Q1
2016-11-03 17:53aferrazRelationship addedblocks 0034190
2016-11-03 17:53aferrazRelationship addedblocks 0033969

Notes
(0090916)
hgbot   
2016-10-26 11:58   
Repository: erp/devel/api-checks
Changeset: 8f4a7d1ab044aeb563737cd5a09e2d8fba688e84
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Oct 26 11:57:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8f4a7d1ab044aeb563737cd5a09e2d8fba688e84 [^]

Fixes issue 34184: API change for issue 33968

---
M java/reference/java.japi.gz
---
(0090917)
hgbot   
2016-10-26 12:49   
Repository: erp/devel/api-checks
Changeset: 3f253b825c760e8ed28065281cc578884ec264e7
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Oct 26 12:47:31 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3f253b825c760e8ed28065281cc578884ec264e7 [^]

Related to issue 34184: Backed out changeset 8f4a7d1ab044

Backout wrong API change for issue 33968.

---
M java/reference/java.japi.gz
---
(0090920)
hgbot   
2016-10-26 12:49   
Repository: erp/devel/api-checks
Changeset: 961adc88383573f8289715fbd4276c280eaf84e5
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Oct 26 12:48:21 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/961adc88383573f8289715fbd4276c280eaf84e5 [^]

Fixes issue 34184: Correct API change for issue 33968

---
M java/reference/java.japi.gz
---