Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034125Retail ModulesQuotationspublic2016-09-29 00:032016-10-26 19:07
ReporterOsmany 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034125: [SER-QA 1811] After reactivating the Quotation if add new product, then remove services line if exist in the receipt.
Descriptionwhen a quotation is created along with services lines and after reactivating the quotation, when the user adds new products service lines wrongly removed from the quotation
Steps To ReproduceLog in WEB POS.
Create a Quotation.
Add a product with services.
Press total amount receipt.
Close the quotation.

There is two flow to reproduce the issue
- Reactive the Quotation
Load the previous quotation
Reactive Quotation.
Add new product.
Realize that services lines is wrongly removed.

- Create Order from Quotation
Load the previous quotation
Create Sales Order.
Add new product.
Realize that services lines is wrongly removed.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Filespatch issue34125.patch (1,813) 2016-10-12 22:04
https://issues.openbravo.com/file_download.php?file_id=9906&type=bug
patch test34125.patch (5,438) 2016-10-12 22:05
https://issues.openbravo.com/file_download.php?file_id=9907&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-29 00:03OsmanyNew Issue
2016-09-29 00:03OsmanyAssigned To => Retail
2016-09-29 00:03OsmanyResolution time => 1475618400
2016-09-29 00:03OsmanyTriggers an Emergency Pack => No
2016-09-29 00:04OsmanySteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13268#r13268
2016-09-29 00:04OsmanyTag Attached: SER-QA
2016-09-29 00:41mario_castelloAssigned ToRetail => mario_castello
2016-09-29 16:21adrianromeroResolution time1475618400 => 1476309600
2016-09-29 17:19mario_castelloStatusnew => acknowledged
2016-10-11 18:40mario_castelloStatusacknowledged => scheduled
2016-10-12 22:04mario_castelloFile Added: issue34125.patch
2016-10-12 22:05mario_castelloFile Added: test34125.patch
2016-10-13 16:04mario_castelloNote Added: 0090554
2016-10-15 18:10hgbotCheckin
2016-10-15 18:10hgbotNote Added: 0090597
2016-10-15 18:10hgbotStatusscheduled => resolved
2016-10-15 18:10hgbotResolutionopen => fixed
2016-10-15 18:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/489e7bece603ab6c0defab026f5a813c84a309bb [^]
2016-10-15 18:26hgbotCheckin
2016-10-15 18:26hgbotNote Added: 0090598
2016-10-21 12:49marvintmNote Added: 0090761
2016-10-21 12:49marvintmStatusresolved => new
2016-10-21 12:49marvintmResolutionfixed => open
2016-10-21 12:49marvintmStatusnew => scheduled
2016-10-24 21:26hgbotCheckin
2016-10-24 21:26hgbotNote Added: 0090831
2016-10-24 21:26hgbotStatusscheduled => resolved
2016-10-24 21:26hgbotResolutionopen => fixed
2016-10-24 21:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/489e7bece603ab6c0defab026f5a813c84a309bb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6070992f882f8f3e214daba3fa4dedfb31e5874b [^]
2016-10-24 21:30mario_castelloSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13463#r13463
2016-10-24 21:33mario_castelloNote Edited: 0090597bug_revision_view_page.php?bugnote_id=0090597#r13465
2016-10-24 21:33mario_castelloNote Edited: 0090831bug_revision_view_page.php?bugnote_id=0090831#r13467
2016-10-24 21:39mario_castelloSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13468#r13468
2016-10-25 16:39hgbotCheckin
2016-10-25 16:39hgbotNote Added: 0090875
2016-10-26 19:07marvintmReview Assigned To => marvintm
2016-10-26 19:07marvintmStatusresolved => closed
2016-10-26 19:07marvintmFixed in Version => RR17Q1

Notes
(0090554)
mario_castello   
2016-10-13 16:04   
Attached solution and test.
(0090597)
hgbot   
2016-10-15 18:10   
(edited on: 2016-10-24 21:33)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 489e7bece603ab6c0defab026f5a813c84a309bb
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Oct 11 10:46:22 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/489e7bece603ab6c0defab026f5a813c84a309bb [^]

Fixed issue 34125: Created new map to stored the older lines id for lines that has services related

- Fixed the second flow when Create Order From Quotations

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0090598)
hgbot   
2016-10-15 18:26   
Repository: tools/automation/pi-mobile
Changeset: 976a5051edec4fa18a092a630a30a06149995f1e
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Sat Oct 15 10:25:31 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/976a5051edec4fa18a092a630a30a06149995f1e [^]

Related to issue 34125: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/services/I34125_QuotationServicesCreateOrder.java
---
(0090761)
marvintm   
2016-10-21 12:49   
The solution doesn't seem to work. I can still reproduce the problem doing the following:
- Create a quotation
- Add a unit of product "Bed".
- Click on the Services button. Add the service "Delivery service".
- Click on the total amount button, to complete the Quotation.
- Select the "Reactivate quotation" option in the menu.
- Add a unit of "Camera bag". Verify that the "Delivery service" has disappeared.
(0090831)
hgbot   
2016-10-24 21:26   
(edited on: 2016-10-24 21:33)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6070992f882f8f3e214daba3fa4dedfb31e5874b
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Oct 24 13:25:00 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6070992f882f8f3e214daba3fa4dedfb31e5874b [^]

Fixed issue 34125: Created new map to stored the older lines id for lines that has services related when reactivate a Quotation

- Fixed the first flow when Reactivate a Quotation

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0090875)
hgbot   
2016-10-25 16:39   
Repository: tools/automation/pi-mobile
Changeset: 35089d92284e912ae06e74d40059701e9a26cae8
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Oct 24 14:12:44 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/35089d92284e912ae06e74d40059701e9a26cae8 [^]

Verifies issue 34125: Added new test I34125_QuotationServicesReactivateQuotation

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/I34125_QuotationServicesReactivateQuotation.java
---