Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034119Openbravo ERPA. Platformpublic2016-09-28 13:292018-02-22 18:18
Reporteregoitz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034119: The syncrhonize terminology does not work properly on po windows on some circunstances
DescriptionThe synchronize terminology does not take the translation properly on the following scenario.
Steps To ReproduceInstall the translation for spanish
Define a new module as indevelopment with language es_ES (spanish(Spain))
Create for the new module a new window defined as maintenance window and not sales window.
Create a tab for m_inouttable.
Create the fields with the create fields process and check that they are defined as central maintenance.
Execute the syncrhonize terminology process.

*The description and help fields take properly the translated values but the name for the c_doctype_id field is not changed.

Proposed SolutionModify that line on the ad_synchronize function:

  (SELECT COALESCE(T.PO_NAME, (CASE WHEN e.PO_NAME='' THEN e.name ELSE COALESCE(e.PO_NAME,e.name) END), t.name, e.name)

The t.name should be used before the e.name.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0022324 closed shankarb Synchronize terminology not work properly in g/l journal window 
related to defect 0033889 feedback JONHM Synchronize Terminology fails when only having a Template in development 
Attached Filespatch bug-34119.patch (2,609) 2017-12-21 13:06
https://issues.openbravo.com/file_download.php?file_id=11388&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-28 13:29egoitzNew Issue
2016-09-28 13:29egoitzAssigned To => platform
2016-09-28 13:29egoitzModules => Core
2016-09-28 13:29egoitzTriggers an Emergency Pack => No
2016-09-29 09:13alostaleRelationship addedrelated to 0033889
2016-09-29 09:13alostaleStatusnew => acknowledged
2017-12-13 19:28caristuAssigned Toplatform => jarmendariz
2017-12-18 18:18jarmendarizStatusacknowledged => scheduled
2017-12-19 12:57jarmendarizRelationship addedrelated to 0022324
2017-12-21 13:06jarmendarizFile Added: bug-34119.patch
2017-12-21 13:07jarmendarizReview Assigned To => caristu
2018-01-22 13:51hgbotCheckin
2018-01-22 13:51hgbotNote Added: 0101840
2018-01-22 13:51hgbotStatusscheduled => resolved
2018-01-22 13:51hgbotResolutionopen => fixed
2018-01-22 13:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b1253e5b88c5cebb28fa4349902e01eefcdd0ee0 [^]
2018-01-22 13:53hgbotCheckin
2018-01-22 13:53hgbotNote Added: 0101842
2018-01-22 13:54caristuNote Added: 0101843
2018-01-22 13:54caristuStatusresolved => closed
2018-01-22 13:54caristuFixed in Version => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102677
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102678

Notes
(0101840)
hgbot   
2018-01-22 13:51   
Repository: erp/devel/pi
Changeset: b1253e5b88c5cebb28fa4349902e01eefcdd0ee0
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Dec 20 14:01:34 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b1253e5b88c5cebb28fa4349902e01eefcdd0ee0 [^]

Fixed bug 34119: Sync terminology doesn't translate some PO window fields.

In Synchronize Terminology the PO field's name is taken from its element instead of the element's translation (when available) when the element's PO_NAME field is empty.
Now the element's translation takes precedence over the element values. It is ordered as follows:

ad_element_trl.PO_NAME > ad_element.po_name > ad_element_trl.name > ad_element.name

---
M src-db/database/model/functions/AD_SYNCHRONIZE.xml
---
(0101842)
hgbot   
2018-01-22 13:53   
Repository: erp/devel/pi
Changeset: c93d3936f33936a274b3c70f3cd6f5e64f8a2444
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 22 13:52:31 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c93d3936f33936a274b3c70f3cd6f5e64f8a2444 [^]

related to issue 34119: update copyright year

---
M src-db/database/model/functions/AD_SYNCHRONIZE.xml
---
(0101843)
caristu   
2018-01-22 13:54   
Code reviewed + tested OK.
(0102677)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102678)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test