Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034109Retail ModulesLayaway orderpublic2016-09-28 00:202016-11-17 14:07
Reporterrbianchini 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR16Q3.1 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket43588
Regression levelProduction - Confirmed Stable
Regression date2015-12-02
Regression introduced in releaseRR15Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09a201bc283c [^]
Triggers an Emergency PackNo
Summary0034109: Error in OrderLoader if a invoiced layaway with total = 0 is synchronized
DescriptionIf you create a layaway and mark "invoice this receipt" and the layaway has a total = 0, an error in OrderLoader is raised:
ava.lang.NullPointerException
    at org.openbravo.retail.posterminal.OrderLoader.handlePayments(OrderLoader.java:1889)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:449)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:198)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:155)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:87)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:42)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:59)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:370)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:292)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)

This error is not given in 15Q2.5
Steps To Reproduce1 - Log in web pos
2 - In menu, click "Layaway this Receipt"
3 - In menu, click "Invoice this Receipt"
4 - Add a product to the receipt
5 - Click on order line created in step 4
6 - Click on 0, then click on price button in order to change the total to 0
7 - Click in total and click in done button
8 - Go to ERP and apen the Errors while importing pos data window
9 - Realize that the order is stucked in this window

The problem is that the OrderLoader doesn't create the payment plan for this order in this case
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 34109 source posterminal 5838.patch (1,973) 2016-09-29 15:42
https://issues.openbravo.com/file_download.php?file_id=9872&type=bug
patch issue 34109 test 5838.patch (3,460) 2016-09-29 15:42
https://issues.openbravo.com/file_download.php?file_id=9873&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-28 00:20rbianchiniNew Issue
2016-09-28 00:20rbianchiniAssigned To => Retail
2016-09-28 00:20rbianchiniOBNetwork customer => Yes
2016-09-28 00:20rbianchiniSupport ticket => 43588
2016-09-28 00:20rbianchiniResolution time => 1476759600
2016-09-28 00:20rbianchiniRegression level => Production - Confirmed Stable
2016-09-28 00:20rbianchiniRegression introduced in release => RR15Q3
2016-09-28 00:20rbianchiniTriggers an Emergency Pack => No
2016-09-28 08:21ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-09-28 08:21ranjith_qualiantech_comStatusnew => scheduled
2016-09-29 15:42ranjith_qualiantech_comFile Added: issue 34109 source posterminal 5838.patch
2016-09-29 15:42ranjith_qualiantech_comFile Added: issue 34109 test 5838.patch
2016-10-14 09:17hgbotCheckin
2016-10-14 09:17hgbotNote Added: 0090573
2016-10-14 09:17hgbotStatusscheduled => resolved
2016-10-14 09:17hgbotResolutionopen => fixed
2016-10-14 09:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a47e9ad53154c728b732c7c37ded73996920c83c [^]
2016-10-14 09:17hgbotCheckin
2016-10-14 09:17hgbotNote Added: 0090574
2016-10-18 15:03rbianchiniNote Added: 0090674
2016-10-21 14:19marvintmReview Assigned To => marvintm
2016-10-21 14:19marvintmStatusresolved => closed
2016-11-17 14:07ranjith_qualiantech_comResolution time1476759600 => 1476741600
2016-11-17 14:07ranjith_qualiantech_comRegression date => 2015-12-02
2016-11-17 14:07ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09a201bc283c [^]

Notes
(0090573)
hgbot   
2016-10-14 09:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a47e9ad53154c728b732c7c37ded73996920c83c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 14 10:48:27 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a47e9ad53154c728b732c7c37ded73996920c83c [^]

Fixes issue 34109 : Update PaymentScheduleInvoice if the invoice amount is greater than zero

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0090574)
hgbot   
2016-10-14 09:17   
Repository: tools/automation/pi-mobile
Changeset: 638c2c109279b0ed249d2f09503f7044f37c6395
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 14 12:44:56 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/638c2c109279b0ed249d2f09503f7044f37c6395 [^]

Verifies issue 34109 : Added automated test 'I34109_VerifyInvoiceWithZeroAmount'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34109_VerifyInvoiceWithZeroAmount.java
---
(0090674)
rbianchini   
2016-10-18 15:03   
Hello Ranjit,
The patch is prepared for which version?
Can i have a version for 3.0RR16Q2.3?
Regards